From b69f690fc35885bd297f1aafdd7f85f6be2ab29b Mon Sep 17 00:00:00 2001 From: "atp (Open ERP)" Date: Fri, 19 Mar 2010 15:36:28 +0530 Subject: [PATCH] [IMP]: crm: code optimization and add docstring bzr revid: atp@tinyerp.co.in-20100319100628-o2zxj3xr6k36bubq --- addons/crm/crm_claim.py | 40 +++++----- addons/crm/crm_claims_data.xml | 137 ++++++++++++++++++--------------- addons/crm/crm_claims_demo.xml | 9 +++ addons/crm/crm_claims_menu.xml | 81 ++++++++++--------- addons/crm/crm_claims_view.xml | 113 +++++++++++++++++---------- 5 files changed, 218 insertions(+), 162 deletions(-) mode change 100644 => 100755 addons/crm/crm_claim.py mode change 100644 => 100755 addons/crm/crm_claims_data.xml mode change 100644 => 100755 addons/crm/crm_claims_demo.xml mode change 100644 => 100755 addons/crm/crm_claims_menu.xml mode change 100644 => 100755 addons/crm/crm_claims_view.xml diff --git a/addons/crm/crm_claim.py b/addons/crm/crm_claim.py old mode 100644 new mode 100755 index 2a560da15b9..cbd34af2e52 --- a/addons/crm/crm_claim.py +++ b/addons/crm/crm_claim.py @@ -23,37 +23,39 @@ from osv import fields, osv import crm class crm_claim(osv.osv): + """ + Crm claim + """ _name = "crm.claim" _description = "Claim Cases" _order = "id desc" _inherit = 'crm.case' _columns = { - 'date_closed': fields.datetime('Closed', readonly=True), - 'date': fields.datetime('Date'), - 'ref' : fields.reference('Reference', selection=crm._links_get, size=128), - 'ref2' : fields.reference('Reference 2', selection=crm._links_get, size=128), - 'canal_id': fields.many2one('res.partner.canal', 'Channel',help="The channels represent the different communication modes available with the customer." \ - " With each commercial opportunity, you can indicate the canall which is this opportunity source."), - 'planned_revenue': fields.float('Planned Revenue'), - 'planned_cost': fields.float('Planned Costs'), + 'date_closed': fields.datetime('Closed', readonly=True), + 'date': fields.datetime('Date'), + 'ref' : fields.reference('Reference', selection=crm._links_get, size=128), + 'ref2' : fields.reference('Reference 2', selection=crm._links_get, size=128), + 'canal_id': fields.many2one('res.partner.canal', 'Channel', help="The channels represent the different communication modes available with the customer." \ + " With each commercial opportunity, you can indicate the canall which is this opportunity source."), + 'planned_revenue': fields.float('Planned Revenue'), + 'planned_cost': fields.float('Planned Costs'), 'som': fields.many2one('res.partner.som', 'State of Mind', help="The minds states allow to define a value scale which represents" \ "the partner mentality in relation to our services.The scale has" \ - "to be created with a factor for each level from 0 (Very dissatisfied) to 10 (Extremely satisfied)."), - 'categ_id': fields.many2one('crm.case.categ','Category', domain="[('section_id','=',section_id),('object_id.model', '=', 'crm.claim')]"), - 'priority': fields.selection(crm.AVAILABLE_PRIORITIES, 'Priority'), - 'type_id': fields.many2one('crm.case.resource.type', 'Claim Type', domain="[('section_id','=',section_id),('object_id.model', '=', 'crm.claim')]"), + "to be created with a factor for each level from 0 (Very dissatisfied) to 10 (Extremely satisfied)."), + 'categ_id': fields.many2one('crm.case.categ', 'Category', domain="[('section_id','=',section_id),('object_id.model', '=', 'crm.claim')]"), + 'priority': fields.selection(crm.AVAILABLE_PRIORITIES, 'Priority'), + 'type_id': fields.many2one('crm.case.resource.type', 'Claim Type', domain="[('section_id','=',section_id),('object_id.model', '=', 'crm.claim')]"), - 'partner_name': fields.char("Employee's Name", size=64), - 'partner_mobile': fields.char('Mobile', size=32), - 'partner_phone': fields.char('Phone', size=32), - 'stage_id': fields.many2one ('crm.case.stage', 'Stage', domain="[('section_id','=',section_id),('object_id.model', '=', 'crm.claim')]"), - 'probability': fields.float('Probability (%)'), + 'partner_name': fields.char("Employee's Name", size=64), + 'partner_mobile': fields.char('Mobile', size=32), + 'partner_phone': fields.char('Phone', size=32), + 'stage_id': fields.many2one ('crm.case.stage', 'Stage', domain="[('section_id','=',section_id),('object_id.model', '=', 'crm.claim')]"), + 'probability': fields.float('Probability (%)'), } _defaults = { - 'priority': lambda *a: crm.AVAILABLE_PRIORITIES[2][0], + 'priority': lambda *a: crm.AVAILABLE_PRIORITIES[2][0], } crm_claim() - diff --git a/addons/crm/crm_claims_data.xml b/addons/crm/crm_claims_data.xml old mode 100644 new mode 100755 index f9388e06daf..fc1b37e14be --- a/addons/crm/crm_claims_data.xml +++ b/addons/crm/crm_claims_data.xml @@ -1,67 +1,78 @@ - + - - - Factual Claims - - - - - Value Claims - - - - - Policy Claims - - - - - - - Corrective - - - - - Preventive - - - - - - - Accepted as Claim - - - - - Fixed - - - - - Won't fix - - - - - Invalid - - - - - Awaiting Response - - - - + + + + Factual Claims + + + + + + Value Claims + + + + + + Policy Claims + + + + + + + + Corrective + + + + + + Preventive + + + + + + + + Accepted as Claim + + + + + + Fixed + + + + + + Won't fix + + + + + + Invalid + + + + + + Awaiting Response + + + + + \ No newline at end of file diff --git a/addons/crm/crm_claims_demo.xml b/addons/crm/crm_claims_demo.xml old mode 100644 new mode 100755 index 525998c02ff..daa5914e167 --- a/addons/crm/crm_claims_demo.xml +++ b/addons/crm/crm_claims_demo.xml @@ -1,9 +1,11 @@ + + @@ -20,6 +22,7 @@ + @@ -36,6 +39,7 @@ + @@ -53,6 +57,7 @@ + @@ -68,6 +73,7 @@ + @@ -84,6 +90,7 @@ + @@ -101,6 +108,7 @@ + @@ -116,5 +124,6 @@ + diff --git a/addons/crm/crm_claims_menu.xml b/addons/crm/crm_claims_menu.xml old mode 100644 new mode 100755 index e50b984f8e3..24afc46de58 --- a/addons/crm/crm_claims_menu.xml +++ b/addons/crm/crm_claims_menu.xml @@ -1,44 +1,49 @@ - - - - ######################## CLAIMS (menu) ########################### - - Claims - crm.claim - form - tree,calendar,form,graph - - - - - - tree - - - - - - calendar - - - - - - form - - - - - - graph - - - - - + + + + + + + Claims + crm.claim + form + tree,calendar,form,graph + + + + + + + tree + + + + + + + calendar + + + + + + + form + + + + + + + graph + + + + + diff --git a/addons/crm/crm_claims_view.xml b/addons/crm/crm_claims_view.xml old mode 100644 new mode 100755 index a6080a18d7a..dc9708d89ba --- a/addons/crm/crm_claims_view.xml +++ b/addons/crm/crm_claims_view.xml @@ -1,45 +1,52 @@ - # ------------------------------------------------------ - # Claims - # ------------------------------------------------------ + + + Claim Categories crm.case.categ form - - [('object_id.model', '=', 'crm.claim')] + + [('object_id.model', '=', 'crm.claim')] {'object_id':'crm.claim'} - - # ------------------------------------------------------ - # Stages - # ------------------------------------------------------ - - Claim Stages - crm.case.stage - form - - [('object_id.model', '=', 'crm.claim')] - {'object_id':'crm.claim'} - - + + - # ------------------------------------------------------ - # Resource Type - # ------------------------------------------------------ - - Claim Resource Type - crm.case.resource.type - form - - [('object_id.model', '=', 'crm.claim')] - {'object_id':'crm.claim'} - - + + + + Claim Stages + crm.case.stage + form + + [('object_id.model', '=', 'crm.claim')] + {'object_id':'crm.claim'} + + + - + + + + Claim Resource Type + crm.case.resource.type + form + + [('object_id.model', '=', 'crm.claim')] + {'object_id':'crm.claim'} + + + + + + CRM - Claims Tree crm.claim @@ -52,15 +59,24 @@ - - + + -