From 1799ba4fc1748aa52ccc499b6c2a9d1d0254d1e4 Mon Sep 17 00:00:00 2001
From: "Pinakin Nayi (OpenERP)" <pna@tinyerp.com>
Date: Fri, 29 Jun 2012 17:05:06 +0530
Subject: [PATCH 1/9] [IMP]res-partner-view

bzr revid: pna@tinyerp.com-20120629113506-1tsfiy2a8r3ims5l
---
 openerp/addons/base/res/res_partner_view.xml | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/openerp/addons/base/res/res_partner_view.xml b/openerp/addons/base/res/res_partner_view.xml
index aaab3a7d008..b58e4075061 100644
--- a/openerp/addons/base/res/res_partner_view.xml
+++ b/openerp/addons/base/res/res_partner_view.xml
@@ -237,7 +237,13 @@
                                 </group>
                             </group>
                         </page>
-                        <page string="History" invisible="True"></page>
+                        <page string="History" invisible="True">
+                            <group string="Tasks" invisible="True"></group> 
+                            <group string="Claim" invisible="True"></group>
+                            <group string="Event" invisible="True"></group>
+                            <group string="Registration" invisible="True"></group>
+                            <group string="Campaign" invisible="True"></group>
+                        </page>
                         <page string="Internal Notes">
                             <field name="comment" placeholder="Internal notes about this customer..."/>
                         </page>

From b1221084236c718da455bc2019d89ac3c1b2a02a Mon Sep 17 00:00:00 2001
From: "Pinakin Nayi (OpenERP)" <pna@tinyerp.com>
Date: Thu, 5 Jul 2012 15:32:39 +0530
Subject: [PATCH 2/9] [IMP]res-partner-imp-server

bzr revid: pna@tinyerp.com-20120705100239-3ajqioc3uzw3q0vb
---
 openerp/addons/base/res/res_partner.py       |  2 +-
 openerp/addons/base/res/res_partner_view.xml | 20 +++++++++++++-------
 2 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/openerp/addons/base/res/res_partner.py b/openerp/addons/base/res/res_partner.py
index 2165c8ad16d..b7ca88f0585 100644
--- a/openerp/addons/base/res/res_partner.py
+++ b/openerp/addons/base/res/res_partner.py
@@ -138,7 +138,7 @@ class res_partner(osv.osv):
         'child_ids': fields.one2many('res.partner', 'parent_id', 'Contacts'),
         'ref': fields.char('Reference', size=64, select=1),
         'lang': fields.selection(_lang_get, 'Language', help="If the selected language is loaded in the system, all documents related to this partner will be printed in this language. If not, it will be english."),
-        'user_id': fields.many2one('res.users', 'Salesperson', help='The internal user that is in charge of communicating with this partner if any.'),
+        'user_id': fields.many2one('res.users', 'Salesman', help='The internal user that is in charge of communicating with this partner if any.'),
         'vat': fields.char('VAT',size=32 ,help="Value Added Tax number. Check the box if the partner is subjected to the VAT. Used by the VAT legal statement."),
         'bank_ids': fields.one2many('res.partner.bank', 'partner_id', 'Banks'),
         'website': fields.char('Website',size=64, help="Website of Partner or Company"),
diff --git a/openerp/addons/base/res/res_partner_view.xml b/openerp/addons/base/res/res_partner_view.xml
index 5159a7075cc..94524242541 100644
--- a/openerp/addons/base/res/res_partner_view.xml
+++ b/openerp/addons/base/res/res_partner_view.xml
@@ -117,11 +117,13 @@
                             <label for="parent_id" class="oe_edit_only"/>
                         </div>
                         <h2 attrs="{'invisible': [('is_company','=', True)]}">
-                            <field name="parent_id"
-                                domain="[('is_company', '=', True)]" context="{'default_is_company': True}"
-                                class="oe_inline"
-                                on_change="onchange_address(use_parent_address, parent_id)"/>, 
-                            <field name="function" class="oe_inline" placeholder="Job Position"/>
+                            <group colspan="4">
+                                <field name="parent_id"
+                                    domain="[('is_company', '=', True)]" nolabel="1" context="{'default_is_company': True}"
+                                    class="oe_inline"
+                                    on_change="onchange_address(use_parent_address, parent_id)"/>, 
+                                <field name="function" nolabel="1" class="oe_inline" placeholder="Job Position"/>
+                            </group>
                         </h2>
                         <field name="category_id" widget="many2many_tags" placeholder="Tags..."/>
                     </div>
@@ -220,13 +222,17 @@
                                 <group>
                                     <field name="user_id" />
                                     <field name="company_id" groups="base.group_multi_company" widget="selection"/>
+                                </group>
+                                <group>
+                                    <field name="customer"/>
+                                    <field name="supplier"/>
+                                </group>
+                                <group>
                                     <field name="ref"/>
                                     <field name="lang"/>
                                     <field name="date"/>
                                 </group>
                                 <group>
-                                    <field name="customer"/>
-                                    <field name="supplier"/>
                                     <field name="active"/>
                                 </group>
                             </group>

From 3f5f105c97e1ac2546abe94e6ce321017b809f32 Mon Sep 17 00:00:00 2001
From: "Pinakin Nayi (OpenERP)" <pna@tinyerp.com>
Date: Thu, 5 Jul 2012 16:19:58 +0530
Subject: [PATCH 3/9] [IMP]res-partner-imp-server

bzr revid: pna@tinyerp.com-20120705104958-ahdmc32kynu4t0cj
---
 openerp/addons/base/res/res_partner.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/openerp/addons/base/res/res_partner.py b/openerp/addons/base/res/res_partner.py
index b7ca88f0585..2165c8ad16d 100644
--- a/openerp/addons/base/res/res_partner.py
+++ b/openerp/addons/base/res/res_partner.py
@@ -138,7 +138,7 @@ class res_partner(osv.osv):
         'child_ids': fields.one2many('res.partner', 'parent_id', 'Contacts'),
         'ref': fields.char('Reference', size=64, select=1),
         'lang': fields.selection(_lang_get, 'Language', help="If the selected language is loaded in the system, all documents related to this partner will be printed in this language. If not, it will be english."),
-        'user_id': fields.many2one('res.users', 'Salesman', help='The internal user that is in charge of communicating with this partner if any.'),
+        'user_id': fields.many2one('res.users', 'Salesperson', help='The internal user that is in charge of communicating with this partner if any.'),
         'vat': fields.char('VAT',size=32 ,help="Value Added Tax number. Check the box if the partner is subjected to the VAT. Used by the VAT legal statement."),
         'bank_ids': fields.one2many('res.partner.bank', 'partner_id', 'Banks'),
         'website': fields.char('Website',size=64, help="Website of Partner or Company"),

From f3e8ac8cd204d08c64d3640bebe2846f4e653947 Mon Sep 17 00:00:00 2001
From: "Kuldeep Joshi (OpenERP)" <kjo@tinyerp.com>
Date: Thu, 5 Jul 2012 18:01:34 +0530
Subject: [PATCH 4/9] [IMP] remove placeholder for job_position field

bzr revid: kjo@tinyerp.com-20120705123134-otyd3ist3clnmfb6
---
 openerp/addons/base/res/res_partner_view.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/openerp/addons/base/res/res_partner_view.xml b/openerp/addons/base/res/res_partner_view.xml
index 20dd00a4656..2fedcc01e68 100644
--- a/openerp/addons/base/res/res_partner_view.xml
+++ b/openerp/addons/base/res/res_partner_view.xml
@@ -137,7 +137,7 @@
                                 </td>
                                 <td>
                                     <h2>
-                                        <field nolabel="1" name="function" class="oe_inline" placeholder="Job Position"/>
+                                        <field nolabel="1" name="function" class="oe_inline"/>
                                     </h2>
                                 </td>
                             </tr>

From 963d91ce638eb1469fdf9b22319a80a040e4b12b Mon Sep 17 00:00:00 2001
From: "Kuldeep Joshi (OpenERP)" <kjo@tinyerp.com>
Date: Mon, 9 Jul 2012 11:10:33 +0530
Subject: [PATCH 5/9] [IMP]ir_attachment view change

bzr revid: kjo@tinyerp.com-20120709054033-5rtixxld4r5cr0lh
---
 openerp/addons/base/ir/ir.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/openerp/addons/base/ir/ir.xml b/openerp/addons/base/ir/ir.xml
index 88843b207f9..1a0a8dcf33d 100644
--- a/openerp/addons/base/ir/ir.xml
+++ b/openerp/addons/base/ir/ir.xml
@@ -769,12 +769,12 @@
                                 <field name="datas_fname"/>
                                 <field name="url" widget="url" attrs="{'invisible':[('type','=','binary')]}"/>
                             </group>
-                            <group string="Attached To">
+                            <group>
                                 <field name="res_model"/>
                                 <field name="res_id"/>
                                 <field name="res_name"/>
                             </group>
-                            <group groups="base.group_no_one" string="Created">
+                            <group groups="base.group_no_one">
                                 <field name="create_uid"/>
                                 <field name="create_date"/>
                             </group>

From 309f538936092e93b0883077c6e26f3c15365bde Mon Sep 17 00:00:00 2001
From: "Kuldeep Joshi (OpenERP)" <kjo@tinyerp.com>
Date: Tue, 10 Jul 2012 11:44:24 +0530
Subject: [PATCH 6/9] [IMP]res_partner: add separator between company and job
 field

bzr revid: kjo@tinyerp.com-20120710061424-x1g1lthyu8al0jz4
---
 openerp/addons/base/res/res_partner_view.xml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/openerp/addons/base/res/res_partner_view.xml b/openerp/addons/base/res/res_partner_view.xml
index 2fedcc01e68..90857abfe9c 100644
--- a/openerp/addons/base/res/res_partner_view.xml
+++ b/openerp/addons/base/res/res_partner_view.xml
@@ -121,6 +121,8 @@
                             
                                     </div>
                                 </td>
+                                <td>
+                                </td>
                                 <td>
                                     <label for="function" class="oe_edit_only"/>
                                 </td>
@@ -133,6 +135,12 @@
                                             domain="[('is_company', '=', True)]" context="{'default_is_company': True}"
                                             class="oe_inline"
                                             on_change="onchange_address(use_parent_address, parent_id)"/>
+                                        
+                                    </h2>
+                                </td>
+                                <td>
+                                    <h2>
+                                        <label string="," class="oe_inline" attrs="{'invisible': ['|', ('parent_id', '=', False), ('function', '=', False)]}"/>
                                     </h2>
                                 </td>
                                 <td>

From 775fc0da2f08e7386dcbce173593dbe379869fb5 Mon Sep 17 00:00:00 2001
From: Kuldeep Joshi <kjo@tinyerp.com>
Date: Wed, 18 Jul 2012 17:59:36 +0530
Subject: [PATCH 7/9] [IMP] give name to page and group

bzr revid: kjo@tinyerp.com-20120718122936-yeew81t4xnc3hsfj
---
 openerp/addons/base/res/res_partner_view.xml | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/openerp/addons/base/res/res_partner_view.xml b/openerp/addons/base/res/res_partner_view.xml
index d814ca231f9..fd8830da9ff 100644
--- a/openerp/addons/base/res/res_partner_view.xml
+++ b/openerp/addons/base/res/res_partner_view.xml
@@ -229,12 +229,12 @@
                                 </group>
                             </group>
                         </page>
-                        <page string="History" invisible="True">
-                            <group string="Tasks" invisible="True"></group> 
-                            <group string="Claim" invisible="True"></group>
-                            <group string="Event" invisible="True"></group>
-                            <group string="Registration" invisible="True"></group>
-                            <group string="Campaign" invisible="True"></group>
+                        <page string="History" name="History" invisible="True">
+                            <group name="Tasks" string="Tasks" invisible="True"></group> 
+                            <group name="Claim" string="Claim" invisible="True"></group>
+                            <group name="Event" string="Event" invisible="True"></group>
+                            <group name="Registration" string="Registration" invisible="True"></group>
+                            <group name="Campaign" string="Campaign" invisible="True"></group>
                         </page>
                         <page string="Internal Notes">
                             <field name="comment" placeholder="Internal notes about this customer..."/>

From 1d5035f250935581338cbc88ccc8518ad1cb3ccc Mon Sep 17 00:00:00 2001
From: "Harry (OpenERP)" <hmo@tinyerp.com>
Date: Thu, 19 Jul 2012 11:30:17 +0530
Subject: [PATCH 8/9] [FIX] base: res_partner_view, history tab, put comment
 and give proper name

bzr revid: hmo@tinyerp.com-20120719060017-h55rul0ltn1ly3g1
---
 openerp/addons/base/res/res_partner_view.xml | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/openerp/addons/base/res/res_partner_view.xml b/openerp/addons/base/res/res_partner_view.xml
index fd8830da9ff..882980c0f0f 100644
--- a/openerp/addons/base/res/res_partner_view.xml
+++ b/openerp/addons/base/res/res_partner_view.xml
@@ -229,12 +229,13 @@
                                 </group>
                             </group>
                         </page>
-                        <page string="History" name="History" invisible="True">
-                            <group name="Tasks" string="Tasks" invisible="True"></group> 
-                            <group name="Claim" string="Claim" invisible="True"></group>
-                            <group name="Event" string="Event" invisible="True"></group>
-                            <group name="Registration" string="Registration" invisible="True"></group>
-                            <group name="Campaign" string="Campaign" invisible="True"></group>
+                        <!-- FIX group to add fields in proper sequence order in history page but it's not good solution. we have to add sequence attribute in group element.-->
+                        <page string="History" name="page_history" invisible="True">
+                            <group name="grp_task" string="Tasks" invisible="True"></group> <!-- this group will be visible after install project module -->
+                            <group name="grp_claim" string="Claim" invisible="True"></group> <!-- this group will be visible after install crm_claim module -->
+                            <group name="grp_event" string="Event" invisible="True"></group> <!-- this group will be visible after install event module -->
+                            <group name="grp_registration" string="Registration" invisible="True"></group> <!-- this group will be visible after install event module -->
+                            <group name="grp_campaign" string="Campaign" invisible="True"></group> <!-- this group will be visible after install marketing_campaign module -->
                         </page>
                         <page string="Internal Notes">
                             <field name="comment" placeholder="Internal notes about this customer..."/>

From fab1961534114394abda674015f4e70a6897bd79 Mon Sep 17 00:00:00 2001
From: "Quentin (OpenERP)" <qdp-launchpad@openerp.com>
Date: Thu, 19 Jul 2012 11:02:04 +0200
Subject: [PATCH 9/9] [IMP] sales/crm: usability review of form views

bzr revid: qdp-launchpad@openerp.com-20120719090204-9a02uqu6vzdwm2ab
---
 openerp/addons/base/res/res_partner_view.xml | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/openerp/addons/base/res/res_partner_view.xml b/openerp/addons/base/res/res_partner_view.xml
index 882980c0f0f..bfe0533e6cb 100644
--- a/openerp/addons/base/res/res_partner_view.xml
+++ b/openerp/addons/base/res/res_partner_view.xml
@@ -229,13 +229,8 @@
                                 </group>
                             </group>
                         </page>
-                        <!-- FIX group to add fields in proper sequence order in history page but it's not good solution. we have to add sequence attribute in group element.-->
+                        <!-- The History page becomes visible as soon as there is something to display inside -->
                         <page string="History" name="page_history" invisible="True">
-                            <group name="grp_task" string="Tasks" invisible="True"></group> <!-- this group will be visible after install project module -->
-                            <group name="grp_claim" string="Claim" invisible="True"></group> <!-- this group will be visible after install crm_claim module -->
-                            <group name="grp_event" string="Event" invisible="True"></group> <!-- this group will be visible after install event module -->
-                            <group name="grp_registration" string="Registration" invisible="True"></group> <!-- this group will be visible after install event module -->
-                            <group name="grp_campaign" string="Campaign" invisible="True"></group> <!-- this group will be visible after install marketing_campaign module -->
                         </page>
                         <page string="Internal Notes">
                             <field name="comment" placeholder="Internal notes about this customer..."/>