From b5de65ed6bfc3fb1e819e41c10ff2fd947eebe7a Mon Sep 17 00:00:00 2001
From: Nhomar Hernandez <nhomar@vauxoo.com>
Date: Sat, 30 Sep 2017 15:29:21 +0200
Subject: [PATCH] [FIX] sales: Set proper group on all menus to avoid basic
 users like a warehouse basic user see all the sales app.

I did not hide the main menu only because when we customize, we can use
such menu for other purposes we just set the proper group on all first
level menus and then by default the app is hidden if a custom module add
a menu there without explicit groups then this will be shown again (which I
think is the expected behaviour).

Closes #19816
---
 addons/sale/views/sale_views.xml | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/addons/sale/views/sale_views.xml b/addons/sale/views/sale_views.xml
index 32ef3464bae..9f14e43ce10 100644
--- a/addons/sale/views/sale_views.xml
+++ b/addons/sale/views/sale_views.xml
@@ -17,7 +17,7 @@
         <menuitem id="res_partner_menu"
             parent="sale_order_menu"
             action="base.action_partner_form"
-            sequence="3"/>
+            sequence="3" groups="sales_team.group_sale_salesman"/>
 
         <menuitem id="menu_sale_config"
             name="Configuration"
@@ -29,7 +29,7 @@
             parent= "menu_sale_config"
             sequence= "3"
             name= "Sales Orders"
-            groups= "sales_team.group_sale_manager,sales_team.group_sale_salesman,account.group_account_manager,account.group_account_user"/>
+            groups= "sales_team.group_sale_manager,account.group_account_manager,account.group_account_user"/>
 
         <menuitem id="sales_team_config"
             name="Sales Channels"
@@ -61,7 +61,7 @@
             parent="menu_sale_report"
             sequence="3"/>
 
-        <menuitem id="product_menu_catalog" name="Catalog" action="product.product_template_action" parent="sale_menu_root" sequence="4"/>
+        <menuitem id="product_menu_catalog" name="Catalog" action="product.product_template_action" parent="sale_menu_root" sequence="4" groups="sales_team.group_sale_salesman"/>
         <menuitem id="menu_product" name="Product Variants" parent="product_menu_catalog" sequence="2" groups="product.group_product_variant" active="False"/>
         <menuitem action="product.product_template_action" id="menu_product_template_action" parent="product_menu_catalog" sequence="1" active="False"/>
         <menuitem id="prod_config_main" name="Products" parent="menu_sale_config" sequence="5"/>
@@ -507,7 +507,7 @@
             name="Orders"
             action="action_orders"
             parent="sale_order_menu"
-            sequence="2" groups="sales_team.group_sale_salesman,sales_team.group_sale_manager"/>
+            sequence="2" groups="sales_team.group_sale_salesman"/>
 
         <record id="action_orders_to_invoice" model="ir.actions.act_window">
             <field name="name">Orders to Invoice</field>
@@ -531,7 +531,7 @@
         <menuitem id="menu_sale_invoicing"
             name="Invoicing"
             parent="sale_menu_root"
-            sequence="3"/>
+            sequence="3" groups="sales_team.group_sale_salesman"/>
 
         <menuitem id="menu_sale_order_invoice"
             action="action_orders_to_invoice"
@@ -588,7 +588,7 @@
         <menuitem id="menu_sale_quotations"
                 action="action_quotations"
                 parent="sale_order_menu"
-                sequence="1"/>
+                sequence="1" groups="sales_team.group_sale_salesman"/>
 
         <record id="view_order_line_tree" model="ir.ui.view">
             <field name="name">sale.order.line.tree</field>