From b5921fbfa8ae7861916e6c86597bdf37c2753101 Mon Sep 17 00:00:00 2001
From: Nicolas Martinelli <nim@odoo.com>
Date: Wed, 13 Mar 2019 09:38:40 +0000
Subject: [PATCH] [FIX] sale: exclude all attributes

With the demo data:
- Go to Sale > Products > Products, search for 'Customizable Desk'
- Click on 'Configure Variants'
- For variant 'Legs: Steel', add all attribute values for the
  'Conference Chair'
- Create a SO, add a line with 'Configure Product'
- Select the 'Customizable Desk' with 'Legs: Steel', add

Boom boom, traceback at template rendering at
`first_possible_combination[variant_id_index] == value_id`

This is because the `parent_combination` is not taken into account when
evaluating `_is_add_to_cart_possible`.

closes odoo/odoo#31496

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
---
 addons/sale/views/sale_product_configurator_templates.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/sale/views/sale_product_configurator_templates.xml b/addons/sale/views/sale_product_configurator_templates.xml
index 6711dd2db8b..075a4f11751 100644
--- a/addons/sale/views/sale_product_configurator_templates.xml
+++ b/addons/sale/views/sale_product_configurator_templates.xml
@@ -152,7 +152,7 @@
     <template id="optional_product_items">
         <t t-foreach="product.optional_product_ids" t-as="product">
             <t t-set="first_possible_combination" t-value="product._get_first_possible_combination(parent_combination)"/>
-            <t t-if="product._is_add_to_cart_possible()">
+            <t t-if="product._is_add_to_cart_possible(parent_combination)">
 
                 <t t-set="combination_info" t-value="product._get_combination_info(first_possible_combination, add_qty=add_qty or 1, pricelist=pricelist)"/>
                 <t t-set="product_variant" t-value="product.env['product.product'].browse(combination_info['product_id'])"/>