From b55e844e1a2118d7fd5f243bfe2244fe8332d707 Mon Sep 17 00:00:00 2001
From: Florent de Labarre <florent.mirieu@gmail.com>
Date: Thu, 25 Jan 2018 23:34:30 -0500
Subject: [PATCH] [FIX] stock: check the state before put in pack

Makes consistent the Python logic and the view.

Closes #22534
opw-813477
---
 addons/stock/models/stock_picking.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/stock/models/stock_picking.py b/addons/stock/models/stock_picking.py
index 24ff58c843a..c2d8b3beaf8 100644
--- a/addons/stock/models/stock_picking.py
+++ b/addons/stock/models/stock_picking.py
@@ -831,7 +831,7 @@ class Picking(models.Model):
 
     def _put_in_pack(self):
         package = False
-        for pick in self:
+        for pick in self.filtered(lambda p: p.state not in ('done', 'cancel')):
             operations = pick.move_line_ids.filtered(lambda o: o.qty_done > 0 and not o.result_package_id)
             operation_ids = self.env['stock.move.line']
             if operations: