From b3bc5a0a03d8685f4af82fc671c6e1f980d87107 Mon Sep 17 00:00:00 2001
From: "Michael (mcm)" <mcm@odoo.com>
Date: Tue, 26 Jul 2022 07:44:08 +0000
Subject: [PATCH] [FIX] web: less bounce edit form button

Before this commit, the edit button in form view bounced on any click.
Now, the button bounces only when clicking in the area of a field or its label.

closes odoo/odoo#96784

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
---
 addons/web/static/src/views/form/form_renderer.js     | 4 ++--
 addons/web/static/tests/views/form/form_view_tests.js | 6 ++++++
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/addons/web/static/src/views/form/form_renderer.js b/addons/web/static/src/views/form/form_renderer.js
index e6b5fb9fad6..cfa4a2a3459 100644
--- a/addons/web/static/src/views/form/form_renderer.js
+++ b/addons/web/static/src/views/form/form_renderer.js
@@ -31,8 +31,8 @@ export class FormRenderer extends Component {
             this.compileParams
         );
         useSubEnv({ model: record.model });
-        useBounceButton(useRef("compiled_view_root"), () => {
-            return !record.isInEdition;
+        useBounceButton(useRef("compiled_view_root"), (target) => {
+            return !record.isInEdition && !!target.closest(".oe_title, .o_inner_group");
         });
         this.uiService = useService('ui');
         this.onResize = useDebounced(this.render, 200);
diff --git a/addons/web/static/tests/views/form/form_view_tests.js b/addons/web/static/tests/views/form/form_view_tests.js
index b6fc9378e9e..2f263240039 100644
--- a/addons/web/static/tests/views/form/form_view_tests.js
+++ b/addons/web/static/tests/views/form/form_view_tests.js
@@ -9131,11 +9131,17 @@ QUnit.module("Views", (hooks) => {
                     <div class="oe_title">
                         <field name="display_name"/>
                     </div>
+                    <notebook>
+                        <page name="a" string="A"></page>
+                    </notebook>
                 </form>`,
             resId: 1,
         });
 
         // in readonly
+        await click(target.querySelector(".nav-tabs .nav-item"));
+        assert.containsNone(target, ".o_catch_attention");
+
         await click(target.querySelector("div.oe_title"));
         assert.hasClass(target.querySelector(".o_form_button_edit"), "o_catch_attention");