From b3277372ef0ac8b5caab19636051b28d5b72d3fc Mon Sep 17 00:00:00 2001 From: Pierre Paridans Date: Mon, 4 Jan 2021 20:30:45 +0000 Subject: [PATCH] [FIX] web: restore post-test check for qunit-fixture elements Disabled in odoo/odoo@b992619840a70c600c50fac0383ad9396351af75 by mistake. Also, restore the "failfast" for the QUnit tests (disabled in the same commit...). X-original-commit: 7f8e0fe4d2a47968bdcb136fd7e6d96a184f9eae --- addons/web/static/tests/helpers/qunit_config.js | 6 +++--- addons/web/tests/test_js.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/addons/web/static/tests/helpers/qunit_config.js b/addons/web/static/tests/helpers/qunit_config.js index a8c42fee8b3..158c67b2891 100644 --- a/addons/web/static/tests/helpers/qunit_config.js +++ b/addons/web/static/tests/helpers/qunit_config.js @@ -183,9 +183,9 @@ QUnit.on('OdooAfterTestHook', function (info) { // check for leftovers in #qunit-fixture const qunitFixture = document.getElementById('qunit-fixture'); if (qunitFixture.children.length) { - // console.error('#qunit-fixture still contains elements:' + - // '\n#qunit-fixture HTML:\n' + qunitFixture.outerHTML); - // QUnit.pushFailure(`#qunit-fixture still contains elements`); + console.error('#qunit-fixture still contains elements:' + + '\n#qunit-fixture HTML:\n' + qunitFixture.outerHTML); + QUnit.pushFailure(`#qunit-fixture still contains elements`); toRemove.push(...qunitFixture.children); } diff --git a/addons/web/tests/test_js.py b/addons/web/tests/test_js.py index 8a74daecbd2..4d97e5f28d0 100644 --- a/addons/web/tests/test_js.py +++ b/addons/web/tests/test_js.py @@ -12,7 +12,7 @@ class WebSuite(odoo.tests.HttpCase): def test_js(self): # webclient desktop test suite - self.browser_js('/web/tests?mod=web', "", "", login='admin', timeout=1800) + self.browser_js('/web/tests?mod=web&failfast', "", "", login='admin', timeout=1800) def test_check_suite(self): # verify no js test is using `QUnit.only` as it forbid any other test to be executed