From b2325c1b7e239d93fd3d205295dae53a32a8b422 Mon Sep 17 00:00:00 2001
From: Benjamin Vray <bvr@odoo.com>
Date: Mon, 13 Sep 2021 09:50:23 +0000
Subject: [PATCH] [FIX] website_payment: use span instead of button for
 donation snippet

This commit replaces the <button> elements used in the custom button of
the donation snippet by <span> elements because putting inputs inside
buttons is not valid HTML.

task-2637492

closes odoo/odoo#78089

X-original-commit: 38447f80f462ebf9d0877b5e170bb5dc1bf13725
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
---
 .../static/src/snippets/s_donation/000.xml                | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/addons/website_payment/static/src/snippets/s_donation/000.xml b/addons/website_payment/static/src/snippets/s_donation/000.xml
index 011db1d9482..ba9b81a9688 100644
--- a/addons/website_payment/static/src/snippets/s_donation/000.xml
+++ b/addons/website_payment/static/src/snippets/s_donation/000.xml
@@ -9,9 +9,9 @@
                         t-att-data-donation-value="prefilled_button_value"
                         t-esc="prefilled_button_value"/>
             </t>
-            <button t-if="custom_input" type="button" class="s_donation_btn s_donation_custom_btn btn btn-outline-primary btn-lg mb-2 mr-1">
+            <span t-if="custom_input" class="s_donation_btn s_donation_custom_btn btn btn-outline-primary btn-lg mb-2 mr-1">
                 <input id="s_donation_amount_input" type="number" t-att-min="minimum_amount" class="" placeholder="Custom Amount" aria-label="Amount"/>
-            </button>
+            </span>
         </div>
     </t>
     <t t-name="website_payment.donation.prefilledButtonsDescriptions">
@@ -26,9 +26,9 @@
                 </div>
             </t>
             <div t-if="custom_input" class="d-sm-flex align-items-center my-3">
-                <button type="button" class="s_donation_btn s_donation_custom_btn btn btn-outline-primary btn-lg">
+                <span class="s_donation_btn s_donation_custom_btn btn btn-outline-primary btn-lg">
                     <input id="s_donation_amount_input" type="number" t-att-min="minimum_amount" placeholder="Custom Amount" aria-label="Amount"/>
-                </button>
+                </span>
             </div>
         </div>
     </t>