From b1b83925913136f82e1af710643aeeebaca086cc Mon Sep 17 00:00:00 2001
From: Nicolas Martinelli <nim@odoo.com>
Date: Thu, 2 Feb 2017 09:59:29 +0100
Subject: [PATCH] [FIX] sales_team, crm: expected closing

On the CRM dashboard, the shortcut 'exp. closing' is the same than the
'overdue' shortcut. However, the number of opportunities in these
categories is computed differently (see method
`retrieve_sales_dashboard`).

We introduce a new filter "Overdue Opportunities" which reflects this
difference.

Backport of 9d2f48dc7fa9d5de3e850ff7ac82d9b31cf188cd

opw-704173
opw-751165
---
 addons/crm/crm_lead_view.xml                              | 3 +++
 addons/sales_team/static/src/js/sales_team_dashboard.js   | 2 ++
 addons/sales_team/static/src/xml/sales_team_dashboard.xml | 2 +-
 3 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/addons/crm/crm_lead_view.xml b/addons/crm/crm_lead_view.xml
index f5deb670046..12dddbe0e62 100644
--- a/addons/crm/crm_lead_view.xml
+++ b/addons/crm/crm_lead_view.xml
@@ -633,6 +633,9 @@
                             ]"/>
                     <filter string="Overdue Activities" name="overdue"
                             domain="[('date_action', '&lt;', context_today().strftime('%Y-%m-%d'))]"/>
+                    <filter string="Overdue Opportunities" name="overdue_opp"
+                            domain="[('date_deadline', '&lt;', context_today().strftime('%Y-%m-%d'))]"
+                            help="Show all opportunities with a deadline for which the next action date is before today"/>
                     <separator/>
                     <filter string="Follow-up" name="follow_up"
                             domain="[('date_action', '&lt;=', context_today().strftime('%Y-%m-%d') )]"
diff --git a/addons/sales_team/static/src/js/sales_team_dashboard.js b/addons/sales_team/static/src/js/sales_team_dashboard.js
index dd9984c89c4..e5bdb4dd5cd 100644
--- a/addons/sales_team/static/src/js/sales_team_dashboard.js
+++ b/addons/sales_team/static/src/js/sales_team_dashboard.js
@@ -67,6 +67,8 @@ var SalesTeamDashboardView = KanbanView.extend({
         } else if (action_name === 'crm.action_your_pipeline') {
             if (action_extra === 'overdue') {
                 additional_context['search_default_overdue'] = 1;
+            } else if (action_extra === 'overdue_opp') {
+                additional_context['search_default_overdue_opp'] = 1;
             }
         } else if (action_name === 'crm.crm_opportunity_report_action_graph') {
             additional_context['search_default_won'] = 1;
diff --git a/addons/sales_team/static/src/xml/sales_team_dashboard.xml b/addons/sales_team/static/src/xml/sales_team_dashboard.xml
index 33b9725d199..39f998c8561 100644
--- a/addons/sales_team/static/src/xml/sales_team_dashboard.xml
+++ b/addons/sales_team/static/src/xml/sales_team_dashboard.xml
@@ -84,7 +84,7 @@
                             </a>
                         </td>
                         <td  t-if="show_demo or (values and values['closing']['overdue'] != 0)" class="o_warning" title="To Opportunities">
-                            <a href="#" class="o_dashboard_action" name="crm.action_your_pipeline" data-extra="overdue">
+                            <a href="#" class="o_dashboard_action" name="crm.action_your_pipeline" data-extra="overdue_opp">
                                 <t t-if="!show_demo">
                                     <t t-esc="values['closing']['overdue']"/> exp. closing
                                 </t>