From 9ac53b07dbc8bf6e188b139567e1b6f69ad60670 Mon Sep 17 00:00:00 2001
From: Arnaud Joset <arj@odoo.com>
Date: Tue, 2 Nov 2021 11:22:41 +0100
Subject: [PATCH 1/2] [IMP] sale,sale_management: adaption for subscription
 override of SO

Before this commit, the sale module could not be used to manage subscriptions in an override.
This commit adapts the sale module to https://github.com/odoo/enterprise/pull/21825

taskid: 2568007
---
 addons/sale/data/sale_demo.xml                |  1 -
 addons/sale/models/sale_order.py              | 19 ++++++++++---------
 addons/sale/models/sale_order_line.py         |  3 +--
 addons/sale/views/sale_order_views.xml        |  6 +++---
 addons/sale_coupon/models/__init__.py         |  1 +
 addons/sale_coupon/models/sale_order.py       |  1 -
 addons/sale_coupon/models/sale_order_line.py  | 12 ++++++++++++
 addons/sale_management/models/sale_order.py   |  4 ++++
 addons/sale_project/models/sale_order_line.py |  3 +--
 addons/sale_stock/models/sale_order_line.py   |  5 ++---
 addons/sale_stock/tests/test_create_perf.py   |  6 +++---
 .../sale_timesheet/tests/test_sale_service.py |  5 -----
 .../static/tests/tours/main_flow.js           |  4 ++--
 13 files changed, 39 insertions(+), 31 deletions(-)
 create mode 100644 addons/sale_coupon/models/sale_order_line.py

diff --git a/addons/sale/data/sale_demo.xml b/addons/sale/data/sale_demo.xml
index 19ab8581ae4..3f5d78eac42 100644
--- a/addons/sale/data/sale_demo.xml
+++ b/addons/sale/data/sale_demo.xml
@@ -236,7 +236,6 @@
     </record>
 
     <record id="sale_order_8" model="sale.order">
-        <field name="name">Test/001</field>
         <field name="partner_id" ref="base.res_partner_3"/>
         <field name="partner_invoice_id" ref="base.res_partner_address_25"/>
         <field name="partner_shipping_id" ref="base.res_partner_address_25"/>
diff --git a/addons/sale/models/sale_order.py b/addons/sale/models/sale_order.py
index 4c88e874a6b..54ed61650f2 100644
--- a/addons/sale/models/sale_order.py
+++ b/addons/sale/models/sale_order.py
@@ -841,10 +841,11 @@ class SaleOrder(models.Model):
         lines_to_recompute.discount = 0.0
         lines_to_recompute._compute_discount()
         self.show_update_pricelist = False
-        self.message_post(body=_(
-            "Product prices have been recomputed according to pricelist %s.",
-            self.pricelist_id._get_html_link(),
-        ))
+        if self.partner_id and self.id:
+            self.message_post(body=_(
+                "Product prices have been recomputed according to pricelist %s.",
+                self.pricelist_id._get_html_link(),
+            ))
 
     # INVOICING #
 
@@ -916,9 +917,9 @@ class SaleOrder(models.Model):
     def _get_invoice_grouping_keys(self):
         return ['company_id', 'partner_id', 'currency_id']
 
-    @api.model
-    def _nothing_to_invoice_error(self):
-        return UserError(_(
+    def _nothing_to_invoice_error_message(self):
+        self.ensure_one()
+        return _(
             "There is nothing to invoice!\n\n"
             "Reason(s) of this behavior could be:\n"
             "- You should deliver your products before invoicing them: Click on the \"truck\" icon "
@@ -927,7 +928,7 @@ class SaleOrder(models.Model):
             "\"Sales\" tab and modify invoicing policy from \"delivered quantities\" to \"ordered "
             "quantities\". For Services, you should modify the Service Invoicing Policy to "
             "'Prepaid'."
-        ))
+        )
 
     def _get_invoiceable_lines(self, final=False):
         """Return the invoiceable lines for order `self`."""
@@ -1007,7 +1008,7 @@ class SaleOrder(models.Model):
             invoice_vals_list.append(invoice_vals)
 
         if not invoice_vals_list:
-            raise self._nothing_to_invoice_error()
+            raise UserError(order._nothing_to_invoice_error_message())
 
         # 2) Manage 'grouped' parameter: group by (partner_id, currency_id).
         if not grouped:
diff --git a/addons/sale/models/sale_order_line.py b/addons/sale/models/sale_order_line.py
index 67d98c6aa89..ec23f36dc43 100644
--- a/addons/sale/models/sale_order_line.py
+++ b/addons/sale/models/sale_order_line.py
@@ -731,7 +731,7 @@ class SaleOrderLine(models.Model):
         calculated from the ordered quantity. Otherwise, the quantity delivered is used.
         """
         for line in self:
-            if line.state in ['sale', 'done']:
+            if line.state in ['sale', 'done'] and not line.display_type:
                 if line.product_id.invoice_policy == 'order':
                     line.qty_to_invoice = line.product_uom_qty - line.qty_invoiced
                 else:
@@ -904,7 +904,6 @@ class SaleOrderLine(models.Model):
                 }
 
     #=== CRUD METHODS ===#
-
     def _add_precomputed_values(self, vals_list):
         """ In the specific case where the discount is provided in the create values
         without being rounded, we have to 'manually' round it otherwise it won't be,
diff --git a/addons/sale/views/sale_order_views.xml b/addons/sale/views/sale_order_views.xml
index 7e3a0830133..a1d9dbafa36 100644
--- a/addons/sale/views/sale_order_views.xml
+++ b/addons/sale/views/sale_order_views.xml
@@ -195,10 +195,10 @@
                         string="Void Transaction" data-hotkey="shift+v"
                         confirm="Are you sure you want to void the authorized transaction? This action can't be undone."
                         attrs="{'invisible': [('authorized_transaction_ids', '=', [])]}"/>
-                <button name="%(sale.action_view_sale_advance_payment_inv)d" string="Create Invoice"
+                <button id="create_invoice" name="%(sale.action_view_sale_advance_payment_inv)d" string="Create Invoice"
                     type="action" class="btn-primary" data-hotkey="q"
                     attrs="{'invisible': [('invoice_status', '!=', 'to invoice')]}"/>
-                <button name="%(sale.action_view_sale_advance_payment_inv)d" string="Create Invoice"
+                <button id="create_invoice_percentage" name="%(sale.action_view_sale_advance_payment_inv)d" string="Create Invoice"
                     type="action" context="{'default_advance_payment_method': 'percentage'}" data-hotkey="q"
                     attrs="{'invisible': ['|',('invoice_status', '!=', 'no'), ('state', '!=', 'sale')]}"/>
                 <button name="action_quotation_send" string="Send by Email" type="object" states="draft" class="btn-primary" data-hotkey="g"/>
@@ -589,7 +589,7 @@
                                 <field name="client_order_ref"/>
                                 <field name="tag_ids" widget="many2many_tags" options="{'color_field': 'color', 'no_create_edit': True}"/>
                             </group>
-                            <group name="sale_info" string="Invoicing">
+                            <group name="sale_info" string="Invoicing and Payments">
                                 <field name="fiscal_position_id" options="{'no_create': True}"/>
                                 <field name="analytic_account_id" context="{'default_partner_id':partner_invoice_id, 'default_name':name}" attrs="{'readonly': [('invoice_count','!=',0),('state','=','sale')]}" groups="analytic.group_analytic_accounting" force_save="1"/>
                                 <field name="invoice_status" states="sale,done" groups="base.group_no_one"/>
diff --git a/addons/sale_coupon/models/__init__.py b/addons/sale_coupon/models/__init__.py
index 96ba4f08310..f50c45ebe7f 100644
--- a/addons/sale_coupon/models/__init__.py
+++ b/addons/sale_coupon/models/__init__.py
@@ -4,3 +4,4 @@
 from . import coupon
 from . import coupon_program
 from . import sale_order
+from . import sale_order_line
diff --git a/addons/sale_coupon/models/sale_order.py b/addons/sale_coupon/models/sale_order.py
index 64a2dfb7ec9..012ecc3148b 100644
--- a/addons/sale_coupon/models/sale_order.py
+++ b/addons/sale_coupon/models/sale_order.py
@@ -63,7 +63,6 @@ class SaleOrder(models.Model):
         return res
 
     def _get_reward_lines(self):
-        self.ensure_one()
         return self.order_line.filtered(lambda line: line.is_reward_line)
 
     def _is_reward_in_order_lines(self, program):
diff --git a/addons/sale_coupon/models/sale_order_line.py b/addons/sale_coupon/models/sale_order_line.py
new file mode 100644
index 00000000000..d433847c7ba
--- /dev/null
+++ b/addons/sale_coupon/models/sale_order_line.py
@@ -0,0 +1,12 @@
+# -*- coding: utf-8 -*-
+# Part of Odoo. See LICENSE file for full copyright and licensing details.
+
+from odoo import models
+
+class OrderLine(models.Model):
+    _inherit = 'sale.order.line'
+
+    def _compute_name(self):
+        # Avoid computing the name for reward lines
+        reward = self.filtered('is_reward_line')
+        super(OrderLine, self - reward)._compute_name()
diff --git a/addons/sale_management/models/sale_order.py b/addons/sale_management/models/sale_order.py
index 61a10d010f7..5960624e015 100644
--- a/addons/sale_management/models/sale_order.py
+++ b/addons/sale_management/models/sale_order.py
@@ -252,6 +252,8 @@ class SaleOrderOption(models.Model):
             new_sol = self.env['sale.order.line'].new(values)
             new_sol._compute_price_unit()
             option.price_unit = new_sol.price_unit
+            # Avoid attaching the new line when called on template change
+            new_sol.order_id = False
 
     @api.depends('product_id', 'uom_id', 'quantity')
     def _compute_discount(self):
@@ -263,6 +265,8 @@ class SaleOrderOption(models.Model):
             new_sol = self.env['sale.order.line'].new(values)
             new_sol._compute_discount()
             option.discount = new_sol.discount
+            # Avoid attaching the new line when called on template change
+            new_sol.order_id = False
 
     def _get_values_to_add_to_order(self):
         self.ensure_one()
diff --git a/addons/sale_project/models/sale_order_line.py b/addons/sale_project/models/sale_order_line.py
index 7d43276bb57..8a569491a32 100644
--- a/addons/sale_project/models/sale_order_line.py
+++ b/addons/sale_project/models/sale_order_line.py
@@ -25,11 +25,10 @@ class SaleOrderLine(models.Model):
 
     @api.depends('product_id.type')
     def _compute_product_updatable(self):
+        super()._compute_product_updatable()
         for line in self:
             if line.product_id.type == 'service' and line.state == 'sale':
                 line.product_updatable = False
-            else:
-                super(SaleOrderLine, line)._compute_product_updatable()
 
     def _auto_init(self):
         """
diff --git a/addons/sale_stock/models/sale_order_line.py b/addons/sale_stock/models/sale_order_line.py
index 2c63eb0d008..41b7afff674 100644
--- a/addons/sale_stock/models/sale_order_line.py
+++ b/addons/sale_stock/models/sale_order_line.py
@@ -209,10 +209,9 @@ class SaleOrderLine(models.Model):
 
     @api.depends('move_ids')
     def _compute_product_updatable(self):
+        super()._compute_product_updatable()
         for line in self:
-            if not line.move_ids.filtered(lambda m: m.state != 'cancel'):
-                super(SaleOrderLine, line)._compute_product_updatable()
-            else:
+            if line.move_ids.filtered(lambda m: m.state != 'cancel'):
                 line.product_updatable = False
 
     @api.depends('product_id')
diff --git a/addons/sale_stock/tests/test_create_perf.py b/addons/sale_stock/tests/test_create_perf.py
index 8de0e0eb37c..109e7aa2440 100644
--- a/addons/sale_stock/tests/test_create_perf.py
+++ b/addons/sale_stock/tests/test_create_perf.py
@@ -52,7 +52,7 @@ class TestPERF(common.TransactionCase):
         # + 1 warehouse fetch
         # + 1 query to get analytic default account
         # + 1 followers queries ?
-        with self.assertQueryCount(admin=40):
+        with self.assertQueryCount(admin=42):
             self.env['sale.order'].create([{
                 'partner_id': self.partners[0].id,
                 'user_id': self.salesmans[0].id,
@@ -63,7 +63,7 @@ class TestPERF(common.TransactionCase):
     def test_dummy_sales_orders_batch_creation_perf(self):
         """ Dummy SOlines (notes/sections) should not add any custom queries other than their insert"""
         # + 2 SOL (batched) insert
-        with self.assertQueryCount(admin=42):
+        with self.assertQueryCount(admin=44):
             self.env['sale.order'].create([{
                 'partner_id': self.partners[0].id,
                 'user_id': self.salesmans[0].id,
@@ -80,7 +80,7 @@ class TestPERF(common.TransactionCase):
         # + 2 SQL insert
         # + 2 queries to get analytic default tags
         # + 9 follower queries ?
-        with self.assertQueryCount(admin=53):
+        with self.assertQueryCount(admin=57):
             self.env['sale.order'].create([{
                 'partner_id': self.partners[0].id,
                 'user_id': self.salesmans[0].id,
diff --git a/addons/sale_timesheet/tests/test_sale_service.py b/addons/sale_timesheet/tests/test_sale_service.py
index ddfb167ece2..60d89e1dacd 100644
--- a/addons/sale_timesheet/tests/test_sale_service.py
+++ b/addons/sale_timesheet/tests/test_sale_service.py
@@ -29,13 +29,8 @@ class TestSaleService(TestCommonSaleTimesheet):
             'product_uom_qty': 50,
         })
 
-        self.sale_order.order_line._compute_product_updatable()
         self.assertTrue(sale_order_line.product_updatable)
         self.sale_order.action_confirm()
-        self.sale_order.order_line._compute_product_updatable()
-
-        self.sale_order.action_confirm()
-        self.sale_order.order_line._compute_product_updatable()
         self.assertFalse(sale_order_line.product_updatable)
         self.assertEqual(self.sale_order.invoice_status, 'no', 'Sale Service: there should be nothing to invoice after validation')
 
diff --git a/odoo/addons/test_main_flows/static/tests/tours/main_flow.js b/odoo/addons/test_main_flows/static/tests/tours/main_flow.js
index 77654c7f015..488b1649eb5 100644
--- a/odoo/addons/test_main_flows/static/tests/tours/main_flow.js
+++ b/odoo/addons/test_main_flows/static/tests/tours/main_flow.js
@@ -859,13 +859,13 @@ tour.stepUtils.openBuggerMenu("li.breadcrumb-item.active:contains('Quotations')"
     position: "bottom"
 }, {
     mobile: false,
-    trigger: ".o_data_row:first",
+    trigger: ".o_data_cell:contains('the_flow.customer')",
     extra_trigger: '.o_control_panel .breadcrumb:contains("Sales Orders")',
     content: _t("Go to the last sale order"),
     position: "right"
 }, {
     mobile: true,
-    trigger: ".o_kanban_record:first",
+    trigger: ".o_kanban_record .o_kanban_record_title:contains('the_flow.customer')",
     extra_trigger: '.o_control_panel .breadcrumb:contains("Sales Orders")',
     content: _t("Go to the last sale order"),
     position: "bottom"

From 44dc3910e21901e55359944859a8c2c1f25434ac Mon Sep 17 00:00:00 2001
From: Arnaud Joset <arj@odoo.com>
Date: Thu, 3 Mar 2022 09:07:10 +0100
Subject: [PATCH 2/2] [IMP] sale: create a JS mixin to update all discounts
 value

Before this commit, the ProductDiscountWidget (sale.product_discount) worked by overriding the reset method.
The main drawback is that the reset method is called whanever a field on the line is changed.
This commit rely on _onFieldChanged that allows to target single change. A small mixin is created to allow working with different kind of fields of the SOL.

taskid: 2568007
---
 addons/sale/__manifest__.py                   |  2 +
 .../static/src/js/product_discount_widget.js  | 19 +---
 .../static/src/js/sale_order_controller.js    | 88 +++++++++++++++++++
 .../static/src/js/sale_order_line_mixin.js    | 18 ++++
 addons/sale/static/src/js/sale_order_view.js  | 40 +--------
 5 files changed, 113 insertions(+), 54 deletions(-)
 create mode 100644 addons/sale/static/src/js/sale_order_controller.js
 create mode 100644 addons/sale/static/src/js/sale_order_line_mixin.js

diff --git a/addons/sale/__manifest__.py b/addons/sale/__manifest__.py
index de75dfc1812..992e81c7b63 100644
--- a/addons/sale/__manifest__.py
+++ b/addons/sale/__manifest__.py
@@ -63,7 +63,9 @@ This module contains all the common features of Sales Management and eCommerce.
             'sale/static/src/scss/product_configurator.scss',
             'sale/static/src/js/sale.js',
             'sale/static/src/js/tours/sale.js',
+            'sale/static/src/js/sale_order_line_mixin.js',
             'sale/static/src/js/product_configurator_widget.js',
+            'sale/static/src/js/sale_order_controller.js',
             'sale/static/src/js/sale_order_view.js',
             'sale/static/src/js/product_discount_widget.js',
         ],
diff --git a/addons/sale/static/src/js/product_discount_widget.js b/addons/sale/static/src/js/product_discount_widget.js
index ede118000c0..14933d654f2 100644
--- a/addons/sale/static/src/js/product_discount_widget.js
+++ b/addons/sale/static/src/js/product_discount_widget.js
@@ -3,6 +3,7 @@ odoo.define('sale.product_discount', function (require) {
 
     const BasicFields = require('web.basic_fields');
     const FieldsRegistry = require('web.field_registry');
+    const UpdateAllLinesMixin = require('sale.UpdateAllLinesMixin');
 
     /**
      * The sale.product_discount widget is a simple widget extending FieldFloat
@@ -11,22 +12,10 @@ odoo.define('sale.product_discount', function (require) {
      * !!! WARNING !!!
      *
      * This widget is only designed for sale_order_line creation/updates.
-     * !!! It should only be used on a discount field !!!
      */
-    const ProductDiscountWidget = BasicFields.FieldFloat.extend({
-
-        /**
-         * Override changes at a discount.
-         *
-         * @override
-         * @param {OdooEvent} ev
-         *
-         */
-        async reset(record, ev) {
-            if (ev && ev.data.changes && ev.data.changes.discount >= 0) {
-               this.trigger_up('open_discount_wizard');
-            }
-            this._super(...arguments);
+    const ProductDiscountWidget = BasicFields.FieldFloat.extend(UpdateAllLinesMixin, {
+        _getUpdateAllLinesAction: function () {
+            return 'open_update_all_wizard';
         },
     });
 
diff --git a/addons/sale/static/src/js/sale_order_controller.js b/addons/sale/static/src/js/sale_order_controller.js
new file mode 100644
index 00000000000..81d7105a955
--- /dev/null
+++ b/addons/sale/static/src/js/sale_order_controller.js
@@ -0,0 +1,88 @@
+odoo.define('sale.SaleOrderFormController', function (require) {
+    "use strict";
+
+    const FormController = require('web.FormController');
+    const Dialog = require('web.Dialog');
+    const core = require('web.core');
+    const _t = core._t;
+
+    const SaleOrderFormController = FormController.extend({
+        custom_events: _.extend({}, FormController.prototype.custom_events, {
+            open_update_all_wizard: '_onOpenUpdateAllWizard',
+        }),
+
+        // -------------------------------------------------------------------------
+        // Handlers
+        // -------------------------------------------------------------------------
+
+        /**
+         * Handler called if user changes a value in the sale order line.
+         * The wizard will open only if
+         *  (1) Sale order line is 3 or more
+         *  (2) First sale order line is changed
+         *  (3) value is the same in all other sale order line
+         */
+        _onOpenUpdateAllWizard(ev) {
+            const orderLines = this._DialogReady(ev, 'normal')
+            const confirmCallback = () => {
+                orderLines.slice(1).forEach((line) => {
+                    this.trigger_up('field_changed', {
+                        dataPointID: this.renderer.state.id,
+                        changes: {order_line: {operation: "UPDATE", id: line.id, data: {[ev.data.fieldName]: ev.data.value}}},
+                    });
+                });
+            };
+            if (orderLines) {
+                Dialog.confirm(this, _t("Do you want to apply this value to all order lines?"), {
+                    buttons: [{
+                                text: _t('YES'),
+                                classes: 'btn-primary',
+                                close: true,
+                                click: () => confirmCallback(),
+                            }, {
+                                text: _t("NO"),
+                                close: true,
+                    }],
+                });
+            }
+        },
+
+        _isEqualValue (type, fieldName, orderLines) {
+            let isEqualValue;
+            let secondValue = orderLines[1].data[fieldName];
+            if (type === 'normal') {
+                if (secondValue instanceof moment) {
+                    isEqualValue = orderLines.slice(1).every(line => secondValue.isSame(line.data[fieldName]));
+                } else {
+                    isEqualValue = orderLines.slice(1).every(line => line.data[fieldName] === secondValue);
+                }
+            } else if (type === 'one2many') {
+                // only works for display_name because we want to be able to apply different id with similar properties
+                if (secondValue.data && secondValue.data.display_name) {
+                    secondValue = secondValue.data.display_name;
+                    isEqualValue = orderLines.slice(1).every(line => line.data[fieldName].data && line.data[fieldName].data.display_name === secondValue);
+                } else {
+                    isEqualValue = orderLines.slice(1).every(line => line.data[fieldName] === secondValue);
+                }
+            }
+            return isEqualValue;
+        },
+
+        _DialogReady (ev, type) {
+            const recordData = ev.target.recordData;
+            const fieldName = ev.data.fieldName;
+            const orderLines = this.renderer.state.data.order_line.data.filter(line => !line.data.display_type);
+            if (orderLines.length < 3) {
+                return false;
+            }
+            if (recordData.id === orderLines[0].data.id && this._isEqualValue(type, fieldName, orderLines)) {
+               return orderLines;
+            }
+            return false;
+        },
+
+    });
+
+    return SaleOrderFormController;
+
+});
diff --git a/addons/sale/static/src/js/sale_order_line_mixin.js b/addons/sale/static/src/js/sale_order_line_mixin.js
new file mode 100644
index 00000000000..ff5d7376cc2
--- /dev/null
+++ b/addons/sale/static/src/js/sale_order_line_mixin.js
@@ -0,0 +1,18 @@
+odoo.define('sale.UpdateAllLinesMixin', function (require) {
+    'use strict';
+
+    const UpdateAllLinesMixin = {
+        _onFieldChanged: function (ev) {
+            if (ev && ev.data.changes) {
+                const fieldName = Object.keys(ev.data.changes)[0];
+                const value = ev.data.changes[fieldName];
+                this.trigger_up(this._getUpdateAllLinesAction(), {fieldName: fieldName, value: value});
+            }
+            this._super.apply(this, arguments);
+        },
+        _getUpdateAllLinesAction: function () {
+            return '';
+        },
+    };
+    return UpdateAllLinesMixin;
+});
diff --git a/addons/sale/static/src/js/sale_order_view.js b/addons/sale/static/src/js/sale_order_view.js
index ef74cee9737..6583670769d 100644
--- a/addons/sale/static/src/js/sale_order_view.js
+++ b/addons/sale/static/src/js/sale_order_view.js
@@ -1,47 +1,9 @@
 odoo.define('sale.SaleOrderView', function (require) {
     "use strict";
 
-    const FormController = require('web.FormController');
+    const SaleOrderFormController = require('sale.SaleOrderFormController');
     const FormView = require('web.FormView');
     const viewRegistry = require('web.view_registry');
-    const Dialog = require('web.Dialog');
-    const core = require('web.core');
-    const _t = core._t;
-
-    const SaleOrderFormController = FormController.extend({
-        custom_events: _.extend({}, FormController.prototype.custom_events, {
-            open_discount_wizard: '_onOpenDiscountWizard',
-        }),
-
-        // -------------------------------------------------------------------------
-        // Handlers
-        // -------------------------------------------------------------------------
-
-        /**
-         * Handler called if user changes the discount field in the sale order line.
-         * The wizard will open only if
-         *  (1) Sale order line is 3 or more
-         *  (2) First sale order line is changed to discount
-         *  (3) Discount is the same in all sale order line
-         */
-        _onOpenDiscountWizard(ev) {
-            const orderLines = this.renderer.state.data.order_line.data.filter(line => !line.data.display_type);
-            const recordData = ev.target.recordData;
-            const isEqualDiscount = orderLines.slice(1).every(line => line.data.discount === recordData.discount);
-            if (orderLines.length >= 3 && recordData.sequence === orderLines[0].data.sequence && isEqualDiscount) {
-                Dialog.confirm(this, _t("Do you want to apply this discount to all order lines?"), {
-                    confirm_callback: () => {
-                        orderLines.slice(1).forEach((line) => {
-                            this.trigger_up('field_changed', {
-                                dataPointID: this.renderer.state.id,
-                                changes: {order_line: {operation: "UPDATE", id: line.id, data: {discount: orderLines[0].data.discount}}},
-                            });
-                        });
-                    },
-                });
-            }
-        },
-    });
 
     const SaleOrderView = FormView.extend({
         config: _.extend({}, FormView.prototype.config, {