From b1035c97c57f7eeab0348568bae07b9882945c34 Mon Sep 17 00:00:00 2001
From: Aaron Bohy <aab@odoo.com>
Date: Mon, 13 Feb 2023 11:56:36 +0000
Subject: [PATCH] [REF] project: remove unused "color_field" option

This option is only used by x2many fields (typically m2m_tags),
and has no effect on selection fields.

Part-of: odoo/odoo#112518
---
 .../static/tests/project_state_selection_tests.js      |  2 +-
 addons/project/views/project_update_views.xml          |  6 +++---
 addons/project/views/project_views.xml                 | 10 +++++-----
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/addons/project/static/tests/project_state_selection_tests.js b/addons/project/static/tests/project_state_selection_tests.js
index edfac0ee100..5bd4b6f8a88 100644
--- a/addons/project/static/tests/project_state_selection_tests.js
+++ b/addons/project/static/tests/project_state_selection_tests.js
@@ -44,7 +44,7 @@ QUnit.module("Project", (hooks) => {
                     <template>
                         <t t-name="kanban-box">
                             <div>
-                                <field name="last_update_status" widget="project_state_selection" options="{'color_field': 'last_update_color'}"/>
+                                <field name="last_update_status" widget="project_state_selection"/>
                             </div>
                         </t>
                     </template>
diff --git a/addons/project/views/project_update_views.xml b/addons/project/views/project_update_views.xml
index 1e5eff2ad84..df3907ea837 100644
--- a/addons/project/views/project_update_views.xml
+++ b/addons/project/views/project_update_views.xml
@@ -38,7 +38,7 @@
                         <group>
                             <field name="project_id" invisible="1"/>
                             <field name="color" invisible="1"/>
-                            <field name="status" widget="status_with_color" options="{'color_field': 'color'}"/>
+                            <field name="status" widget="status_with_color"/>
                             <field name="progress" widget="progressbar" options="{'editable': true}"/>
                         </group>
                         <group>
@@ -82,7 +82,7 @@
                                 </div>
                                 <div class="col-sm-2 text-sm-start col-6 align-end">
                                     <field name="color" invisible="1"/>
-                                    <b><field name="status" widget="status_with_color" options="{'color_field': 'color'}"/></b>
+                                    <b><field name="status" widget="status_with_color"/></b>
                                 </div>
                                 <div class="col-sm-2 col-6 pb-0">
                                     <b><field name="progress_percentage" widget="percentage"/></b>
@@ -110,7 +110,7 @@
                 <field name="date" optional="show"/>
                 <field name="progress_percentage" string="Progress" widget="percentage" optional="show"/>
                 <field name="color" invisible="1"/>
-                <field name="status" widget="status_with_color" options="{'color_field': 'color'}"/>
+                <field name="status" widget="status_with_color"/>
             </tree>
         </field>
     </record>
diff --git a/addons/project/views/project_views.xml b/addons/project/views/project_views.xml
index 28664242cee..5994c352452 100644
--- a/addons/project/views/project_views.xml
+++ b/addons/project/views/project_views.xml
@@ -478,13 +478,13 @@
                         <button class="oe_stat_button" name="project_update_all_action" type="object" groups="project.group_project_manager">
                             <div class="ps-4">
                                 <field name="last_update_color" invisible="1"/>
-                                <field name="last_update_status" readonly="1" widget="status_with_color" options="{'color_field': 'last_update_color'}"/>
+                                <field name="last_update_status" readonly="1" widget="status_with_color"/>
                             </div>
                         </button>
                         <button class="oe_stat_button o_project_not_clickable" disabled="disabled" groups="!project.group_project_manager">
                             <div class="ps-4">
                                 <field name="last_update_color" invisible="1"/>
-                                <field name="last_update_status" readonly="1" widget="status_with_color" options="{'color_field': 'last_update_color'}"/>
+                                <field name="last_update_status" readonly="1" widget="status_with_color"/>
                             </div>
                         </button>
                         <button class="oe_stat_button" name="%(project.project_collaborator_action)d" type="action" icon="fa-users" groups="project.group_project_manager" attrs="{'invisible':[('privacy_visibility', '!=', 'portal')]}">
@@ -666,7 +666,7 @@
                     <field name="user_id" optional="show" string="Project Manager" widget="many2one_avatar_user" options="{'no_open':True, 'no_create': True, 'no_create_edit': True}"/>
                     <field name="last_update_color" invisible="1"/>
                     <field name="tag_ids" widget="many2many_tags" options="{'color_field': 'color'}" optional="hide"/>
-                    <field name="last_update_status" string="Status" nolabel="1" optional="show" widget="status_with_color" options="{'color_field': 'last_update_color', 'hide_label': True}"/>
+                    <field name="last_update_status" string="Status" nolabel="1" optional="show" widget="status_with_color" options="{'hide_label': True}"/>
                     <field name="stage_id" options="{'no_open': True}" optional="show"/>
                     <button string="View Tasks" name="action_view_tasks" type="object"/>
                 </tree>
@@ -918,7 +918,7 @@
                                         <field name="activity_ids" widget="kanban_activity"/>
                                     </div>
                                     <div class="oe_kanban_bottom_right">
-                                        <field t-if="record.last_update_status.value &amp;&amp; widget.editable" name="last_update_status" widget="project_state_selection" options="{'color_field': 'last_update_color', 'hide_label': 1}"/>
+                                        <field t-if="record.last_update_status.value &amp;&amp; widget.editable" name="last_update_status" widget="project_state_selection" options="{'hide_label': 1}"/>
                                         <span t-if="record.last_update_status.value &amp;&amp; !widget.editable" t-att-class="'o_status_bubble mx-0 o_color_bubble_' + record.last_update_color.value" t-att-title="record.last_update_status.value"></span>
                                         <field name="user_id" widget="many2one_avatar_user" t-if="record.user_id.raw_value"/>
                                     </div>
@@ -961,7 +961,7 @@
                     <field name="is_favorite" widget="boolean_favorite" nolabel="1" string="Favorite"/>
                     <field name="stage_id" groups="project.group_project_stages"/>
                     <field name="last_update_color" invisible="1"/>
-                    <field name="last_update_status" string="Status" widget="status_with_color" options="{'color_field': 'last_update_color'}"/>
+                    <field name="last_update_status" string="Status" widget="status_with_color"/>
                     <field name="tag_ids" widget="many2many_tags" options="{'color_field': 'color'}" attrs="{'invisible': [('tag_ids', '=', [])]}"/>
                 </calendar>
             </field>