From afdecd5ab16711f9f9d83008097ceefbbf454f6c Mon Sep 17 00:00:00 2001 From: Kevin Baptiste Date: Tue, 20 Sep 2022 14:01:31 +0000 Subject: [PATCH] [FIX] hr_holidays: fix leave responsible cleanup Members of the `base_erp_manager` group are allowed to create new users but don't necessarily have access to `hr.employee` records, making the `read_group()` fail in those instances. Part-of: odoo/odoo#100775 --- addons/hr_holidays/models/res_users.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/hr_holidays/models/res_users.py b/addons/hr_holidays/models/res_users.py index d70a57c8cc5..a68c49e5c44 100644 --- a/addons/hr_holidays/models/res_users.py +++ b/addons/hr_holidays/models/res_users.py @@ -70,11 +70,11 @@ class User(models.Model): ['leave_manager_id'], ['leave_manager_id']) responsibles_to_remove_ids = set(self.ids) - {x['leave_manager_id'][0] for x in res} - approver_group.sudo().write({ + approver_group.write({ 'users': [(3, manager_id) for manager_id in responsibles_to_remove_ids]}) @api.model_create_multi def create(self, vals_list): users = super().create(vals_list) - users._clean_leave_responsible_users() + users.sudo()._clean_leave_responsible_users() return users