diff --git a/addons/event/data/event_data.xml b/addons/event/data/event_data.xml index 0c430e37799..d274d70e8df 100644 --- a/addons/event/data/event_data.xml +++ b/addons/event/data/event_data.xml @@ -17,7 +17,6 @@ Online - diff --git a/addons/event/models/event_event.py b/addons/event/models/event_event.py index a091da8ff6b..0a0dcbf63ab 100644 --- a/addons/event/models/event_event.py +++ b/addons/event/models/event_event.py @@ -44,8 +44,6 @@ class EventType(models.Model): help="Events and registrations will automatically be confirmed " "upon creation, easing the flow for simple events.") # location - is_online = fields.Boolean( - 'Online Event', help='Online events like webinars do not require a specific location and are hosted online.') use_timezone = fields.Boolean('Use Default Timezone') default_timezone = fields.Selection( _tz_get, string='Timezone', default=lambda self: self.env.user.tz or 'UTC') @@ -162,8 +160,9 @@ class EventEvent(models.Model): compute_sudo=True, readonly=True, compute='_compute_seats') # Registration fields auto_confirm = fields.Boolean( - string='Autoconfirm Registrations', - compute='_compute_from_event_type', copy=True, readonly=False, store=True) + string='Autoconfirmation', + compute='_compute_from_event_type', copy=True, readonly=False, store=True, + help = 'Autoconfirm Registrations. Registrations will automatically be confirmed upon creation.') registration_ids = fields.One2many('event.registration', 'event_id', string='Attendees') event_registrations_open = fields.Boolean('Registration open', compute='_compute_event_registrations_open') event_ticket_ids = fields.One2many( @@ -181,13 +180,9 @@ class EventEvent(models.Model): is_one_day = fields.Boolean(compute='_compute_field_is_one_day') start_sale_date = fields.Date('Start sale date', compute='_compute_start_sale_date') # Location and communication - is_online = fields.Boolean( - string='Online Event', compute='_compute_from_event_type', - copy=True, readonly=False, store=True) address_id = fields.Many2one( - 'res.partner', string='Venue', compute='_compute_address_id', - copy=True, readonly=False, store=True, tracking=True, - domain="['|', ('company_id', '=', False), ('company_id', '=', company_id)]") + 'res.partner', string='Venue', default=lambda self: self.env.company.partner_id.id, + tracking=True, domain="['|', ('company_id', '=', False), ('company_id', '=', company_id)]") country_id = fields.Many2one( 'res.country', 'Country', related='address_id.country_id', copy=True, readonly=False, store=True) @@ -302,14 +297,6 @@ class EventEvent(models.Model): start_dates = [ticket.start_sale_date for ticket in event.event_ticket_ids if ticket.start_sale_date] event.start_sale_date = min(start_dates) if start_dates else False - @api.depends('is_online') - def _compute_address_id(self): - for event in self: - if event.is_online: - event.address_id = False - elif not event.address_id: - event.address_id = self.env.company.partner_id.id - @api.depends('event_type_id') def _compute_date_tz(self): for event in self: diff --git a/addons/event/tests/common.py b/addons/event/tests/common.py index 62509636ed9..dab3e3339a1 100644 --- a/addons/event/tests/common.py +++ b/addons/event/tests/common.py @@ -51,7 +51,6 @@ class TestEventCommon(common.SavepointCase): cls.event_type_complex = cls.env['event.type'].create({ 'name': 'Update Type', 'auto_confirm': True, - 'is_online': False, 'has_seats_limitation': True, 'seats_max': 30, 'use_timezone': True, diff --git a/addons/event/tests/test_event_internals.py b/addons/event/tests/test_event_internals.py index 1a381f3f37b..4659149e1e1 100644 --- a/addons/event/tests/test_event_internals.py +++ b/addons/event/tests/test_event_internals.py @@ -59,7 +59,6 @@ class TestEventData(TestEventCommon): 'date_end': FieldsDatetime.to_string(datetime.today() + timedelta(days=15)), }) - self.assertFalse(event.is_online) self.assertEqual(event.address_id, self.env.user.company_id.partner_id) # seats: coming from event type configuration self.assertEqual(event.seats_availability, 'limited') @@ -69,11 +68,6 @@ class TestEventData(TestEventCommon): self.assertEqual(event.seats_used, 0) self.assertEqual(event.seats_expected, 0) - # set is_online: should reset the address_id field - event.update({'is_online': True}) - self.assertTrue(event.is_online) - self.assertFalse(event.address_id) - # create registration in order to check the seats computation self.assertTrue(event.auto_confirm) for x in range(5): @@ -117,12 +111,10 @@ class TestEventData(TestEventCommon): 'name': 'Event Update Type', 'date_begin': FieldsDatetime.to_string(datetime.today() + timedelta(days=1)), 'date_end': FieldsDatetime.to_string(datetime.today() + timedelta(days=15)), - 'is_online': True, }) self.assertEqual(event.date_tz, self.env.user.tz) self.assertEqual(event.seats_availability, 'unlimited') self.assertFalse(event.auto_confirm) - self.assertTrue(event.is_online) self.assertEqual(event.event_mail_ids, self.env['event.mail']) event_type.write({ @@ -136,7 +128,6 @@ class TestEventData(TestEventCommon): self.assertEqual(event.seats_availability, 'limited') self.assertEqual(event.seats_max, event_type.seats_max) self.assertTrue(event.auto_confirm) - self.assertFalse(event.is_online) self.assertEqual(event.event_mail_ids.interval_nbr, 1) self.assertEqual(event.event_mail_ids.interval_unit, 'days') self.assertEqual(event.event_mail_ids.interval_type, 'before_event') diff --git a/addons/event/views/event_views.xml b/addons/event/views/event_views.xml index bfb1815c8ff..a83cfe5dad5 100644 --- a/addons/event/views/event_views.xml +++ b/addons/event/views/event_views.xml @@ -15,20 +15,6 @@

Location

-
-
- -
-
-
-
@@ -148,7 +134,6 @@ - @@ -215,26 +200,10 @@
- - - - - - - - - - - + + +
- - - @@ -278,10 +255,8 @@ - - - - + + @@ -436,7 +411,6 @@ - diff --git a/addons/mass_mailing_event_track/views/event_views.xml b/addons/mass_mailing_event_track/views/event_views.xml index 231d9606920..2e18a8bbe0f 100644 --- a/addons/mass_mailing_event_track/views/event_views.xml +++ b/addons/mass_mailing_event_track/views/event_views.xml @@ -3,7 +3,7 @@ event.event.view.form.inherit.mass.mailing.track event.event - + diff --git a/addons/website_event/controllers/main.py b/addons/website_event/controllers/main.py index 5e6ffb16751..ffb2e8b26bc 100644 --- a/addons/website_event/controllers/main.py +++ b/addons/website_event/controllers/main.py @@ -100,11 +100,9 @@ class WebsiteEventController(http.Controller): current_type = EventType.browse(int(searches['type'])) domain_search["type"] = [("event_type_id", "=", int(searches["type"]))] - if searches["country"] != 'all' and searches["country"] != 'online': + if searches["country"] != 'all': current_country = request.env['res.country'].browse(int(searches['country'])) domain_search["country"] = ['|', ("country_id", "=", int(searches["country"])), ("country_id", "=", False)] - elif searches["country"] == 'online': - domain_search["country"] = [("country_id", "=", False)] def dom_without(without): domain = [] @@ -140,8 +138,6 @@ class WebsiteEventController(http.Controller): order = 'date_begin' if searches.get('date', 'all') == 'old': order = 'date_begin desc' - if searches["country"] != 'all': # if we are looking for a specific country - order = 'is_online, ' + order # show physical events first order = 'is_published desc, ' + order events = Event.search(dom_without("none"), limit=step, offset=pager['offset'], order=order) diff --git a/addons/website_event/views/event_templates.xml b/addons/website_event/views/event_templates.xml index 3671ec46010..f4c7f6c0a6a 100644 --- a/addons/website_event/views/event_templates.xml +++ b/addons/website_event/views/event_templates.xml @@ -213,7 +213,6 @@
-
Online
-
- +
@@ -466,31 +464,24 @@
- -
-
Location
-

-
- - - -
-
Online Event
-
-
+
+
Location
+

+
+
Organizer
diff --git a/addons/website_event/views/event_views.xml b/addons/website_event/views/event_views.xml index 28de6336ce3..a47a954627c 100644 --- a/addons/website_event/views/event_views.xml +++ b/addons/website_event/views/event_views.xml @@ -31,17 +31,13 @@ - +
-