diff --git a/addons/hr_expense/models/hr_expense.py b/addons/hr_expense/models/hr_expense.py index aeceae67cfd..6f767bb80bd 100644 --- a/addons/hr_expense/models/hr_expense.py +++ b/addons/hr_expense/models/hr_expense.py @@ -577,7 +577,6 @@ Or send your receipts at Team Approver Expense - ['|', '|', '|', + ['|', '|', '|', '|', ('employee_id.user_id', '=', user.id), ('employee_id.department_id.manager_id.user_id', '=', user.id), ('employee_id.parent_id.user_id', '=', user.id), - ('employee_id.expense_manager_id', '=', user.id)] + ('employee_id.expense_manager_id', '=', user.id), + ('sheet_id.user_id', '=', user.id)] @@ -37,19 +38,29 @@ Approver Expense Sheet - ['|', '|', '|', + ['|', '|', '|', '|', ('employee_id.user_id', '=', user.id), ('employee_id.department_id.manager_id.user_id', '=', user.id), ('employee_id.parent_id.user_id', '=', user.id), - ('employee_id.expense_manager_id', '=', user.id)] + ('employee_id.expense_manager_id', '=', user.id), + ('user_id', '=', user.id)] Employee Expense Sheet - [('employee_id.user_id', '=', user.id)] + [('employee_id.user_id', '=', user.id), ('state', '=', 'draft')] + + Employee can't modify expense sheet that is not in draft state + + [('employee_id.user_id', '=', user.id), ('state', '!=', 'draft')] + + + + + Expense multi company rule diff --git a/addons/hr_expense/views/hr_expense_views.xml b/addons/hr_expense/views/hr_expense_views.xml index 8ae129ed136..80261f79f9e 100644 --- a/addons/hr_expense/views/hr_expense_views.xml +++ b/addons/hr_expense/views/hr_expense_views.xml @@ -67,7 +67,7 @@ - + @@ -731,7 +731,7 @@
@@ -745,17 +745,18 @@ - + - + + - - - + + + @@ -768,9 +769,9 @@ - + - +