From ae412254f3a106e7d20341f2d6f0e6b1aff2dfb0 Mon Sep 17 00:00:00 2001
From: "Maruan Aguerdouh (magm)" <magm@odoo.com>
Date: Tue, 21 Mar 2023 12:35:45 +0000
Subject: [PATCH] [FIX] *: fix kanban_view_ref to work in newer versions

Steps to reproduce:

- Install Sales.
- Go to any quotation and toggle mobile device mode in the browser.
- Go to Other Info > click in Sales Team field.

Issue:

We stop supporting the 'kanban_view_ref' in newer versions of odoo. So
we won't be able to get proper view.

Solution:

Changed the way we ref the kanban view to use context to get the
referenced kanban view.

Related to #39499

opw-3152174

closes odoo/odoo#116031

Related: odoo/enterprise#39499
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
---
 addons/crm/views/crm_lead_views.xml                           | 2 +-
 addons/crm/views/crm_stage_views.xml                          | 2 +-
 addons/crm/wizard/crm_lead_to_opportunity_mass_views.xml      | 2 +-
 addons/crm/wizard/crm_lead_to_opportunity_views.xml           | 2 +-
 addons/crm/wizard/crm_merge_opportunities_views.xml           | 2 +-
 .../crm_iap_mine/views/crm_iap_lead_mining_request_views.xml  | 2 +-
 addons/pos_sale/views/res_config_settings_views.xml           | 2 +-
 addons/pos_sale/views/sales_team_views.xml                    | 4 ++--
 addons/sale/views/account_views.xml                           | 2 +-
 addons/sale/views/sale_order_views.xml                        | 2 +-
 addons/sales_team/views/crm_team_member_views.xml             | 2 +-
 addons/website_crm_iap_reveal/views/crm_reveal_views.xml      | 2 +-
 addons/website_sale/views/res_config_settings_views.xml       | 2 +-
 13 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/addons/crm/views/crm_lead_views.xml b/addons/crm/views/crm_lead_views.xml
index d46c51840b4..5fc4ed48247 100644
--- a/addons/crm/views/crm_lead_views.xml
+++ b/addons/crm/views/crm_lead_views.xml
@@ -328,7 +328,7 @@
                                         <field name="company_id"
                                             groups="base.group_multi_company"
                                             options="{'no_create': True}"/>
-                                        <field name="team_id" options="{'no_open': True, 'no_create': True}"/>
+                                        <field name="team_id" options="{'no_open': True, 'no_create': True}" context="{'kanban_view_ref': 'sales_team.crm_team_view_kanban'}"/>
                                         <field name="day_open" />
                                         <field name="day_close"/>
                                         <field name="type" invisible="1"/>
diff --git a/addons/crm/views/crm_stage_views.xml b/addons/crm/views/crm_stage_views.xml
index 73f66907d02..8c489ecec50 100644
--- a/addons/crm/views/crm_stage_views.xml
+++ b/addons/crm/views/crm_stage_views.xml
@@ -45,7 +45,7 @@
                         <group>
                             <field name="is_won"/>
                             <field name="fold"/>
-                            <field name="team_id" options='{"no_open": True, "no_create": True}' attrs="{'invisible': [('team_count', '&lt;=', 1)]}" kanban_view_ref="%(sales_team.crm_team_view_kanban)s"/>
+                            <field name="team_id" options='{"no_open": True, "no_create": True}' attrs="{'invisible': [('team_count', '&lt;=', 1)]}" context="{'kanban_view_ref': 'sales_team.crm_team_view_kanban'}"/>
                         </group>
                         <field name="team_count" invisible="1"/>
                     </group>
diff --git a/addons/crm/wizard/crm_lead_to_opportunity_mass_views.xml b/addons/crm/wizard/crm_lead_to_opportunity_mass_views.xml
index 1accb94c4ca..922b2ebc400 100644
--- a/addons/crm/wizard/crm_lead_to_opportunity_mass_views.xml
+++ b/addons/crm/wizard/crm_lead_to_opportunity_mass_views.xml
@@ -12,7 +12,7 @@
                     <field name="deduplicate" class="oe_inline"/>
                 </group>
                 <group string="Assign these opportunities to">
-                    <field name="team_id" kanban_view_ref="%(sales_team.crm_team_view_kanban)s"/>
+                    <field name="team_id" context="{'kanban_view_ref': 'sales_team.crm_team_view_kanban'}"/>
                     <field name="user_ids" widget="many2many_tags" domain="[('share', '=', False)]"/>
                     <field name="force_assignment"/>
                 </group>
diff --git a/addons/crm/wizard/crm_lead_to_opportunity_views.xml b/addons/crm/wizard/crm_lead_to_opportunity_views.xml
index b438e4eb2a1..4d66ffaa98e 100644
--- a/addons/crm/wizard/crm_lead_to_opportunity_views.xml
+++ b/addons/crm/wizard/crm_lead_to_opportunity_views.xml
@@ -24,7 +24,7 @@
                             <field name="email_from"/>
                             <field name="stage_id"/>
                             <field name="user_id"/>
-                            <field name="team_id" kanban_view_ref="%(sales_team.crm_team_view_kanban)s"/>
+                            <field name="team_id" context="{'kanban_view_ref': 'sales_team.crm_team_view_kanban'}"/>
                         </tree>
                     </field>
                 </group>
diff --git a/addons/crm/wizard/crm_merge_opportunities_views.xml b/addons/crm/wizard/crm_merge_opportunities_views.xml
index a3d8fe6f6a7..5e37320ce63 100644
--- a/addons/crm/wizard/crm_merge_opportunities_views.xml
+++ b/addons/crm/wizard/crm_merge_opportunities_views.xml
@@ -8,7 +8,7 @@
                 <form string="Merge Leads/Opportunities">
                     <group string="Assign opportunities to">
                         <field name="user_id" class="oe_inline"/>
-                        <field name="team_id" class="oe_inline" kanban_view_ref="%(sales_team.crm_team_view_kanban)s"/>
+                        <field name="team_id" class="oe_inline" context="{'kanban_view_ref': 'sales_team.crm_team_view_kanban'}"/>
                     </group>
                     <group string="Select Leads/Opportunities">
                         <field name="opportunity_ids" nolabel="1">
diff --git a/addons/crm_iap_mine/views/crm_iap_lead_mining_request_views.xml b/addons/crm_iap_mine/views/crm_iap_lead_mining_request_views.xml
index 20abe101175..591b32b6b9c 100644
--- a/addons/crm_iap_mine/views/crm_iap_lead_mining_request_views.xml
+++ b/addons/crm_iap_mine/views/crm_iap_lead_mining_request_views.xml
@@ -79,7 +79,7 @@
                         </group>
                         <group name="lead_info">
                             <field name="lead_type" groups="crm.group_use_lead" invisible="context.get('is_modal')" attrs="{'readonly': [('state', '=', 'done')]}"/>
-                            <field name="team_id" no_create="1" no_open="1" attrs="{'readonly': [('state', '=', 'done')]}" kanban_view_ref="%(sales_team.crm_team_view_kanban)s"/>
+                            <field name="team_id" no_create="1" no_open="1" attrs="{'readonly': [('state', '=', 'done')]}" context="{'kanban_view_ref': 'sales_team.crm_team_view_kanban'}"/>
                             <field name="user_id" no_create="1" no_open="1" attrs="{'readonly': [('state', '=', 'done')]}"/>
                             <field name="tag_ids" string="Default Tags" widget="many2many_tags" attrs="{'readonly': [('state', '=', 'done')]}"/>
                         </group>
diff --git a/addons/pos_sale/views/res_config_settings_views.xml b/addons/pos_sale/views/res_config_settings_views.xml
index fcc8e301f2c..5bb0915bf6d 100644
--- a/addons/pos_sale/views/res_config_settings_views.xml
+++ b/addons/pos_sale/views/res_config_settings_views.xml
@@ -9,7 +9,7 @@
             <block id="pos_accounting_section" position="after">
                 <block title="Sales">
                     <setting string="Sales Team" help="Sales are reported to the following sales team">
-                        <field name="pos_crm_team_id" kanban_view_ref="%(sales_team.crm_team_view_kanban)s" domain="['|', ('company_id', '=', company_id), ('company_id', '=', False)]"/>
+                        <field name="pos_crm_team_id" context="{'kanban_view_ref': 'sales_team.crm_team_view_kanban'}" domain="['|', ('company_id', '=', company_id), ('company_id', '=', False)]"/>
                     </setting>
                     <setting string="Down Payment Product" help="This product will be applied when down payment is made">
                         <field
diff --git a/addons/pos_sale/views/sales_team_views.xml b/addons/pos_sale/views/sales_team_views.xml
index 1adf3490e0c..b506f99423c 100644
--- a/addons/pos_sale/views/sales_team_views.xml
+++ b/addons/pos_sale/views/sales_team_views.xml
@@ -6,7 +6,7 @@
         <field name="inherit_id" ref="point_of_sale.view_pos_session_search"/>
         <field name="arch" type="xml">
             <xpath expr="//field[@name='config_id']" position="after">
-                <field name="crm_team_id" kanban_view_ref="%(sales_team.crm_team_view_kanban)s"/>
+                <field name="crm_team_id" context="{'kanban_view_ref': 'sales_team.crm_team_view_kanban'}"/>
             </xpath>
         </field>
     </record>
@@ -25,7 +25,7 @@
         <field name="inherit_id" ref="point_of_sale.view_pos_config_search"/>
         <field name="arch" type="xml">
             <xpath expr="//field[@name='name']" position="after">
-                <field name="crm_team_id" kanban_view_ref="%(sales_team.crm_team_view_kanban)s"/>
+                <field name="crm_team_id" context="{'kanban_view_ref': 'sales_team.crm_team_view_kanban'}"/>
             </xpath>
         </field>
     </record>
diff --git a/addons/sale/views/account_views.xml b/addons/sale/views/account_views.xml
index cf3d2fca408..ac8150cc3df 100644
--- a/addons/sale/views/account_views.xml
+++ b/addons/sale/views/account_views.xml
@@ -32,7 +32,7 @@
         <field name="inherit_id" ref="account.view_move_form"/>
         <field name="arch" type="xml">
             <xpath expr="//group[@name='sale_info_group']/field[@name='invoice_user_id']" position="after">
-                <field name="team_id" kanban_view_ref="%(sales_team.crm_team_view_kanban)s"/>
+                <field name="team_id" context="{'kanban_view_ref': 'sales_team.crm_team_view_kanban'}"/>
             </xpath>
             <xpath expr="//group[@id='other_tab_group']" position="inside">
                 <group string="Marketing"
diff --git a/addons/sale/views/sale_order_views.xml b/addons/sale/views/sale_order_views.xml
index 66c27b11bcc..4a6b7176732 100644
--- a/addons/sale/views/sale_order_views.xml
+++ b/addons/sale/views/sale_order_views.xml
@@ -649,7 +649,7 @@
                         <group>
                             <group name="sales_person" string="Sales">
                                 <field name="user_id" widget="many2one_avatar_user"/>
-                                <field name="team_id" kanban_view_ref="%(sales_team.crm_team_view_kanban)s" options="{'no_create': True}"/>
+                                <field name="team_id" context="{'kanban_view_ref': 'sales_team.crm_team_view_kanban'}" options="{'no_create': True}"/>
                                 <field name="company_id" options="{'no_create': True}" groups="base.group_multi_company"/>
                                 <label for="require_signature" string="Online confirmation"/>
                                 <div>
diff --git a/addons/sales_team/views/crm_team_member_views.xml b/addons/sales_team/views/crm_team_member_views.xml
index 0824451684e..2aeed4a5165 100644
--- a/addons/sales_team/views/crm_team_member_views.xml
+++ b/addons/sales_team/views/crm_team_member_views.xml
@@ -118,7 +118,7 @@
                     </div>
                     <group name="member_partner_info">
                         <group name="group_owner">
-                            <field name="crm_team_id" kanban_view_ref="%(sales_team.crm_team_view_kanban)s"/>
+                            <field name="crm_team_id" context="{'kanban_view_ref': 'sales_team.crm_team_view_kanban'}"/>
                         </group>
                         <group name="group_user">
                             <field name="company_id" attrs="{'invisible': [('user_id', '=', False)]}"
diff --git a/addons/website_crm_iap_reveal/views/crm_reveal_views.xml b/addons/website_crm_iap_reveal/views/crm_reveal_views.xml
index bc4f506c443..3efa7caaf3f 100644
--- a/addons/website_crm_iap_reveal/views/crm_reveal_views.xml
+++ b/addons/website_crm_iap_reveal/views/crm_reveal_views.xml
@@ -76,7 +76,7 @@
                         <group>
                             <field name="lead_type" groups="crm.group_use_lead"/>
                             <field name="suffix"/>
-                            <field name="team_id" kanban_view_ref="%(sales_team.crm_team_view_kanban)s"/>
+                            <field name="team_id" context="{'kanban_view_ref': 'sales_team.crm_team_view_kanban'}"/>
                             <field name="user_id" domain="[('share', '=', False)]"/>
                         </group>
                         <group>
diff --git a/addons/website_sale/views/res_config_settings_views.xml b/addons/website_sale/views/res_config_settings_views.xml
index c56216ee486..81c9a32bce2 100644
--- a/addons/website_sale/views/res_config_settings_views.xml
+++ b/addons/website_sale/views/res_config_settings_views.xml
@@ -59,7 +59,7 @@
                         <div class="content-group">
                             <div class="row mt16">
                                 <label class="o_light_label col-lg-3" string="Sales Team" for="salesteam_id"/>
-                                <field name="salesteam_id" kanban_view_ref="%(sales_team.crm_team_view_kanban)s" />
+                                <field name="salesteam_id" context="{'kanban_view_ref': 'sales_team.crm_team_view_kanban'}"/>
                             </div>
                             <div class="row">
                                 <label class="o_light_label col-lg-3" for="salesperson_id"/>