From adc04e2bb2e518dbcf85c77bed2db233a01b5ba8 Mon Sep 17 00:00:00 2001
From: "Pedram (pebr)" <pebr@odoo.com>
Date: Tue, 12 Mar 2024 16:09:39 +0000
Subject: [PATCH] [FIX] point_of_sale: prevent rounding modification with an
 open session

Prior to this commit, the rounding setting could be modified while
a session was open. This could potentially cause accounting
discrepancies and lead to unbalanced account moves.

opw-3677480

closes odoo/odoo#158625

X-original-commit: 021302a270028373ab519ea1d5409ffb73ee8424
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Pedram Bi Ria (pebr) <pebr@odoo.com>
---
 addons/point_of_sale/views/res_config_settings_views.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/addons/point_of_sale/views/res_config_settings_views.xml b/addons/point_of_sale/views/res_config_settings_views.xml
index c0d71b21559..dfe634abd51 100644
--- a/addons/point_of_sale/views/res_config_settings_views.xml
+++ b/addons/point_of_sale/views/res_config_settings_views.xml
@@ -60,15 +60,15 @@
                                 <field name="pos_auto_validate_terminal_payment"/>
                             </setting>
                             <setting string="Cash Rounding" invisible="is_kiosk_mode" documentation="/applications/sales/point_of_sale/pricing/cash_rounding.html" help="Define the smallest coinage of the currency used to pay by cash">
-                                <field name="pos_cash_rounding"/>
+                                <field name="pos_cash_rounding" readonly="pos_has_active_session"/>
                                 <div class="content-group mt16" invisible="not pos_cash_rounding">
                                     <div class="row mt16">
                                         <label string="Rounding Method" for="pos_rounding_method" class="col-lg-3 o_light_label" />
-                                        <field name="pos_rounding_method" required="pos_cash_rounding" domain="[('company_id', '=', company_id)]"/>
+                                        <field name="pos_rounding_method" required="pos_cash_rounding" domain="[('company_id', '=', company_id)]" readonly="pos_has_active_session"/>
                                     </div>
                                     <div class="row mt16">
                                         <div class="col">
-                                            <field name="pos_only_round_cash_method"/>
+                                            <field name="pos_only_round_cash_method" readonly="pos_has_active_session"/>
                                             <label string="Only on cash methods" for="pos_only_round_cash_method" class="o_light_label" />
                                         </div>
                                     </div>