From adb908fb32bda137a6b2e8b734cdfe0d5f3a4262 Mon Sep 17 00:00:00 2001
From: Jeremy Kersten <jke@odoo.com>
Date: Fri, 12 Jun 2020 09:02:23 +0000
Subject: [PATCH] [FIX] base: arch should be required

The attribute has been lost during a previous commit e6695c72d8.

This commit avoid that you can create an ir.ui.view without arch.

Before this commit, if you try to create an ir.ui.view with type but no
arch, the code will raise an exception in _check_xml:
    /odoo/addons/base/models/ir_ui_view.py, line 377, in _check_xml
        view_arch = etree.fromstring(view.arch.encode('utf-8'))
    AttributeError: 'bool' object has no attribute 'encode'

Now, the user will have a warning on create, to say that View Arch field is required.

Could be backported if reported

X-original-commit: 4877bb4b650f5d1c52fefb06dec2fa568afcb121
---
 odoo/addons/base/views/ir_ui_view_views.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/odoo/addons/base/views/ir_ui_view_views.xml b/odoo/addons/base/views/ir_ui_view_views.xml
index d100abf3584..57272c67db2 100644
--- a/odoo/addons/base/views/ir_ui_view_views.xml
+++ b/odoo/addons/base/views/ir_ui_view_views.xml
@@ -30,7 +30,7 @@
                         <page string="Architecture" name="architecture">
                             <button type="object" name="open_translations"
                                 string="Edit Translations" class="oe_link oe_right"/>
-                            <field name="arch_base" string="View Architecture" widget="ace" options="{'mode': 'xml'}"/>
+                            <field name="arch_base" string="View Architecture" widget="ace" options="{'mode': 'xml'}" required="1"/>
                         </page>
                         <page string="Access Rights" name="access_rights">
                             <field name="groups_id"/>