From ad1c11b196e48f68216aa7cb178ef9beeec3589f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nshimiyimana=20S=C3=A9na?= Date: Wed, 30 Nov 2022 07:38:13 +0000 Subject: [PATCH] [FIX] crm_iap_enrich: correctly save 'Enrich lead automatically' setting MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Steps to reproduce 1. navigate to Settings -> CRM -> Lead Enrichment section 2. change the Lead Enrichment option to "Enrich leads on demand only" 3. click Save button 4. wait for system to save and refresh. You should see that the change you made was not saved. opw-3063639 closes odoo/odoo#106891 X-original-commit: 0803775e4a156aa6988453edbbaf799730c996b2 Signed-off-by: Warnon Aurélien (awa) --- addons/crm_iap_enrich/models/res_config_settings.py | 2 +- addons/crm_iap_enrich/tests/test_lead_enrich.py | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/addons/crm_iap_enrich/models/res_config_settings.py b/addons/crm_iap_enrich/models/res_config_settings.py index 67c46009796..658fc7fd207 100644 --- a/addons/crm_iap_enrich/models/res_config_settings.py +++ b/addons/crm_iap_enrich/models/res_config_settings.py @@ -17,5 +17,5 @@ class ResConfigSettings(models.TransientModel): def set_values(self): super().set_values() cron = self.sudo().with_context(active_test=False).env.ref('crm_iap_enrich.ir_cron_lead_enrichment', raise_if_not_found=False) - if cron and cron.active != self.lead_enrich_auto == 'auto': + if cron and cron.active != (self.lead_enrich_auto == 'auto'): cron.active = self.lead_enrich_auto == 'auto' diff --git a/addons/crm_iap_enrich/tests/test_lead_enrich.py b/addons/crm_iap_enrich/tests/test_lead_enrich.py index dd18c3cce18..468863507b2 100644 --- a/addons/crm_iap_enrich/tests/test_lead_enrich.py +++ b/addons/crm_iap_enrich/tests/test_lead_enrich.py @@ -56,3 +56,16 @@ class TestLeadEnrich(TestCrmCommon, MockIAPEnrich): for lead in leads: self.assertEqual(lead.street, False) + + def test_lead_enrich_auto_setting(self): + cron = self.env.ref('crm_iap_enrich.ir_cron_lead_enrichment') + + config = self.env['res.config.settings'].create({ + 'lead_enrich_auto': 'manual', + }) + config.execute() + self.assertFalse(cron.active) + + config.write({'lead_enrich_auto': 'auto'}) + config.execute() + self.assertTrue(cron.active)