From 5b85b245b505cc6e25595983735a29fd78727e79 Mon Sep 17 00:00:00 2001
From: "Sunil Sharma (OpenERP Trainee)" <sunilsharma.sharma07@gmail.com>
Date: Tue, 27 Aug 2013 14:04:59 +0530
Subject: [PATCH 01/12] [IMP]:Stock:Form view and Stock Help

bzr revid: sunilsharma.sharma07@gmail.com-20130827083459-lv6ic79k88h843eu
---
 addons/stock/stock.py       | 17 +++++++++--------
 addons/stock/stock_view.xml | 11 ++++++-----
 2 files changed, 15 insertions(+), 13 deletions(-)

diff --git a/addons/stock/stock.py b/addons/stock/stock.py
index 54f473f75c1..4752376a085 100644
--- a/addons/stock/stock.py
+++ b/addons/stock/stock.py
@@ -1662,18 +1662,18 @@ class stock_inventory(osv.osv):
         return res
 
     _columns = {
-        'name': fields.char('Inventory Reference', size=64, required=True, readonly=True, states={'draft': [('readonly', False)]}),
-        'date': fields.datetime('Creation Date', required=True, readonly=True, states={'draft': [('readonly', False)]}),
-        'date_done': fields.datetime('Date done'),
+        'name': fields.char('Inventory Reference', size=64, required=True, readonly=True, states={'draft': [('readonly', False)]}, help="Inventory Name."),
+        'date': fields.datetime('Creation Date', required=True, readonly=True, states={'draft': [('readonly', False)]}, help="Inventory Create Date."),
+        'date_done': fields.datetime('Date done', help="Inventory Date time."),
         'line_ids': fields.one2many('stock.inventory.line', 'inventory_id', 'Inventories', readonly=False, states={'done': [('readonly', True)]}),
         'move_ids': fields.one2many('stock.move', 'inventory_id', 'Created Moves'),
-        'state': fields.selection([('draft', 'Draft'), ('cancel', 'Cancelled'), ('confirm', 'Confirmed'), ('done', 'Done')], 'Status', readonly=True, select=True),
-        'company_id': fields.many2one('res.company', 'Company', required=True, select=True, readonly=True, states={'draft': [('readonly', False)]}),
-        'location_id': fields.many2one('stock.location', 'Location', required=True),
-        'product_id': fields.many2one('product.product', 'Product'),
+        'state': fields.selection([('draft', 'Draft'), ('cancel', 'Cancelled'), ('confirm', 'In Progress'), ('done', 'Validated')], 'Status', readonly=True, select=True),
+        'company_id': fields.many2one('res.company', 'Company', required=True, select=True, readonly=True, states={'draft': [('readonly', False)]}, help="Your Company Name."),
+        'location_id': fields.many2one('stock.location', 'Location', required=True, help="Physical location stock name."),
+        'product_id': fields.many2one('product.product', 'Product', help="Product Name"),
         'package_id': fields.many2one('stock.quant.package', 'Pack'),
         'partner_id': fields.many2one('res.partner', 'Owner'),
-        'lot_id': fields.many2one('stock.production.lot', 'Lot/Serial Number'),
+        'lot_id': fields.many2one('stock.production.lot', 'Lot/Serial Number', help="Forces to specify a Serial Number for all moves containing this product and generated by a Manufacturing Order"),
         'move_ids_exist': fields.function(_get_move_ids_exist, type='boolean', string=' Stock Move Exists?', help='technical field for attrs in view'),
     }
 
@@ -1837,6 +1837,7 @@ class stock_inventory_line(osv.osv):
         'company_id': fields.related('inventory_id', 'company_id', type='many2one', relation='res.company', string='Company', store=True, select=True, readonly=True),
         'prod_lot_id': fields.many2one('stock.production.lot', 'Serial Number', domain="[('product_id','=',product_id)]"),
         'state': fields.related('inventory_id', 'state', type='char', string='Status', readonly=True),
+        'real_qty':fields.related('product_id','qty_available', type='float',string='Real Quantity',store=True),
     }
 
     def _resolve_inventory_line(self, cr, uid, inventory_line, theorical_lines, context=None):
diff --git a/addons/stock/stock_view.xml b/addons/stock/stock_view.xml
index af3fa1153f4..8a0ed746544 100644
--- a/addons/stock/stock_view.xml
+++ b/addons/stock/stock_view.xml
@@ -101,11 +101,11 @@
             <field name="arch" type="xml">
                 <form string="Physical Inventory" version="7.0">
                 <header>
-                    <button name="%(action_view_stock_fill_inventory)d" states="draft" string="Fill Inventory" type="action" class="oe_highlight" groups="stock.group_stock_user"/>
+                    <button name="%(action_view_stock_fill_inventory)d" states="draft" string="Start Inventory" type="action" class="oe_highlight" groups="stock.group_stock_user"/>
                     <button name="action_done" states="confirm" string="Validate Inventory" type="object" class="oe_highlight" groups="stock.group_stock_manager"/>
                     <button name="action_cancel_draft" states="cancel" string="Set to Draft" type="object"/>
                     <button name="action_cancel_inventory" states="draft,confirm,done" string="Cancel Inventory" type="object"/>
-                    <field name="state" widget="statusbar" statusbar_visible="draft,confirm"/>
+                    <field name="state" widget="statusbar" statusbar_visible="draft,confirm,done"/>
                 </header>
                 <sheet>
                     <div class="oe_right oe_button_box">
@@ -130,11 +130,12 @@
                     </group>
                     <field name="move_ids_exist" invisible="1"/>
                     <notebook>
-                    <page string="Inventory Details">
+                    <page string="Inventory Details" attrs="{'invisible':[('state','=','draft')]}">
                     <field name="line_ids" string="Inventory Details">
                         <tree string="Inventory Details" editable="bottom">
                             <field context="{'location':location_id, 'uom':product_uom_id, 'to_date':parent.date}" name="product_id" on_change="on_change_product_id(location_id,product_id,product_uom_id,parent.date)"  domain="[('type','=','product')]"/>
-                            <field name="product_qty"/>
+                            <field name="real_qty" readonly="1"/>
+                            <field name="product_qty" string="Checked Quantity"/>
                             <field name="product_uom_id" groups="product.group_uom"/>
                             <field name="prod_lot_id"/>
                             <field name="package_id" readonly="1"/>
@@ -143,7 +144,7 @@
                         </tree>
                     </field>
                     </page>
-                    <page string="Inventory Adjustments" attrs="{'invisible': [('move_ids_exist', '=', False)]}">
+                   <page string="Inventory Adjustments" attrs="{'invisible': [('move_ids_exist', '=', False)],'invisible': [('state','=','draft')] }">
                         <field name="move_ids" context="{'inventory_id':active_id}" readonly="1">
                            <tree string="Inventory Adjustments">
                                <field name="product_id"/>

From 14dac5ce8c35be6a0d2acf22fce251c22ec79364 Mon Sep 17 00:00:00 2001
From: "Turkesh Patel (Open ERP)" <tpa@tinyerp.com>
Date: Tue, 27 Aug 2013 15:19:00 +0530
Subject: [PATCH 02/12] [IMP] apply color in inventory line and improved help

bzr revid: tpa@tinyerp.com-20130827094900-xq7eful67vimd2xk
---
 addons/stock/stock.py       | 14 +++++++-------
 addons/stock/stock_view.xml |  2 +-
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/addons/stock/stock.py b/addons/stock/stock.py
index 4752376a085..50f568a5110 100644
--- a/addons/stock/stock.py
+++ b/addons/stock/stock.py
@@ -1664,16 +1664,16 @@ class stock_inventory(osv.osv):
     _columns = {
         'name': fields.char('Inventory Reference', size=64, required=True, readonly=True, states={'draft': [('readonly', False)]}, help="Inventory Name."),
         'date': fields.datetime('Creation Date', required=True, readonly=True, states={'draft': [('readonly', False)]}, help="Inventory Create Date."),
-        'date_done': fields.datetime('Date done', help="Inventory Date time."),
-        'line_ids': fields.one2many('stock.inventory.line', 'inventory_id', 'Inventories', readonly=False, states={'done': [('readonly', True)]}),
-        'move_ids': fields.one2many('stock.move', 'inventory_id', 'Created Moves'),
+        'date_done': fields.datetime('Date done', help="Inventory Validation Date."),
+        'line_ids': fields.one2many('stock.inventory.line', 'inventory_id', 'Inventories', readonly=False, states={'done': [('readonly', True)]}, help="Inventory Lines."),
+        'move_ids': fields.one2many('stock.move', 'inventory_id', 'Created Moves', help="Inventory Moves."),
         'state': fields.selection([('draft', 'Draft'), ('cancel', 'Cancelled'), ('confirm', 'In Progress'), ('done', 'Validated')], 'Status', readonly=True, select=True),
-        'company_id': fields.many2one('res.company', 'Company', required=True, select=True, readonly=True, states={'draft': [('readonly', False)]}, help="Your Company Name."),
-        'location_id': fields.many2one('stock.location', 'Location', required=True, help="Physical location stock name."),
+        'company_id': fields.many2one('res.company', 'Company', required=True, select=True, readonly=True, states={'draft': [('readonly', False)]}),
+        'location_id': fields.many2one('stock.location', 'Location', required=True),
         'product_id': fields.many2one('product.product', 'Product', help="Product Name"),
         'package_id': fields.many2one('stock.quant.package', 'Pack'),
         'partner_id': fields.many2one('res.partner', 'Owner'),
-        'lot_id': fields.many2one('stock.production.lot', 'Lot/Serial Number', help="Forces to specify a Serial Number for all moves containing this product and generated by a Manufacturing Order"),
+        'lot_id': fields.many2one('stock.production.lot', 'Lot/Serial Number', help="Forces to specify a Serial Number for all moves generated by Inventoty"),
         'move_ids_exist': fields.function(_get_move_ids_exist, type='boolean', string=' Stock Move Exists?', help='technical field for attrs in view'),
     }
 
@@ -1837,7 +1837,7 @@ class stock_inventory_line(osv.osv):
         'company_id': fields.related('inventory_id', 'company_id', type='many2one', relation='res.company', string='Company', store=True, select=True, readonly=True),
         'prod_lot_id': fields.many2one('stock.production.lot', 'Serial Number', domain="[('product_id','=',product_id)]"),
         'state': fields.related('inventory_id', 'state', type='char', string='Status', readonly=True),
-        'real_qty':fields.related('product_id','qty_available', type='float',string='Real Quantity',store=True),
+        'real_qty':fields.related('product_id','qty_available', type='float', string='Real Quantity', store=True),
     }
 
     def _resolve_inventory_line(self, cr, uid, inventory_line, theorical_lines, context=None):
diff --git a/addons/stock/stock_view.xml b/addons/stock/stock_view.xml
index 8a0ed746544..00ac2e22289 100644
--- a/addons/stock/stock_view.xml
+++ b/addons/stock/stock_view.xml
@@ -132,7 +132,7 @@
                     <notebook>
                     <page string="Inventory Details" attrs="{'invisible':[('state','=','draft')]}">
                     <field name="line_ids" string="Inventory Details">
-                        <tree string="Inventory Details" editable="bottom">
+                        <tree string="Inventory Details" editable="bottom" colors="blue: product_qty != real_qty">
                             <field context="{'location':location_id, 'uom':product_uom_id, 'to_date':parent.date}" name="product_id" on_change="on_change_product_id(location_id,product_id,product_uom_id,parent.date)"  domain="[('type','=','product')]"/>
                             <field name="real_qty" readonly="1"/>
                             <field name="product_qty" string="Checked Quantity"/>

From bfb37ae966c3c17dac72999888c0663628b81db6 Mon Sep 17 00:00:00 2001
From: "Sunil Sharma (OpenERP Trainee)" <sunilsharma.sharma07@gmail.com>
Date: Tue, 27 Aug 2013 15:36:38 +0530
Subject: [PATCH 03/12] [IMP]:Stock:Set Button Check Qty

bzr revid: sunilsharma.sharma07@gmail.com-20130827100638-kh8qmle7fab9nkff
---
 addons/stock/stock.py       | 6 ++++++
 addons/stock/stock_view.xml | 1 +
 2 files changed, 7 insertions(+)

diff --git a/addons/stock/stock.py b/addons/stock/stock.py
index 4752376a085..8b7adf57eaa 100644
--- a/addons/stock/stock.py
+++ b/addons/stock/stock.py
@@ -1691,6 +1691,12 @@ class stock_inventory(osv.osv):
         'location_id': _default_stock_location,
     }
 
+    def set_checked_qty(self , cr ,uid ,ids ,context=None):
+        inventory = self.browse(cr, uid, ids[0], context=context)
+        line_ids = [line.id for line in inventory.line_ids]
+        self.pool.get('stock.inventory.line').write(cr, uid, line_ids, {'product_qty': 0})
+        return True
+
     def copy(self, cr, uid, id, default=None, context=None):
         if default is None:
             default = {}
diff --git a/addons/stock/stock_view.xml b/addons/stock/stock_view.xml
index 8a0ed746544..76b4cdbd739 100644
--- a/addons/stock/stock_view.xml
+++ b/addons/stock/stock_view.xml
@@ -131,6 +131,7 @@
                     <field name="move_ids_exist" invisible="1"/>
                     <notebook>
                     <page string="Inventory Details" attrs="{'invisible':[('state','=','draft')]}">
+                    <button name="set_checked_qty" states="confirm" string="==> Set Checked Quantity to 0" type="object" class="oe_link oe_right" groups="stock.group_stock_user"/>
                     <field name="line_ids" string="Inventory Details">
                         <tree string="Inventory Details" editable="bottom">
                             <field context="{'location':location_id, 'uom':product_uom_id, 'to_date':parent.date}" name="product_id" on_change="on_change_product_id(location_id,product_id,product_uom_id,parent.date)"  domain="[('type','=','product')]"/>

From 8970296df02dd15474fdfeb18ce42dbdca075c88 Mon Sep 17 00:00:00 2001
From: "Turkesh Patel (Open ERP)" <tpa@tinyerp.com>
Date: Tue, 27 Aug 2013 16:13:10 +0530
Subject: [PATCH 04/12] [IMP] impeoved indetation

bzr revid: tpa@tinyerp.com-20130827104310-b9dzoae4m02ia93n
---
 addons/stock/stock_view.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/stock/stock_view.xml b/addons/stock/stock_view.xml
index 08a6636717d..c79b91d35f3 100644
--- a/addons/stock/stock_view.xml
+++ b/addons/stock/stock_view.xml
@@ -145,7 +145,7 @@
                         </tree>
                     </field>
                     </page>
-                   <page string="Inventory Adjustments" attrs="{'invisible': [('move_ids_exist', '=', False)],'invisible': [('state','=','draft')] }">
+                    <page string="Inventory Adjustments" attrs="{'invisible': [('move_ids_exist', '=', False)],'invisible': [('state','=','draft')] }">
                         <field name="move_ids" context="{'inventory_id':active_id}" readonly="1">
                            <tree string="Inventory Adjustments">
                                <field name="product_id"/>

From 8794b51ec0e693262e59e96eb4d368b9bab870d9 Mon Sep 17 00:00:00 2001
From: "Turkesh Patel (Open ERP)" <tpa@tinyerp.com>
Date: Thu, 29 Aug 2013 16:58:27 +0530
Subject: [PATCH 05/12] [IMP] remove fill inventory wizard and improved view.

bzr revid: tpa@tinyerp.com-20130829112827-ywcklnhz0p6fxi4a
---
 addons/stock/__openerp__.py                   |  1 -
 addons/stock/stock.py                         |  6 +-
 addons/stock/stock_view.xml                   | 59 ++++++++-----------
 addons/stock/wizard/__init__.py               |  1 -
 addons/stock/wizard/stock_fill_inventory.py   | 51 ----------------
 .../wizard/stock_fill_inventory_view.xml      | 33 -----------
 6 files changed, 26 insertions(+), 125 deletions(-)
 delete mode 100644 addons/stock/wizard/stock_fill_inventory.py
 delete mode 100644 addons/stock/wizard/stock_fill_inventory_view.xml

diff --git a/addons/stock/__openerp__.py b/addons/stock/__openerp__.py
index 57019053481..15d072be6e0 100644
--- a/addons/stock/__openerp__.py
+++ b/addons/stock/__openerp__.py
@@ -69,7 +69,6 @@ Dashboard / Reports for Warehouse Management will include:
         'stock_data.xml',
         'wizard/stock_move_view.xml',
         'wizard/stock_change_product_qty_view.xml',
-        'wizard/stock_fill_inventory_view.xml',
         'wizard/stock_inventory_merge_view.xml',
         'wizard/stock_location_product_view.xml',
         'wizard/stock_inventory_line_split_view.xml',
diff --git a/addons/stock/stock.py b/addons/stock/stock.py
index 642bd060976..0ce0a448c17 100644
--- a/addons/stock/stock.py
+++ b/addons/stock/stock.py
@@ -1784,7 +1784,7 @@ class stock_inventory(osv.osv):
         #TODO test
         self.action_cancel_draft(cr, uid, ids, context=context)
 
-    def _prepare_inventory(self, cr, uid, ids, full_of_zeros=False, context=None):
+    def prepare_inventory(self, cr, uid, ids, context=None):
         inventory_line_obj = self.pool.get('stock.inventory.line')
         for inventory in self.browse(cr, uid, ids, context=context):
             #clean the existing inventory lines before redoing an inventory proposal
@@ -1793,8 +1793,6 @@ class stock_inventory(osv.osv):
             #compute the inventory lines and create them
             vals = self._get_inventory_lines(cr, uid, inventory, context=context)
             for product_line in vals:
-                if full_of_zeros:
-                    product_line['product_qty'] = 0
                 inventory_line_obj.create(cr, uid, product_line, context=context)
         return self.write(cr, uid, ids, {'state': 'confirm'})
 
@@ -1843,7 +1841,7 @@ class stock_inventory_line(osv.osv):
         'company_id': fields.related('inventory_id', 'company_id', type='many2one', relation='res.company', string='Company', store=True, select=True, readonly=True),
         'prod_lot_id': fields.many2one('stock.production.lot', 'Serial Number', domain="[('product_id','=',product_id)]"),
         'state': fields.related('inventory_id', 'state', type='char', string='Status', readonly=True),
-        'real_qty':fields.related('product_id','qty_available', type='float', string='Real Quantity', store=True),
+        'real_qty':fields.related('product_id','qty_available', type='float', string='Real Quantity'),
     }
 
     def _resolve_inventory_line(self, cr, uid, inventory_line, theorical_lines, context=None):
diff --git a/addons/stock/stock_view.xml b/addons/stock/stock_view.xml
index c79b91d35f3..e274eb28758 100644
--- a/addons/stock/stock_view.xml
+++ b/addons/stock/stock_view.xml
@@ -101,16 +101,13 @@
             <field name="arch" type="xml">
                 <form string="Physical Inventory" version="7.0">
                 <header>
-                    <button name="%(action_view_stock_fill_inventory)d" states="draft" string="Start Inventory" type="action" class="oe_highlight" groups="stock.group_stock_user"/>
+                    <button name="prepare_inventory" states="draft" string="Start Inventory" type="object" class="oe_highlight" groups="stock.group_stock_user"/>
                     <button name="action_done" states="confirm" string="Validate Inventory" type="object" class="oe_highlight" groups="stock.group_stock_manager"/>
                     <button name="action_cancel_draft" states="cancel" string="Set to Draft" type="object"/>
                     <button name="action_cancel_inventory" states="draft,confirm,done" string="Cancel Inventory" type="object"/>
                     <field name="state" widget="statusbar" statusbar_visible="draft,confirm,done"/>
                 </header>
                 <sheet>
-                    <div class="oe_right oe_button_box">
-                        <button name="action_check" string="Check Inventory Adjustments" states="draft,confirm" type="object" />
-                    </div>
                     <div class="oe_title">
                         <label for="name" class="oe_edit_only"/>
                         <h1><field name="name" placeholder="e.g. Annual inventory"/></h1>
@@ -118,48 +115,40 @@
                     <group>
                         <group>
                             <field name="location_id"/>
+                        </group>
+                        <group>
+                            <field name="date"/>
+                        </group>
+                        <div class="oe_grey" colspan="4">Specify filters to focus your inventory a on particular product, lot, pack and products owner</div>
+                        <group>
                             <field name="product_id"/>
                             <field name="lot_id"/>
                             <field name="company_id" groups="base.group_multi_company" widget="selection"/>
                         </group>
                         <group>
-                            <field name="date"/>
                             <field name="partner_id"/>
                             <field name="package_id"/>
                         </group>
                     </group>
                     <field name="move_ids_exist" invisible="1"/>
-                    <notebook>
-                    <page string="Inventory Details" attrs="{'invisible':[('state','=','draft')]}">
-                    <button name="set_checked_qty" states="confirm" icon="gtk-go-forward" string="Set Checked Quantity to 0" type="object" class="oe_link oe_right" groups="stock.group_stock_user"/>
-                    <field name="line_ids" string="Inventory Details">
-                        <tree string="Inventory Details" editable="bottom" colors="blue: product_qty != real_qty">
-                            <field context="{'location':location_id, 'uom':product_uom_id, 'to_date':parent.date}" name="product_id" on_change="on_change_product_id(location_id,product_id,product_uom_id,parent.date)"  domain="[('type','=','product')]"/>
-                            <field name="real_qty" readonly="1"/>
-                            <field name="product_qty" string="Checked Quantity"/>
-                            <field name="product_uom_id" groups="product.group_uom"/>
-                            <field name="prod_lot_id"/>
-                            <field name="package_id" readonly="1"/>
-                            <field domain="[('usage','=','internal')]" name="location_id" groups="stock.group_locations"/>
-                            <field name="state" invisible="True"/>
-                        </tree>
-                    </field>
-                    </page>
-                    <page string="Inventory Adjustments" attrs="{'invisible': [('move_ids_exist', '=', False)],'invisible': [('state','=','draft')] }">
-                        <field name="move_ids" context="{'inventory_id':active_id}" readonly="1">
-                           <tree string="Inventory Adjustments">
-                               <field name="product_id"/>
-                               <field name="lot_ids"/>
-                               <field name="product_uom_qty" on_change="onchange_quantity(product_id, product_uom_qty, product_uom, product_uos)"/>
-                               <field name="product_uom" string="Unit of Measure" groups="product.group_uom"/>
-                               <field name="location_id"/>
-                               <field name="location_dest_id"/>
-                               <field name="state"  invisible="True"/>
-                           </tree>
-                        </field>
-                    </page>
+                    <notebook attrs="{'invisible':[('state','=','draft')]}">
+                        <page string="Inventory Details" >
+                            <button name="set_checked_qty" states="confirm" icon="gtk-go-forward" string="Set Checked Quantity to 0" type="object" class="oe_link oe_right" groups="stock.group_stock_user"/>
+                            <field name="line_ids" string="Inventory Details">
+                                <tree string="Inventory Details" editable="bottom" colors="blue: product_qty != real_qty">
+                                    <field context="{'location':location_id, 'uom':product_uom_id, 'to_date':parent.date}" name="product_id" on_change="on_change_product_id(location_id,product_id,product_uom_id,parent.date)"  domain="[('type','=','product')]"/>
+                                    <field name="real_qty" readonly="1"/>
+                                    <field name="product_qty" string="Checked Quantity"/>
+                                    <field name="product_uom_id" groups="product.group_uom"/>
+                                    <field name="prod_lot_id"/>
+                                    <field name="package_id" readonly="1"/>
+                                    <field domain="[('usage','=','internal')]" name="location_id" groups="stock.group_locations"/>
+                                    <field name="state" invisible="True"/>
+                                </tree>
+                            </field>
+                        </page>
                     </notebook>
-                    </sheet>
+                </sheet>
                 </form>
             </field>
         </record>
diff --git a/addons/stock/wizard/__init__.py b/addons/stock/wizard/__init__.py
index 4979707d9b0..a29f3207ca1 100644
--- a/addons/stock/wizard/__init__.py
+++ b/addons/stock/wizard/__init__.py
@@ -21,7 +21,6 @@
 
 import stock_move
 import stock_inventory_merge
-import stock_fill_inventory
 import stock_inventory_line_split
 import stock_location_product
 import stock_return_picking
diff --git a/addons/stock/wizard/stock_fill_inventory.py b/addons/stock/wizard/stock_fill_inventory.py
deleted file mode 100644
index a9a58876d5e..00000000000
--- a/addons/stock/wizard/stock_fill_inventory.py
+++ /dev/null
@@ -1,51 +0,0 @@
-# -*- coding: utf-8 -*-
-##############################################################################
-#
-#    OpenERP, Open Source Management Solution
-#    Copyright (C) 2004-2010 Tiny SPRL (<http://tiny.be>).
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-from openerp.osv import fields, osv
-
-class stock_fill_inventory(osv.osv_memory):
-    _name = "stock.fill.inventory"
-    _description = "Import Inventory"
-
-    _columns = {
-        'set_stock_zero': fields.boolean("Set to zero", help="If checked, all product quantities will be set to zero to help ensure a real physical inventory is done"),
-    }
-
-    def fill_inventory(self, cr, uid, ids, context=None):
-        """ To Import stock inventory according to products available in the selected locations.
-        @param self: The object pointer.
-        @param cr: A database cursor
-        @param uid: ID of the user currently logged in
-        @param ids: the ID or list of IDs if we want more than one
-        @param context: A standard dictionary
-        @return:
-        """
-        if context is None:
-            context = {}
-
-        inventory_obj = self.pool.get('stock.inventory')
-        if ids and len(ids):
-            ids = ids[0]
-        fill_inventory = self.browse(cr, uid, ids, context=context)
-        inventory_obj._prepare_inventory(cr, uid, context.get('active_ids', []), fill_inventory.set_stock_zero, context=context)
-        return {'type': 'ir.actions.act_window_close'}
-
-# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
diff --git a/addons/stock/wizard/stock_fill_inventory_view.xml b/addons/stock/wizard/stock_fill_inventory_view.xml
deleted file mode 100644
index c45364daa7e..00000000000
--- a/addons/stock/wizard/stock_fill_inventory_view.xml
+++ /dev/null
@@ -1,33 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<openerp>
-    <data>
-           <record id="view_stock_fill_inventory" model="ir.ui.view">
-            <field name="name">Import Inventory</field>
-            <field name="model">stock.fill.inventory</field>
-            <field name="arch" type="xml">
-              <form string="Import Inventory" version="7.0">
-                  <separator string="Import the current inventory"/>
-                  <group>
-                      <field name="set_stock_zero"/>
-                  </group>
-                  <footer>
-                      <button name="fill_inventory" string="Fill Inventory" type="object" class="oe_highlight"/>
-                      or
-                      <button string="Cancel" class="oe_link" special="cancel" />
-                  </footer>
-              </form>
-            </field>
-        </record>
-
-        <record id="action_view_stock_fill_inventory" model="ir.actions.act_window">
-            <field name="name">Fill Inventory</field>
-            <field name="type">ir.actions.act_window</field>
-            <field name="res_model">stock.fill.inventory</field>
-            <field name="view_type">form</field>
-            <field name="view_mode">form</field>
-            <field name="view_id" ref="view_stock_fill_inventory"/>
-            <field name="target">new</field>
-        </record>
-            
-    </data>
-</openerp>

From aa3b992f05bf0fa437c57453f4a7520eba07a05c Mon Sep 17 00:00:00 2001
From: "Turkesh Patel (Open ERP)" <tpa@tinyerp.com>
Date: Fri, 30 Aug 2013 11:39:16 +0530
Subject: [PATCH 06/12] [IMP] improved yml test case and fixed error of
 reservation_id

bzr revid: tpa@tinyerp.com-20130830060916-jdkvltonayv503kd
---
 addons/stock/stock.py           |  2 +-
 addons/stock/stock_view.xml     |  1 -
 addons/stock/test/inventory.yml | 10 +++++-----
 3 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/addons/stock/stock.py b/addons/stock/stock.py
index 931b4c002ea..2844ce90e17 100644
--- a/addons/stock/stock.py
+++ b/addons/stock/stock.py
@@ -1485,7 +1485,7 @@ class stock_move(osv.osv):
             #    quant_obj.quants_move(cr, uid, quants, move, location_dest_id, context=context)
             # should replace the above 2 lines
             domain = ['|', ('reservation_id', '=', False), ('reservation_id', '=', move.id)]
-            prefered_order = 'reservation_id<>' + str(move.id)
+            prefered_order = 'reservation_id <> ' + str(move.id)
 #             if lot_id: 
 #                 prefered_order = 'lot_id<>' + lot_id + ", " + prefered_order
 #             if pack_id: 
diff --git a/addons/stock/stock_view.xml b/addons/stock/stock_view.xml
index 487c97cdd2a..d5bf29f5c4e 100644
--- a/addons/stock/stock_view.xml
+++ b/addons/stock/stock_view.xml
@@ -130,7 +130,6 @@
                             <field name="package_id"/>
                         </group>
                     </group>
-                    <field name="move_ids_exist" invisible="1"/>
                     <notebook attrs="{'invisible':[('state','=','draft')]}">
                         <page string="Inventory Details" >
                             <button name="set_checked_qty" states="confirm" icon="gtk-go-forward" string="Set Checked Quantity to 0" type="object" class="oe_link oe_right" groups="stock.group_stock_user"/>
diff --git a/addons/stock/test/inventory.yml b/addons/stock/test/inventory.yml
index f4e7d0533dd..f7ca195fc52 100644
--- a/addons/stock/test/inventory.yml
+++ b/addons/stock/test/inventory.yml
@@ -17,7 +17,7 @@
     product_qty: 10
     location_id: stock.stock_location_14
 -
-  I confirm this inventory
+  I Validate this inventory
 -
   !python {model: stock.inventory}: |
     self.action_done(cr, uid, [ref('inventory_test0')], context=context)
@@ -62,9 +62,9 @@
     inventory_id: stock.inventory_test1
     product_id: product.product_product_3
     product_qty: 20
-    location_id: stock.stock_location_14
+    location_id: stock.stock_location_components
 -
-  I confirm this inventory
+  I Validate this inventory
 -
   !python {model: stock.inventory}: |
     self.action_done(cr, uid, [ref('inventory_test1')], context=context)
@@ -72,6 +72,6 @@
   I check that the quantity on hand is 20 on the location and it's parent.
 -
   !python {model: product.product}: |
-    context['location'] = ref('stock.stock_location_14')
+    context['location'] = ref('stock.stock_location_components')
     product = self.browse(cr, uid, ref('product.product_product_3'), context=context)
-    assert product.qty_available==20, 'Expecting 20 products, got %.2f on location stock_location_14!' % (product.qty_available,)
+    assert product.qty_available==20, 'Expecting 20 products, got %.2f on location stock_location_components!' % (product.qty_available,)

From 2b19df0b69cefe0d60b1b4895e2a899949a39546 Mon Sep 17 00:00:00 2001
From: "Turkesh Patel (Open ERP)" <tpa@tinyerp.com>
Date: Fri, 30 Aug 2013 11:41:44 +0530
Subject: [PATCH 07/12] [IMP] renove lable for name

bzr revid: tpa@tinyerp.com-20130830061144-0txom9fa3x9mrzlr
---
 addons/stock/stock_view.xml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/addons/stock/stock_view.xml b/addons/stock/stock_view.xml
index d5bf29f5c4e..b3825f714b1 100644
--- a/addons/stock/stock_view.xml
+++ b/addons/stock/stock_view.xml
@@ -109,7 +109,6 @@
                 </header>
                 <sheet>
                     <div class="oe_title">
-                        <label for="name" class="oe_edit_only"/>
                         <h1><field name="name" placeholder="e.g. Annual inventory"/></h1>
                     </div>
                     <group>

From 70d076195521952595ad3852aa758f2b74e3efa0 Mon Sep 17 00:00:00 2001
From: "Sunil Sharma (OpenERP Trainee)" <sunilsharma.sharma07@gmail.com>
Date: Mon, 2 Sep 2013 12:21:47 +0530
Subject: [PATCH 08/12] [IMP]:Physical Inventories:As Per Pad Specificatino

bzr revid: sunilsharma.sharma07@gmail.com-20130902065147-mgaycbh4e8xq7edn
---
 addons/stock/stock.py       | 2 +-
 addons/stock/stock_view.xml | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/addons/stock/stock.py b/addons/stock/stock.py
index 2844ce90e17..3094b2aa8c5 100644
--- a/addons/stock/stock.py
+++ b/addons/stock/stock.py
@@ -1847,7 +1847,7 @@ class stock_inventory_line(osv.osv):
         'company_id': fields.related('inventory_id', 'company_id', type='many2one', relation='res.company', string='Company', store=True, select=True, readonly=True),
         'prod_lot_id': fields.many2one('stock.production.lot', 'Serial Number', domain="[('product_id','=',product_id)]"),
         'state': fields.related('inventory_id', 'state', type='char', string='Status', readonly=True),
-        'real_qty':fields.related('product_id','qty_available', type='float', string='Real Quantity'),
+        'real_qty':fields.related('product_id','qty_available', type='float', string='Real Quantity', store=True),
     }
 
     def _resolve_inventory_line(self, cr, uid, inventory_line, theorical_lines, context=None):
diff --git a/addons/stock/stock_view.xml b/addons/stock/stock_view.xml
index b3825f714b1..055a6d3805f 100644
--- a/addons/stock/stock_view.xml
+++ b/addons/stock/stock_view.xml
@@ -104,7 +104,7 @@
                     <button name="prepare_inventory" states="draft" string="Start Inventory" type="object" class="oe_highlight" groups="stock.group_stock_user"/>
                     <button name="action_done" states="confirm" string="Validate Inventory" type="object" class="oe_highlight" groups="stock.group_stock_manager"/>
                     <button name="action_cancel_draft" states="cancel" string="Set to Draft" type="object"/>
-                    <button name="action_cancel_inventory" states="draft,confirm,done" string="Cancel Inventory" type="object"/>
+                    <button name="action_cancel_inventory" states="confirm,done" string="Cancel Inventory" type="object"/>
                     <field name="state" widget="statusbar" statusbar_visible="draft,confirm,done"/>
                 </header>
                 <sheet>
@@ -131,7 +131,7 @@
                     </group>
                     <notebook attrs="{'invisible':[('state','=','draft')]}">
                         <page string="Inventory Details" >
-                            <button name="set_checked_qty" states="confirm" icon="gtk-go-forward" string="Set Checked Quantity to 0" type="object" class="oe_link oe_right" groups="stock.group_stock_user"/>
+                            <button name="set_checked_qty" states="confirm" string="==> Set Checked Quantity to 0" type="object" class="oe_link oe_right" groups="stock.group_stock_user"/>
                             <field name="line_ids" string="Inventory Details">
                                 <tree string="Inventory Details" editable="bottom" colors="blue: product_qty != real_qty">
                                     <field context="{'location':location_id, 'uom':product_uom_id, 'to_date':parent.date}" name="product_id" on_change="on_change_product_id(location_id,product_id,product_uom_id,parent.date)"  domain="[('type','=','product')]"/>
@@ -139,7 +139,7 @@
                                     <field name="product_qty" string="Checked Quantity"/>
                                     <field name="product_uom_id" groups="product.group_uom"/>
                                     <field name="prod_lot_id"/>
-                                    <field name="package_id" readonly="1"/>
+                                    <field name="package_id"/>
                                     <field domain="[('usage','=','internal')]" name="location_id" groups="stock.group_locations"/>
                                     <field name="state" invisible="True"/>
                                 </tree>

From dafb61db8daeea628571ac86e75e4469ba24004e Mon Sep 17 00:00:00 2001
From: "Sunil Sharma (OpenERP Trainee)" <sunilsharma.sharma07@gmail.com>
Date: Tue, 3 Sep 2013 12:02:11 +0530
Subject: [PATCH 09/12] [IMP]Stock:As Per Pad Specification

bzr revid: sunilsharma.sharma07@gmail.com-20130903063211-mepcb1hu6ewhvfkw
---
 addons/stock/stock.py           |  8 ++++----
 addons/stock/stock_view.xml     |  2 +-
 addons/stock/test/inventory.yml | 10 +++++-----
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/addons/stock/stock.py b/addons/stock/stock.py
index 6635c00da63..e4bb46cca2b 100644
--- a/addons/stock/stock.py
+++ b/addons/stock/stock.py
@@ -1696,10 +1696,10 @@ class stock_inventory(osv.osv):
         'state': fields.selection([('draft', 'Draft'), ('cancel', 'Cancelled'), ('confirm', 'In Progress'), ('done', 'Validated')], 'Status', readonly=True, select=True),
         'company_id': fields.many2one('res.company', 'Company', required=True, select=True, readonly=True, states={'draft': [('readonly', False)]}),
         'location_id': fields.many2one('stock.location', 'Location', required=True),
-        'product_id': fields.many2one('product.product', 'Product', help="Product Name"),
-        'package_id': fields.many2one('stock.quant.package', 'Pack'),
-        'partner_id': fields.many2one('res.partner', 'Owner'),
-        'lot_id': fields.many2one('stock.production.lot', 'Lot/Serial Number', help="Forces to specify a Serial Number for all moves generated by Inventoty"),
+        'product_id': fields.many2one('product.product', 'Product', help="Select Product to Specify filters to focus your inventory a on particular product"),
+        'package_id': fields.many2one('stock.quant.package', 'Pack', help="Select Pack to Specify filters to focus your inventory a on particular Pack"),
+        'partner_id': fields.many2one('res.partner', 'Owner', help="Select Owner to Specify filters to focus your inventory a on particular Owner"),
+        'lot_id': fields.many2one('stock.production.lot', 'Lot/Serial Number', help="Select Lot/Serial Number to Specify filters to focus your inventory a on particular Lot/Serial Number"),
         'move_ids_exist': fields.function(_get_move_ids_exist, type='boolean', string=' Stock Move Exists?', help='technical field for attrs in view'),
     }
 
diff --git a/addons/stock/stock_view.xml b/addons/stock/stock_view.xml
index 347535b0b05..cddd99ae0e5 100644
--- a/addons/stock/stock_view.xml
+++ b/addons/stock/stock_view.xml
@@ -131,7 +131,7 @@
                     </group>
                     <notebook attrs="{'invisible':[('state','=','draft')]}">
                         <page string="Inventory Details" >
-                            <button name="set_checked_qty" states="confirm" string="==> Set Checked Quantity to 0" type="object" class="oe_link oe_right" groups="stock.group_stock_user"/>
+                            <button name="set_checked_qty" states="confirm" string="⇒ Set Checked Quantity to 0" type="object" class="oe_link oe_right" groups="stock.group_stock_user"/>
                             <field name="line_ids" string="Inventory Details">
                                 <tree string="Inventory Details" editable="bottom" colors="blue: product_qty != real_qty">
                                     <field context="{'location':location_id, 'uom':product_uom_id, 'to_date':parent.date}" name="product_id" on_change="on_change_product_id(location_id,product_id,product_uom_id,parent.date)"  domain="[('type','=','product')]"/>
diff --git a/addons/stock/test/inventory.yml b/addons/stock/test/inventory.yml
index d52df2c2d90..1a397c7d093 100644
--- a/addons/stock/test/inventory.yml
+++ b/addons/stock/test/inventory.yml
@@ -1,9 +1,9 @@
 -
   In order to test the inventory, I create a new product
 -
-    !record {model: product.product, id: inventory_product}:
-         name: inventory prod
-         type: product
+  !record {model: product.product, id: inventory_product}:
+    name: inventory prod
+    type: product
 -
   I create an inventory for this product only
 -
@@ -67,8 +67,8 @@
     self.prepare_inventory(cr, uid, [ref('inventory_test1')], context=context)
     inv = self.browse(cr, uid, ref('inventory_test1'), context=context)
     assert inv.line_ids and len(inv.line_ids) == 1, "Wrong number of inventory lines."
-    assert len(inv.line_ids[0].product_qty) == 10, "Wrong quantity in inventory line."
-    assert len(inv.line_ids[0].product_id.id) == ref('inventory_product'), "Wrong product in inventory line."
+    assert inv.line_ids[0].product_qty == 10, "Wrong quantity in inventory line."
+    assert inv.line_ids[0].product_id.id == ref('inventory_product'), "Wrong product in inventory line."
 -
   I modify the inventory line and set the quantity to 20 product on this new inventory
 -

From ce5516623f1fa88de072960bec54cc3660d9be0c Mon Sep 17 00:00:00 2001
From: "Sunil Sharma (OpenERP Trainee)" <sunilsharma.sharma07@gmail.com>
Date: Thu, 5 Sep 2013 15:47:09 +0530
Subject: [PATCH 10/12] [IMP]:Stock:As Per Pad Specification

bzr revid: sunilsharma.sharma07@gmail.com-20130905101709-bbymhvrwx7sklw9t
---
 addons/stock/stock_view.xml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/addons/stock/stock_view.xml b/addons/stock/stock_view.xml
index 217b00fb9fe..8ece2647fe3 100644
--- a/addons/stock/stock_view.xml
+++ b/addons/stock/stock_view.xml
@@ -120,19 +120,19 @@
                         </group>
                         <div class="oe_grey" colspan="4">Specify filters to focus your inventory a on particular product, lot, pack and products owner</div>
                         <group>
-                            <field name="product_id"/>
-                            <field name="lot_id"/>
+                            <field name="product_id" attrs="{'readonly':[('state','!=','draft')]}"/>
+                            <field name="lot_id" attrs="{'readonly':[('state','!=','draft')]}"/>
                             <field name="company_id" groups="base.group_multi_company" widget="selection"/>
                         </group>
                         <group>
-                            <field name="partner_id"/>
-                            <field name="package_id"/>
+                            <field name="partner_id" attrs="{'readonly':[('state','!=','draft')]}"/>
+                            <field name="package_id" attrs="{'readonly':[('state','!=','draft')]}"/>
                         </group>
                     </group>
                     <notebook attrs="{'invisible':[('state','=','draft')]}">
                         <page string="Inventory Details" >
                             <button name="set_checked_qty" states="confirm" string="⇒ Set Checked Quantity to 0" type="object" class="oe_link oe_right" groups="stock.group_stock_user"/>
-                            <field name="line_ids" string="Inventory Details">
+                            <field name="line_ids" string="Inventory Details" context="{'default_location_id': location_id}">
                                 <tree string="Inventory Details" editable="bottom" colors="blue: product_qty != real_qty">
                                     <field context="{'location':location_id, 'uom':product_uom_id, 'to_date':parent.date}" name="product_id" on_change="on_change_product_id(location_id,product_id,product_uom_id,parent.date)"  domain="[('type','=','product')]"/>
                                     <field name="real_qty" readonly="1"/>

From 2f738cb052bf1244958d0ca2655aaa304919534f Mon Sep 17 00:00:00 2001
From: "Sunil Sharma (OpenERP Trainee)" <sunilsharma.sharma07@gmail.com>
Date: Thu, 5 Sep 2013 16:21:07 +0530
Subject: [PATCH 11/12] [IMP]:Stock:As Per Pad Specification

bzr revid: sunilsharma.sharma07@gmail.com-20130905105107-f3kekdeyy8be3sh2
---
 addons/stock/stock.py       | 2 +-
 addons/stock/stock_view.xml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/addons/stock/stock.py b/addons/stock/stock.py
index ad2427372b3..4a1f0a122d6 100644
--- a/addons/stock/stock.py
+++ b/addons/stock/stock.py
@@ -1836,7 +1836,7 @@ class stock_inventory(osv.osv):
         domain = ' location_id in %s'
         args = (tuple(location_ids),)
         if inventory.partner_id:
-            domain += ' and partner_id = %s'
+            domain += ' and owner_id = %s'
             args += (inventory.partner_id.id,)
         if inventory.lot_id:
             domain += ' and lot_id = %s'
diff --git a/addons/stock/stock_view.xml b/addons/stock/stock_view.xml
index 8ece2647fe3..62dddfcf5fe 100644
--- a/addons/stock/stock_view.xml
+++ b/addons/stock/stock_view.xml
@@ -132,7 +132,7 @@
                     <notebook attrs="{'invisible':[('state','=','draft')]}">
                         <page string="Inventory Details" >
                             <button name="set_checked_qty" states="confirm" string="⇒ Set Checked Quantity to 0" type="object" class="oe_link oe_right" groups="stock.group_stock_user"/>
-                            <field name="line_ids" string="Inventory Details" context="{'default_location_id': location_id}">
+                            <field name="line_ids" string="Inventory Details" context="{'default_location_id': location_id,  'default_product_id': product_id, 'default_prod_lot_id': lot_id, 'default_package_id': package_id}">
                                 <tree string="Inventory Details" editable="bottom" colors="blue: product_qty != real_qty">
                                     <field context="{'location':location_id, 'uom':product_uom_id, 'to_date':parent.date}" name="product_id" on_change="on_change_product_id(location_id,product_id,product_uom_id,parent.date)"  domain="[('type','=','product')]"/>
                                     <field name="real_qty" readonly="1"/>

From c49f43d5bf6d19bed91e198035930611c144b60e Mon Sep 17 00:00:00 2001
From: "Turkesh Patel (Open ERP)" <tpa@tinyerp.com>
Date: Tue, 10 Sep 2013 14:36:27 +0530
Subject: [PATCH 12/12] [IMP] add label for name, improved helps and add domain
 on products.

bzr revid: tpa@tinyerp.com-20130910090627-y6ov6iyihaajk5nn
---
 addons/stock/stock.py       |  8 ++++----
 addons/stock/stock_view.xml | 13 +++++++------
 2 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/addons/stock/stock.py b/addons/stock/stock.py
index 4654e1c0073..b8532d545b7 100644
--- a/addons/stock/stock.py
+++ b/addons/stock/stock.py
@@ -1701,10 +1701,10 @@ class stock_inventory(osv.osv):
         'state': fields.selection([('draft', 'Draft'), ('cancel', 'Cancelled'), ('confirm', 'In Progress'), ('done', 'Validated')], 'Status', readonly=True, select=True),
         'company_id': fields.many2one('res.company', 'Company', required=True, select=True, readonly=True, states={'draft': [('readonly', False)]}),
         'location_id': fields.many2one('stock.location', 'Location', required=True),
-        'product_id': fields.many2one('product.product', 'Product', help="Select Product to Specify filters to focus your inventory a on particular product"),
-        'package_id': fields.many2one('stock.quant.package', 'Pack', help="Select Pack to Specify filters to focus your inventory a on particular Pack"),
-        'partner_id': fields.many2one('res.partner', 'Owner', help="Select Owner to Specify filters to focus your inventory a on particular Owner"),
-        'lot_id': fields.many2one('stock.production.lot', 'Lot/Serial Number', help="Select Lot/Serial Number to Specify filters to focus your inventory a on particular Lot/Serial Number"),
+        'product_id': fields.many2one('product.product', 'Product', readonly=True, states={'draft': [('readonly', False)]}, help="Specify Product to focus your inventory on a particular Product."),
+        'package_id': fields.many2one('stock.quant.package', 'Pack', readonly=True, states={'draft': [('readonly', False)]}, help="Specify Pack to focus your inventory on a particular Pack."),
+        'partner_id': fields.many2one('res.partner', 'Owner', readonly=True, states={'draft': [('readonly', False)]}, help="Specify Owner to focus your inventory on a particular Owner."),
+        'lot_id': fields.many2one('stock.production.lot', 'Lot/Serial Number', readonly=True, states={'draft': [('readonly', False)]}, help="Specify Lot/Serial Number to focus your inventory on a particular Lot/Serial Number."),
         'move_ids_exist': fields.function(_get_move_ids_exist, type='boolean', string=' Stock Move Exists?', help='technical field for attrs in view'),
     }
 
diff --git a/addons/stock/stock_view.xml b/addons/stock/stock_view.xml
index 4af592e7baf..f76a70ca0f1 100644
--- a/addons/stock/stock_view.xml
+++ b/addons/stock/stock_view.xml
@@ -109,6 +109,7 @@
                 </header>
                 <sheet>
                     <div class="oe_title">
+                        <label for="name" class="oe_edit_only"/>
                         <h1><field name="name" placeholder="e.g. Annual inventory"/></h1>
                     </div>
                     <group>
@@ -118,15 +119,15 @@
                         <group>
                             <field name="date"/>
                         </group>
-                        <div class="oe_grey" colspan="4">Specify filters to focus your inventory a on particular product, lot, pack and products owner</div>
+                        <div class="oe_grey" colspan="4">Specify filters to focus your inventory a on particular product, lot, pack and product's owner.</div>
                         <group>
-                            <field name="product_id" attrs="{'readonly':[('state','!=','draft')]}"/>
-                            <field name="lot_id" attrs="{'readonly':[('state','!=','draft')]}"/>
+                            <field name="product_id" domain="[('type','=','product')]"/>
+                            <field name="lot_id"/>
                             <field name="company_id" groups="base.group_multi_company" widget="selection"/>
                         </group>
                         <group>
-                            <field name="partner_id" attrs="{'readonly':[('state','!=','draft')]}"/>
-                            <field name="package_id" attrs="{'readonly':[('state','!=','draft')]}"/>
+                            <field name="partner_id"/>
+                            <field name="package_id"/>
                         </group>
                     </group>
                     <notebook attrs="{'invisible':[('state','=','draft')]}">
@@ -134,7 +135,7 @@
                             <button name="set_checked_qty" states="confirm" string="⇒ Set Checked Quantity to 0" type="object" class="oe_link oe_right" groups="stock.group_stock_user"/>
                             <field name="line_ids" string="Inventory Details" context="{'default_location_id': location_id,  'default_product_id': product_id, 'default_prod_lot_id': lot_id, 'default_package_id': package_id, 'default_partner_id': partner_id}">
                                 <tree string="Inventory Details" editable="bottom" colors="blue: product_qty != real_qty">
-                                    <field context="{'location':location_id, 'uom':product_uom_id, 'to_date':parent.date}" name="product_id" on_change="on_change_product_id(location_id,product_id,product_uom_id,parent.date)"  domain="[('type','=','product')]"/>
+                                    <field context="{'location':location_id, 'uom':product_uom_id, 'to_date':parent.date}" name="product_id" on_change="on_change_product_id(location_id,product_id,product_uom_id,parent.date)" domain="[('type','=','product')]"/>
                                     <field name="real_qty" readonly="1"/>
                                     <field name="product_qty" string="Checked Quantity"/>
                                     <field name="product_uom_id" groups="product.group_uom"/>