From abf30a7f15eea2589d9f5c65668667efb0dff472 Mon Sep 17 00:00:00 2001
From: Yannick Tivisse <yti@odoo.com>
Date: Mon, 16 Nov 2015 18:53:02 +0100
Subject: [PATCH] [REM] Get rid of the ugly 'default_groups_ref' context key

Because it is useless now with the new behavior brought by the previous commit.
All the necessary details are explained in this one.
---
 addons/account/views/account_invoice_view.xml      |  4 ++--
 .../account_analytic_default_view.xml              |  2 +-
 addons/account_budget/account_budget_view.xml      |  2 +-
 addons/crm/crm_lead_view.xml                       |  5 ++---
 addons/crm_claim/crm_claim_view.xml                |  2 +-
 addons/gamification/data/goal_base.xml             |  1 -
 addons/hr/hr_view.xml                              |  3 +--
 .../hr_recruitment/views/hr_recruitment_views.xml  |  3 +--
 addons/hr_timesheet/hr_timesheet_view.xml          |  6 ++----
 addons/lunch/views/lunch_views.xml                 |  5 ++---
 addons/mrp/mrp_view.xml                            |  2 +-
 addons/point_of_sale/point_of_sale_view.xml        |  4 ++--
 addons/project/project_view.xml                    |  4 +---
 addons/project_issue/project_issue_view.xml        |  3 +--
 .../purchase_requisition_view.xml                  |  2 +-
 addons/sale/sale_view.xml                          |  2 +-
 addons/sales_team/views/crm_team_views.xml         |  2 +-
 addons/subscription/subscription_view.xml          |  2 +-
 addons/website_blog/views/website_blog_views.xml   |  2 +-
 openerp/addons/base/res/res_partner_view.xml       |  3 +--
 openerp/addons/base/res/res_users.py               | 14 --------------
 21 files changed, 24 insertions(+), 49 deletions(-)

diff --git a/addons/account/views/account_invoice_view.xml b/addons/account/views/account_invoice_view.xml
index 3cb5c0ef0e8..4fc154f5bdf 100644
--- a/addons/account/views/account_invoice_view.xml
+++ b/addons/account/views/account_invoice_view.xml
@@ -312,7 +312,7 @@
                                     <field name="journal_id" groups="account.group_account_user" options="{'no_create': True}"
                                         attrs="{'readonly':[('move_name','!=',False)]}"/>
                                     <field domain="[('partner_id', '=', partner_id)]" name="partner_bank_id" invisible="1"/>
-                                    <field name="user_id" string="Responsible" context="{'default_groups_ref': ['base.group_user', 'base.group_partner_manager', 'account.group_account_invoice']}"/>
+                                    <field name="user_id" string="Responsible"/>
                                     <field domain="[('company_id', '=', company_id), ('internal_type', '=', 'payable')]"
                                 name="account_id" groups="account.group_account_manager"/>
                                     <field name="name" invisible="1"/>
@@ -379,7 +379,7 @@
                         <group>
                             <field name="date_invoice"/>
                             <field name="move_name" invisible="1"/>
-                            <field name="user_id" groups="base.group_user" context="{'default_groups_ref': ['base.group_user', 'base.group_partner_manager', 'account.group_account_invoice']}"/>
+                            <field name="user_id" groups="base.group_user"/>
                             <label for="currency_id" groups="base.group_multi_currency"/>
                             <div groups="base.group_multi_currency">
                                 <field name="currency_id" options="{'no_create': True, 'no_open': True}" class="oe_inline"/>
diff --git a/addons/account_analytic_default/account_analytic_default_view.xml b/addons/account_analytic_default/account_analytic_default_view.xml
index c26633d8069..a167e9f2f80 100644
--- a/addons/account_analytic_default/account_analytic_default_view.xml
+++ b/addons/account_analytic_default/account_analytic_default_view.xml
@@ -29,7 +29,7 @@
                         <separator string="Conditions" colspan="4"/>
                         <field name="product_id"/>
                         <field name="partner_id"/>
-                        <field name="user_id" context="{'default_groups_ref': ['base.group_user', 'base.group_partner_manager', 'account.group_account_invoice', 'base.group_sale_salesman']}"/>
+                        <field name="user_id"/>
                         <field name="company_id" options="{'no_create': True}" groups="base.group_multi_company"/>
                         <field name="date_start"/>
                         <field name="date_stop"/>
diff --git a/addons/account_budget/account_budget_view.xml b/addons/account_budget/account_budget_view.xml
index 69ec48578f7..20c6d49c137 100644
--- a/addons/account_budget/account_budget_view.xml
+++ b/addons/account_budget/account_budget_view.xml
@@ -81,7 +81,7 @@
                         </div>
                         <group>
                             <group>
-                                <field name="creating_user_id" attrs="{'readonly':[('state','!=','draft')]}" context="{'default_groups_ref': ['base.group_user', 'base.group_partner_manager', 'account.group_account_user']}"/>
+                                <field name="creating_user_id" attrs="{'readonly':[('state','!=','draft')]}"/>
                             </group>
                             <group>
                                 <label for="date_from" string="Period"/>
diff --git a/addons/crm/crm_lead_view.xml b/addons/crm/crm_lead_view.xml
index fdadc2773b3..cbca48f2cf4 100644
--- a/addons/crm/crm_lead_view.xml
+++ b/addons/crm/crm_lead_view.xml
@@ -157,8 +157,7 @@
                             <field name="fax"/>
                         </group>
                         <group>
-                            <field name="user_id" on_change="on_change_user(user_id, context)"
-                                context="{'default_groups_ref': ['base.group_user', 'base.group_partner_manager', 'base.group_sale_salesman_all_leads'] }" widget="selection"/>
+                            <field name="user_id" on_change="on_change_user(user_id, context)" widget="selection"/>
                             <field name="team_id" widget="selection" domain="[('use_leads','=',True)]"/>
                             <field name="type" invisible="1"/>
                         </group>
@@ -507,7 +506,7 @@
                             </group>
 
                             <group>
-                                <field name="user_id" on_change="on_change_user(user_id, context)" context="{'default_groups_ref': ['base.group_user', 'base.group_partner_manager', 'base.group_sale_salesman_all_leads']}" widget="selection"/>
+                                <field name="user_id" on_change="on_change_user(user_id, context)" widget="selection"/>
                                 <field name="team_id" widget="selection"/>
                             </group>
                             <group>
diff --git a/addons/crm_claim/crm_claim_view.xml b/addons/crm_claim/crm_claim_view.xml
index 7a7790b6772..ab27c3e0086 100644
--- a/addons/crm_claim/crm_claim_view.xml
+++ b/addons/crm_claim/crm_claim_view.xml
@@ -129,7 +129,7 @@
                         <field name="date"/>
                     </group>
                     <group colspan="4" col="4"  groups="base.group_user">
-                        <field name="user_id" context="{'default_groups_ref': ['base.group_user', 'base.group_partner_manager', 'base.group_sale_salesman_all_leads']}"/>
+                        <field name="user_id"/>
                         <field name="priority" widget="priority"/>
                         <field name="team_id"/>
                         <field name="date_deadline"/>
diff --git a/addons/gamification/data/goal_base.xml b/addons/gamification/data/goal_base.xml
index ef6bf5a7629..46413e6372d 100644
--- a/addons/gamification/data/goal_base.xml
+++ b/addons/gamification/data/goal_base.xml
@@ -133,7 +133,6 @@
             <field name="view_type">form</field>
             <field name="target">current</field>
             <field name="view_id" ref="base.view_users_simple_form"/>
-            <field name="context">{'default_groups_ref': ['base.group_user']}</field>
             <field name="help">Create and manage users that will connect to the system. Users can be deactivated should there be a period of time during which they will/should not connect to the system. You can assign them groups in order to give them specific access to the applications they need to use in the system.</field>
         </record>
 
diff --git a/addons/hr/hr_view.xml b/addons/hr/hr_view.xml
index 95ddb8058c4..c4a8e22de2c 100644
--- a/addons/hr/hr_view.xml
+++ b/addons/hr/hr_view.xml
@@ -82,8 +82,7 @@
                                 <group>
                                     <group string='Status' name="active_group">
                                         <field name="company_id" groups="base.group_multi_company" on_change="onchange_company(company_id)"/>
-                                        <field name="user_id" on_change="onchange_user(name, image, user_id)" string="Related User"
-                                            context="{'default_groups_ref': ['base.group_user']}"/>
+                                        <field name="user_id" on_change="onchange_user(name, image, user_id)" string="Related User"/>
                                     </group>
                                 </group>
                             </page>
diff --git a/addons/hr_recruitment/views/hr_recruitment_views.xml b/addons/hr_recruitment/views/hr_recruitment_views.xml
index 6bec4c631c8..8ca54e82494 100644
--- a/addons/hr_recruitment/views/hr_recruitment_views.xml
+++ b/addons/hr_recruitment/views/hr_recruitment_views.xml
@@ -136,8 +136,7 @@
                         <field name="type_id" placeholder="Degree"/>
                     </group>
                     <group>
-                        <field name="user_id"
-                            context="{'default_groups_ref': ['base.group_user', 'base.group_partner_manager', 'base.group_hr_manager']}"/>
+                        <field name="user_id"/>
                         <label for="title_action"/>
                         <div>
                             <field name="date_action"/>
diff --git a/addons/hr_timesheet/hr_timesheet_view.xml b/addons/hr_timesheet/hr_timesheet_view.xml
index fcc5ee2f8be..732c7cc9d8b 100644
--- a/addons/hr_timesheet/hr_timesheet_view.xml
+++ b/addons/hr_timesheet/hr_timesheet_view.xml
@@ -8,8 +8,7 @@
             <field name="arch" type="xml">
                 <tree editable="top" string="Timesheet Activities">
                     <field name="date"/>
-                    <field name="user_id" required="1" options='{"no_open": True}'
-                        context="{'default_groups_ref': ['base.group_user']}"/>
+                    <field name="user_id" required="1" options='{"no_open": True}'/>
                     <field name="name"/>
                     <field name="account_id" context="{'default_type': 'contract'}" options="{'no_open': True, 'no_create': True}"/>
                     <field name="unit_amount" string="Duration" sum="Total time" widget="float_time"/>
@@ -26,8 +25,7 @@
                     <group>
                         <group>
                             <field name="name"/>
-                            <field name="user_id" required="1"
-                                context="{'default_groups_ref': ['base.group_user']}"/>
+                            <field name="user_id" required="1"/>
                                 <field name="is_timesheet" invisible="1"/>
                         </group>
                         <group>
diff --git a/addons/lunch/views/lunch_views.xml b/addons/lunch/views/lunch_views.xml
index c88e1b0443e..98ea2261b11 100644
--- a/addons/lunch/views/lunch_views.xml
+++ b/addons/lunch/views/lunch_views.xml
@@ -108,8 +108,7 @@
                 <form string="cashmove form">
                     <sheet>
                         <group>
-                            <field name="user_id"
-                                   context="{'default_groups_ref': ['base.group_user', 'lunch.group_lunch_user']}"/>
+                            <field name="user_id"/>
                             <field name="date"/>
                             <field name="amount"/>
                         </group>
@@ -388,7 +387,7 @@
 
                         <group>
                             <group>
-                                <field name='user_id' context="{'default_groups_ref': ['base.group_user', 'base.group_partner_manager', 'lunch.group_lunch_user']}" class="oe_inline"/>
+                                <field name='user_id' class="oe_inline"/>
                                 <field name='date'/>
                             </group>
                             <div>
diff --git a/addons/mrp/mrp_view.xml b/addons/mrp/mrp_view.xml
index 55b3260c170..3f7b9145f04 100644
--- a/addons/mrp/mrp_view.xml
+++ b/addons/mrp/mrp_view.xml
@@ -617,7 +617,7 @@
                                                 ('product_id','=',False)]"
                                 context="{'default_product_id': product_id, 'default_product_tmpl_id': product_tmpl_id}" on_change="bom_id_change(bom_id)" required="1"/>
                             <field name="routing_id" groups="mrp.group_mrp_routings"/>
-                            <field name="user_id" context="{'default_groups_ref': ['base.group_user', 'base.group_partner_manager', 'mrp.group_mrp_user']}"/>
+                            <field name="user_id"/>
                             <field name="origin"/>
                         </group>
                         <group groups="stock.group_locations">
diff --git a/addons/point_of_sale/point_of_sale_view.xml b/addons/point_of_sale/point_of_sale_view.xml
index 55c4c6b31b2..26afdf22c13 100644
--- a/addons/point_of_sale/point_of_sale_view.xml
+++ b/addons/point_of_sale/point_of_sale_view.xml
@@ -79,7 +79,7 @@
                             <group string="General Information">
                                 <field name="company_id" groups="base.group_multi_company"/>
                                 <field name="location_id" widget="selection" groups="stock.group_locations"/>
-                                <field name="user_id" context="{'default_groups_ref': ['base.group_user', 'base.group_partner_manager', 'point_of_sale.group_pos_user']}"/>
+                                <field name="user_id"/>
                                 <field name="pricelist_id" groups="product.group_sale_pricelist" domain="[('type','=','sale')]"/>
                                 <field name="picking_id" readonly="1"/>
                                 <field name="pos_reference"/>
@@ -835,7 +835,7 @@
                         <group>
                             <field name="cash_control" invisible="1" />
                             <group>
-                                <field name="user_id" context="{'default_groups_ref': ['base.group_user', 'base.group_partner_manager', 'point_of_sale.group_pos_manager', 'base.group_sale_manager']}"/>
+                                <field name="user_id"/>
                                 <field name="currency_id" invisible="1"/>
                                 <field name="config_id"/>
                             </group>
diff --git a/addons/project/project_view.xml b/addons/project/project_view.xml
index fb1f242e853..355462151e5 100644
--- a/addons/project/project_view.xml
+++ b/addons/project/project_view.xml
@@ -114,7 +114,6 @@
                                 <field name="partner_id" on_change="onchange_partner_id(partner_id)" string="Customer"/>
                                 <field name="user_id" string="Project Manager"
                                         attrs="{'readonly':[('state','in',['close', 'cancelled'])]}"
-                                        context="{'default_groups_ref': ['base.group_user', 'base.group_partner_manager', 'project.group_project_manager']}"
                                         groups="base.group_no_one"/>
                             </group>
                             <group name="misc">
@@ -264,8 +263,7 @@
                         <group>
                             <field name="project_id" domain="[('state','not in', ('close', 'cancelled'))]" on_change="onchange_project(project_id)" context="{'default_use_tasks':1}"/>
                             <field name="user_id"
-                                options='{"no_open": True}'
-                                context="{'default_groups_ref': ['base.group_user', 'base.group_partner_manager', 'project.group_project_user']}"/>
+                                options='{"no_open": True}'/>
                             <field name="planned_hours" widget="float_time"
                                     groups="project.group_time_work_estimation_tasks"
                                     on_change="onchange_planned(planned_hours)"/>
diff --git a/addons/project_issue/project_issue_view.xml b/addons/project_issue/project_issue_view.xml
index a56eac36289..de22453f749 100644
--- a/addons/project_issue/project_issue_view.xml
+++ b/addons/project_issue/project_issue_view.xml
@@ -25,8 +25,7 @@
                     </div>
                     <group>
                         <group>
-                            <field name="user_id"
-                                context="{'default_groups_ref': ['base.group_user', 'base.group_partner_manager', 'project.group_project_user']}"/>
+                            <field name="user_id"/>
                             <field name="priority" groups="base.group_user" widget="priority"/>
                             <field name="tag_ids" widget="many2many_tags"/>
                         </group>
diff --git a/addons/purchase_requisition/purchase_requisition_view.xml b/addons/purchase_requisition/purchase_requisition_view.xml
index b938c3748db..4ff40ba2780 100644
--- a/addons/purchase_requisition/purchase_requisition_view.xml
+++ b/addons/purchase_requisition/purchase_requisition_view.xml
@@ -53,7 +53,7 @@
                 </div>
                 <group>
                     <group>
-                        <field name="user_id" context="{'default_groups_ref': ['base.group_user', 'base.group_partner_manager', 'purchase.group_purchase_user', 'account.group_account_invoice']}" attrs="{'readonly': [('state','not in',('draft'))]}"/>
+                        <field name="user_id" attrs="{'readonly': [('state','not in',('draft'))]}"/>
                         <field name="exclusive" attrs="{'readonly': [('state','not in',('draft'))]}"/>
                         <field name="account_analytic_id" colspan="2" groups="purchase.group_analytic_accounting" attrs="{'readonly': [('state','not in',('draft'))]}"/>
                         <field name="multiple_rfq_per_supplier" attrs="{'readonly': [('state','not in',('draft'))]}"/>
diff --git a/addons/sale/sale_view.xml b/addons/sale/sale_view.xml
index cea6e8280a8..490ce5f8dd7 100644
--- a/addons/sale/sale_view.xml
+++ b/addons/sale/sale_view.xml
@@ -307,7 +307,7 @@
                         <page string="Other Information">
                             <group>
                                 <group string="Sales Information" name="sales_person">
-                                    <field name="user_id" context="{'default_groups_ref': ['base.group_user', 'base.group_partner_manager', 'account.group_account_invoice', 'base.group_sale_salesman_all_leads']}"/>
+                                    <field name="user_id"/>
                                     <field name="team_id" options="{'no_create': True}"/>
                                     <field name="client_order_ref"/>
                                     <field name="company_id" options="{'no_create': True}" groups="base.group_multi_company"/>
diff --git a/addons/sales_team/views/crm_team_views.xml b/addons/sales_team/views/crm_team_views.xml
index 0fd3f15fb1b..bcb75f2cc1c 100644
--- a/addons/sales_team/views/crm_team_views.xml
+++ b/addons/sales_team/views/crm_team_views.xml
@@ -59,7 +59,7 @@
                         </div>
                         <group>
                             <group name="left">
-                                <field name="user_id" context="{'default_groups_ref': ['base.group_user', 'base.group_partner_manager', 'base.group_sale_salesman_all_leads']}"/>
+                                <field name="user_id"/>
                                 <field name="code" groups="base.group_no_one"/>
                             </group>
                             <group name="right">
diff --git a/addons/subscription/subscription_view.xml b/addons/subscription/subscription_view.xml
index 6c9b1a8403f..0beebf28449 100644
--- a/addons/subscription/subscription_view.xml
+++ b/addons/subscription/subscription_view.xml
@@ -18,7 +18,7 @@
                     <group col="4">
                         <field name="name"/>
                         <field name="partner_id"/>
-                        <field name="user_id" context="{'default_groups_ref': ['base.group_user', 'base.group_partner_manager', 'account.group_account_invoice', 'base.group_sale_salesman']}"/>
+                        <field name="user_id"/>
                         <field name="active"/>
                     </group>
                     <notebook>
diff --git a/addons/website_blog/views/website_blog_views.xml b/addons/website_blog/views/website_blog_views.xml
index 5c75b77d42d..3c8dd896e1a 100644
--- a/addons/website_blog/views/website_blog_views.xml
+++ b/addons/website_blog/views/website_blog_views.xml
@@ -71,7 +71,7 @@
                             <field name="ranking" invisible="1"/>
                         </group>
                         <group string="Technical" groups="base.group_no_one">
-                            <field name="write_uid" context="{'default_groups_ref': ['base.group_user', 'base.group_partner_manager', 'base.group_website_designer']}"/>
+                            <field name="write_uid"/>
                             <field name="write_date"/>
                         </group>
                     </sheet>
diff --git a/openerp/addons/base/res/res_partner_view.xml b/openerp/addons/base/res/res_partner_view.xml
index fb1190a9612..2a288b446cb 100644
--- a/openerp/addons/base/res/res_partner_view.xml
+++ b/openerp/addons/base/res/res_partner_view.xml
@@ -310,8 +310,7 @@
                             <group name="container_row_2">
                                 <group string="Sale" name="sale">
                                     <field name="customer"/>
-                                    <field name="user_id" 
-                                        context="{'default_groups_ref': ['base.group_partner_manager']}"/>
+                                    <field name="user_id"/>
                                 </group>
                                 <group string="Purchase" name="purchase">
                                     <field name="supplier"/>
diff --git a/openerp/addons/base/res/res_users.py b/openerp/addons/base/res/res_users.py
index c929b2dab59..8f91219bf2a 100644
--- a/openerp/addons/base/res/res_users.py
+++ b/openerp/addons/base/res/res_users.py
@@ -869,20 +869,6 @@ class users_view(osv.osv):
         values = super(users_view, self).default_get(cr, uid, fields1, context)
         self._add_reified_groups(group_fields, values)
 
-        # add "default_groups_ref" inside the context to set default value for group_id with xml values
-        if 'groups_id' in fields and isinstance(context.get("default_groups_ref"), list):
-            groups = []
-            ir_model_data = self.pool.get('ir.model.data')
-            for group_xml_id in context["default_groups_ref"]:
-                group_split = group_xml_id.split('.')
-                if len(group_split) != 2:
-                    raise UserError(_('Invalid context default_groups_ref value (model.name_id) : "%s"') % group_xml_id)
-                try:
-                    temp, group_id = ir_model_data.get_object_reference(cr, uid, group_split[0], group_split[1])
-                except ValueError:
-                    group_id = False
-                groups += [group_id]
-            values['groups_id'] = groups
         return values
 
     def read(self, cr, uid, ids, fields=None, context=None, load='_classic_read'):