From ab9b5a13e4a610ae74a633e989620d5c3da240be Mon Sep 17 00:00:00 2001
From: Denis Ledoux <dle@odoo.com>
Date: Thu, 26 Oct 2017 17:23:14 +0200
Subject: [PATCH] [FIX] l10n_ca: default stock input account for products
 categories

Since Odoo 8.0,
the default stock input account for product categories
in the Canadian localization is set to
`214100 CANADA REVENUE AGENCY`

This is the case since this commit:
https://github.com/odoo/odoo/commit/13dacd11c10dac853def763432829b8976604a7d#diff-2e65e26a4efc4ab95e72dbe2033141ecL294
In which the account with the XML ID 2141_en
214100 Stock Received But Not Billed
has been renamed
214100 CANADA REVENUE AGENCY

In this very same commit, the account "Stock Received But Not Billed" has been moved to the account 217100,
under the XML ID chart2171_en:
https://github.com/odoo/odoo/commit/13dacd11c10dac853def763432829b8976604a7d#diff-2e65e26a4efc4ab95e72dbe2033141ecR447

While the default value for the products categories stock input account remained the same, the account with as code 2141:
https://github.com/odoo/odoo/blob/8.0/addons/l10n_ca/account_chart_template_en.xml#L8

This is an oversight. It was not meant that way. The default stock input account for products
should well be "Stock Received But Not Billed".

In addition, a stock account is supposed to be of type assets, and not of type liabilities.

I contacted @max3903, who was a contributor of the l10n_ca localization,
and who is therefore a better expert than me regarding the Canadian localization.
He confirmed me all the above findings.

opw-775413
---
 addons/l10n_ca/account_chart.xml                | 2 +-
 addons/l10n_ca/account_chart_template_after.xml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/addons/l10n_ca/account_chart.xml b/addons/l10n_ca/account_chart.xml
index 0a463374290..8610079a78f 100644
--- a/addons/l10n_ca/account_chart.xml
+++ b/addons/l10n_ca/account_chart.xml
@@ -217,7 +217,7 @@
 
     <record id="chart2171_en" model="account.account.template">
         <field name="code">2171</field>
-        <field name="user_type_id" ref="account.data_account_type_current_liabilities"/>
+        <field name="user_type_id" ref="account.data_account_type_current_assets"/>
         <field name="name">Stock Received But Not Billed</field>
         <field name="chart_template_id" ref="ca_en_chart_template_en"/>
     </record>
diff --git a/addons/l10n_ca/account_chart_template_after.xml b/addons/l10n_ca/account_chart_template_after.xml
index ccf130b9f0e..815fcea8b59 100644
--- a/addons/l10n_ca/account_chart_template_after.xml
+++ b/addons/l10n_ca/account_chart_template_after.xml
@@ -9,7 +9,7 @@
         <field name="property_account_payable_id" ref="chart2111_en"/>
         <field name="property_account_income_categ_id" ref="chart411_en"/>
         <field name="property_account_expense_categ_id" ref="chart5111_en"/>
-        <field name="property_stock_account_input_categ_id" ref="chart2141_en"/>
+        <field name="property_stock_account_input_categ_id" ref="chart2171_en"/>
         <field name="property_stock_account_output_categ_id" ref="chart1145_en"/>
         <field name="property_stock_valuation_account_id" ref="chart1141_en"/>
         <field name="income_currency_exchange_account_id" ref="chart42_en"/>