From ab3497b8890aa8bfff0ea0cd3005f577a09dbf4e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= <tde@odoo.com>
Date: Tue, 13 Dec 2022 14:11:37 +0000
Subject: [PATCH] [FIX] mass_mailing(_*): avoid sending fake emails

Some demo mass mailings are currently defined as being "in queue" in demo
data. This means they are about to be send by the mailing cron.

However we don't want demo data to send emails as

  * most of those emails are fake (e.g. targeting example.com);
  * real emails should not be sent (e.g. having by mistake a real email that
    will be spammed);
  * statistics resulting from those emails will not have any wow effect;
  * on SaaS this consumes email quota, and produces quite a big volume of
    unnecessary emails when people try the 16.0 version;

It is better to either have demo data of mailings done with traces, or keep
other mailings in draft. Otherwise the cron will send them. Flagging those
mailings is difficult, as emails are sent asynchronously and not during
install or update.

Even if this may lessen wow effect of some kanban view, better move mailings
currently "in queue" to "draft".

closes odoo/odoo#107904

X-original-commit: 0e11f4926be1800fc2b58feedcd81df24720ec19
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
---
 addons/mass_mailing_crm/data/mass_mailing_demo.xml  | 2 +-
 addons/mass_mailing_sale/data/mass_mailing_demo.xml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/addons/mass_mailing_crm/data/mass_mailing_demo.xml b/addons/mass_mailing_crm/data/mass_mailing_demo.xml
index b58c2b9b5ef..469c0b091d8 100644
--- a/addons/mass_mailing_crm/data/mass_mailing_demo.xml
+++ b/addons/mass_mailing_crm/data/mass_mailing_demo.xml
@@ -4,7 +4,7 @@
     <record id="mass_mail_lead_0" model="mailing.mailing">
         <field name="name">Lead Recall</field>
         <field name="subject">We want to hear from you !</field>
-        <field name="state">in_queue</field>
+        <field name="state">draft</field>
         <field name="user_id" ref="base.user_admin"/>
         <field name="schedule_date" eval="(DateTime.today() + relativedelta(days=5)).strftime('%Y-%m-%d %H:%M:%S')"/>
         <field name="campaign_id" ref="mass_mailing.mass_mail_campaign_1"/>
diff --git a/addons/mass_mailing_sale/data/mass_mailing_demo.xml b/addons/mass_mailing_sale/data/mass_mailing_demo.xml
index 65ec50e2d20..08ef762f9de 100644
--- a/addons/mass_mailing_sale/data/mass_mailing_demo.xml
+++ b/addons/mass_mailing_sale/data/mass_mailing_demo.xml
@@ -4,7 +4,7 @@
     <record id="mass_mail_sale_order_0" model="mailing.mailing">
         <field name="name">Sale Promotion 1</field>
         <field name="subject">Our last promotions, just for you !</field>
-        <field name="state">in_queue</field>
+        <field name="state">draft</field>
         <field name="user_id" ref="base.user_admin"/>
         <field name="schedule_date" eval="(DateTime.today() + relativedelta(days=5)).strftime('%Y-%m-%d %H:%M:%S')"/>
         <field name="campaign_id" ref="mass_mailing.mass_mail_campaign_1"/>