From ab0bd7be2523d562db9cd9f51ed377b05d96ab25 Mon Sep 17 00:00:00 2001
From: pka-odoo <pka@odoo.com>
Date: Tue, 6 Jun 2017 15:03:31 +0530
Subject: [PATCH] [FIX] (hr_)gamification,sales_team: one2many with many2many
 widget

with the new views, we removed the many2many_kanban widget on many2manys, since it is the default behaviour anyway, but we also removed it for a few one2manys.  And this is a mistake, some one2manys have to behave like many2manys.

(PR #17190)
---
 addons/gamification/views/badge.xml                  | 2 +-
 addons/hr_gamification/static/src/js/gamification.js | 2 +-
 addons/hr_gamification/views/hr_employee_views.xml   | 2 +-
 addons/sales_team/views/crm_team_views.xml           | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/addons/gamification/views/badge.xml b/addons/gamification/views/badge.xml
index 42e4cb7b3e9..20194764070 100644
--- a/addons/gamification/views/badge.xml
+++ b/addons/gamification/views/badge.xml
@@ -73,7 +73,7 @@
                         </group>
                     </group>
                     <group string="Rewards for challenges">
-                        <field name="challenge_ids" nolabel="1" context="{'default_reward_id': active_id}" />
+                        <field name="challenge_ids" mode="kanban" widget="many2many" nolabel="1" context="{'default_reward_id': active_id}" />
                     </group>
                     <group string="Statistics">
                         <group>
diff --git a/addons/hr_gamification/static/src/js/gamification.js b/addons/hr_gamification/static/src/js/gamification.js
index 585cbbdf9ee..28a3f8086fc 100644
--- a/addons/hr_gamification/static/src/js/gamification.js
+++ b/addons/hr_gamification/static/src/js/gamification.js
@@ -20,7 +20,7 @@ KanbanRecord.include({
                 view_mode: 'form',
                 view_type: 'form,kanban,tree',
                 views: [[false, 'form']],
-                res_id: this.record.badge_id.raw_value[0]
+                res_id: this.record.badge_id.raw_value
             };
             this.do_action(action);
         } else {
diff --git a/addons/hr_gamification/views/hr_employee_views.xml b/addons/hr_gamification/views/hr_employee_views.xml
index 15f971b8a6b..4ac7b7aac83 100644
--- a/addons/hr_gamification/views/hr_employee_views.xml
+++ b/addons/hr_gamification/views/hr_employee_views.xml
@@ -18,7 +18,7 @@
                             Badges are rewards of good work. Give them to people you believe deserve it.
                         </p>
                     </div>
-                    <field name="badge_ids" />
+                    <field name="badge_ids" mode="kanban" widget="many2many"/>
                 </page>
             </xpath>
 
diff --git a/addons/sales_team/views/crm_team_views.xml b/addons/sales_team/views/crm_team_views.xml
index b4ad3372495..27b14712f61 100644
--- a/addons/sales_team/views/crm_team_views.xml
+++ b/addons/sales_team/views/crm_team_views.xml
@@ -96,7 +96,7 @@
                         </group>
                         <notebook>
                             <page name="members" string="Team Members" attrs="{'invisible': [('team_type', 'in', ['pos', 'ebay'])]}">
-                                <field name="member_ids" options="{'not_delete': True}">
+                                <field name="member_ids" widget="many2many" options="{'not_delete': True}">
                                     <kanban quick_create="false" create="true" delete="true">
                                         <field name="id"/>
                                         <field name="name"/>