From aafee08bc687da292fa9165581226b05cf3da9c5 Mon Sep 17 00:00:00 2001 From: jvm-odoo Date: Fri, 27 Mar 2020 13:13:17 +0000 Subject: [PATCH] [FIX] website: fix duplicating a snippet remove its id Issue - Install website - Create a carousel - Duplicate it The second one doesn't work Cause Because of this override: https://github.com/odoo/odoo/blob/13.0/addons/website/static/src/js/editor/snippets.options.js#L1635:L1637 All duplicate IDs are removed but it should only remove the ID of a duplicated anchor Solution Check if the target has `data-anchor` attribute OPW-2222074 closes odoo/odoo#48790 X-original-commit: 6f0a4f1aea6ca78413d868f49b9ce105ce14e784 Signed-off-by: Nicolas Lempereur (nle) Signed-off-by: Jason Van Malder (jvm) --- addons/website/static/src/js/editor/snippets.options.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/addons/website/static/src/js/editor/snippets.options.js b/addons/website/static/src/js/editor/snippets.options.js index ab82318fa09..ce161d7a6d1 100644 --- a/addons/website/static/src/js/editor/snippets.options.js +++ b/addons/website/static/src/js/editor/snippets.options.js @@ -1551,7 +1551,8 @@ options.registry.anchor = options.Class.extend({ * @override */ onClone: function () { - this.$target.removeAttr('id data-anchor'); + this.$target.removeAttr('data-anchor'); + this.$target.filter(':not(.carousel)').removeAttr('id'); }, //--------------------------------------------------------------------------