pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[REF] web: change effect service API

Browse Source 
Before this commit, effect service provided two functions:
  create(type, params)
  rainbowMan(params)

Now, it provides one function add which is create but renamed
rainbowMan function can be called by doing:
  service.add("rainbowman", ...);

closes odoo-dev/odoo#969

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
This commit is contained in:
Michael Mattiello (mcm)
2021-06-18 21:31:34 +02:00
committed by Aaron Bohy
parent 8d8201a8e0
commit aa819f892d
5 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/web/static/tests/webclient/actions/effects_tests.js
+3 -3
View File
@@ -26,7 +26,7 @@ QUnit.module("ActionManager", (hooks) => {
await doAction(webClient, 1);
assert.containsOnce(webClient.el, ".o_kanban_view");
assert.containsNone(webClient.el, ".o_reward");
webClient.env.services.effect.rainbowMan({ message: "", fadeout: "no" });
webClient.env.services.effect.add("rainbowman", { message: "", fadeout: "no" });
await nextTick();
await legacyExtraNextTick();
assert.containsOnce(webClient.el, ".o_reward");
@@ -35,7 +35,7 @@ QUnit.module("ActionManager", (hooks) => {
await legacyExtraNextTick();
assert.containsNone(webClient.el, ".o_reward");
assert.containsOnce(webClient.el, ".o_kanban_view");
webClient.env.services.effect.rainbowMan({ message: "", fadeout: "no" });
webClient.env.services.effect.add("rainbowman", { message: "", fadeout: "no" });
await nextTick();
await legacyExtraNextTick();
assert.containsOnce(webClient.el, ".o_reward");
@@ -55,7 +55,7 @@ QUnit.module("ActionManager", (hooks) => {
assert.containsOnce(webClient.el, ".o_kanban_view");
assert.containsNone(webClient.el, ".o_reward");
assert.containsNone(webClient.el, ".o_notification");
webClient.env.services.effect.rainbowMan({ message: "", fadeout: "no" });
webClient.env.services.effect.add("rainbowman", { message: "", fadeout: "no" });
await nextTick();
await legacyExtraNextTick();
assert.containsOnce(webClient.el, ".o_kanban_view");
addons/web/static/tests/webclient/effects/rainbow_man_tests.js
+2 -2
View File
@@ -42,7 +42,7 @@ QUnit.module("RainbowMan", (hooks) => {
RainbowMan.rainbowFadeouts = { nextTick: 0 };
const env = await makeTestEnv({ serviceRegistry });
const parent = await mount(Parent, { env, target });
env.services.effect.rainbowMan(rainbowManDefault);
env.services.effect.add("rainbowman", rainbowManDefault);
await nextTick();
assert.containsOnce(target, ".o_reward");
assert.containsOnce(parent.el, ".o_reward_rainbow");
@@ -64,7 +64,7 @@ QUnit.module("RainbowMan", (hooks) => {
rainbowManDefault.fadeout = "no";
const env = await makeTestEnv({ serviceRegistry });
const parent = await mount(Parent, { env, target });
env.services.effect.rainbowMan(rainbowManDefault);
env.services.effect.add("rainbowman", rainbowManDefault);
await nextTick();
assert.containsOnce(parent.el, ".o_reward");
assert.containsOnce(parent.el, ".o_reward_rainbow");