From aa7fb8c72317e330bbeb6ce29b4aace8627ef1d7 Mon Sep 17 00:00:00 2001
From: XavierDo <xdo@odoo.com>
Date: Tue, 20 Mar 2018 16:22:02 +0100
Subject: [PATCH] [IMP] mail: add warning when partner email is invalid

Change the border and cross color of a recipient in mail
composer when the email is invalid (doesn't contains "@").

When sending an mail from composer the user will see easily
if an email adress is invalid and will cause a NO_VALID_RECIPIENT
error.

Task: #46158
PR: #24628
---
 addons/mail/static/src/xml/composer.xml | 11 +++++++++--
 addons/web/static/src/scss/fields.scss  |  6 ++++++
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/addons/mail/static/src/xml/composer.xml b/addons/mail/static/src/xml/composer.xml
index bb9321a749d..d09b6bc4f22 100644
--- a/addons/mail/static/src/xml/composer.xml
+++ b/addons/mail/static/src/xml/composer.xml
@@ -79,8 +79,15 @@
     </t>
 
     <t t-name="FieldMany2ManyTagsEmail" t-extend="FieldMany2ManyTag">
-        <t t-jquery=".o_badge_text" t-operation="replace">
-            <span class="o_badge_text" t-attf-title="#{el.email}"><t t-esc="el.display_name"/></span>
+        <t t-jquery="span[t-attf-class*=badge]" t-operation="replace">
+            <t t-set="email_error" t-value="''"/>
+            <t t-if="el.email.indexOf('@') &lt; 0">
+                <t t-set="email_error" t-value="'o_tag_error'"/>
+            </t>
+            <span t-attf-class="badge dropdown o_tag_color_0 #{email_error}" t-att-data-color="color" t-att-data-index="el_index" t-att-data-id="el.id">
+                <span class="o_badge_text" t-attf-title="#{el.email}"><t t-esc="el.display_name"/></span>
+                <span t-if="!readonly" class="fa fa-times o_delete"/>
+            </span>
         </t>
     </t>
 </templates>
diff --git a/addons/web/static/src/scss/fields.scss b/addons/web/static/src/scss/fields.scss
index 0fd69037b0b..2a35c33005a 100644
--- a/addons/web/static/src/scss/fields.scss
+++ b/addons/web/static/src/scss/fields.scss
@@ -173,6 +173,12 @@
                     }
                 }
             }
+        }        
+        > .o_tag_error{ 
+            box-shadow: inset 0 0 0 2px #FF0000;
+            > .o_delete {
+                color: #FF0000;
+            }
         }
     }