From a9ca779a1f17dd06f0b13ea00a3860b10aec2a52 Mon Sep 17 00:00:00 2001
From: "Louis Wicket (wil)" <wil@odoo.com>
Date: Wed, 25 Jan 2023 16:15:19 +0100
Subject: [PATCH] [IMP] mail: voip refactoring

Adds useful fields to models needed for VoIP to work.

closes odoo/odoo#115689

Related: odoo/enterprise#38339
Related: odoo/upgrade#5021
Signed-off-by: Louis Wicket (wil) <wil@odoo.com>
---
 addons/mail/static/src/core/common/persona_model.js   | 11 +++++++++++
 addons/mail/static/src/core/web/activity.xml          |  2 +-
 .../static/tests/helpers/model_definitions_setup.js   |  1 +
 3 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/addons/mail/static/src/core/common/persona_model.js b/addons/mail/static/src/core/common/persona_model.js
index cc067dba6ef..9e210c5ac6c 100644
--- a/addons/mail/static/src/core/common/persona_model.js
+++ b/addons/mail/static/src/core/common/persona_model.js
@@ -45,6 +45,10 @@ export class Persona extends Record {
     id;
     /** @type {boolean | undefined} */
     is_company;
+    /** @type {string} */
+    landlineNumber;
+    /** @type {string} */
+    mobileNumber;
     /** @type {'partner' | 'guest'} */
     type;
     /** @type {string} */
@@ -61,6 +65,13 @@ export class Persona extends Record {
     im_status;
     isAdmin = false;
 
+    /**
+     * @returns {boolean}
+     */
+    get hasPhoneNumber() {
+        return Boolean(this.mobileNumber || this.landlineNumber);
+    }
+
     get nameOrDisplayName() {
         return this.name || this.displayName;
     }
diff --git a/addons/mail/static/src/core/web/activity.xml b/addons/mail/static/src/core/web/activity.xml
index e0d3ea74c47..83d7a0de92e 100644
--- a/addons/mail/static/src/core/web/activity.xml
+++ b/addons/mail/static/src/core/web/activity.xml
@@ -39,7 +39,7 @@
                 </table>
             </div>
             <div t-if="activity.note" class="o-mail-Activity-note text-break" t-out="activity.note"/>
-            <div t-if="activity.mail_template_ids.length > 0" class="o-mail-Activity-mailTemplates">
+            <div t-if="activity.mail_template_ids?.length > 0" class="o-mail-Activity-mailTemplates">
                 <ActivityMailTemplate activity="activity" onUpdate="props.onUpdate"/>
             </div>
             <div t-if="activity.can_write" class="lh-lg">
diff --git a/addons/mail/static/tests/helpers/model_definitions_setup.js b/addons/mail/static/tests/helpers/model_definitions_setup.js
index 7c7d89cbbc3..8d4f0061e56 100644
--- a/addons/mail/static/tests/helpers/model_definitions_setup.js
+++ b/addons/mail/static/tests/helpers/model_definitions_setup.js
@@ -120,6 +120,7 @@ insertModelFields("res.users.settings", {
 
 insertRecords("mail.activity.type", [
     { icon: "fa-envelope", id: 1, name: "Email" },
+    { icon: "fa-phone", id: 2, name: "Call", category: "phonecall" },
     { icon: "fa-upload", id: 28, name: "Upload Document" },
 ]);
 insertRecords("mail.message.subtype", [