From a988653157deb82b4f3c833e085ede93da5dc726 Mon Sep 17 00:00:00 2001
From: Nicolas Lempereur <nle@odoo.com>
Date: Mon, 2 Jan 2017 17:28:28 +0100
Subject: [PATCH] [FIX] web: error if chart with only zero values

We could get an js error if the chart contained zero values.

opw-703245
---
 addons/web/static/src/js/views/graph_widget.js | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/addons/web/static/src/js/views/graph_widget.js b/addons/web/static/src/js/views/graph_widget.js
index 64ba42b1928..e67d12bcc18 100644
--- a/addons/web/static/src/js/views/graph_widget.js
+++ b/addons/web/static/src/js/views/graph_widget.js
@@ -205,18 +205,20 @@ return Widget.extend({
             all_zero = all_zero && (datapt.value === 0);
         });
         if (some_negative && !all_negative) {
-            return this.$el.append(QWeb.render('GraphView.error', {
+            this.$el.append(QWeb.render('GraphView.error', {
                 title: _t("Invalid data"),
                 description: _t("Pie chart cannot mix positive and negative numbers. " +
                     "Try to change your domain to only display positive results"),
             }));
+            return;
         }
         if (all_zero) {
-            return this.$el.append(QWeb.render('GraphView.error', {
+            this.$el.append(QWeb.render('GraphView.error', {
                 title: _t("Invalid data"),
                 description: _t("Pie chart cannot display all zero numbers.. " +
                     "Try to change your domain to display positive results"),
             }));
+            return;
         }
         if (this.groupbys.length) {
             data = this.data.map(function (datapt) {