From a98518225918a005e5d889f2addbe44a68c9cd91 Mon Sep 17 00:00:00 2001 From: Victor Feyens Date: Mon, 17 Jan 2022 15:53:52 +0000 Subject: [PATCH] [FIX] sale: do not discard price computation if feature is disabled The discount must be computed regardless of user groups (computed fields should not be dependent of user groups ideally). Anyway, pricelist discount policy is by default to show the price with discount. Unless the database and user groups are wrongly configured, this shouldn't have any impact. Part-of: odoo/odoo#82374 --- addons/sale/models/sale_order_line.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/addons/sale/models/sale_order_line.py b/addons/sale/models/sale_order_line.py index bd004609b82..a55bd1a677d 100644 --- a/addons/sale/models/sale_order_line.py +++ b/addons/sale/models/sale_order_line.py @@ -840,10 +840,6 @@ class SaleOrderLine(models.Model): @api.depends('product_id', 'product_uom', 'product_uom_qty') def _compute_discount(self): - if not self.env.user.has_group('product.group_discount_per_so_line'): - # Do not compute discounts if the feature is not enabled. - return - for line in self: if not line.product_id or line.display_type: line.discount = 0.0