From a8f8999409aca037146d3e4d9e2b81839039b3fd Mon Sep 17 00:00:00 2001 From: "Djamel (otd)" Date: Mon, 8 Mar 2021 08:39:13 +0000 Subject: [PATCH] [FIX]base: fix domain of "user_id" field in res.partner Steps to follow to reproduce the bug: -Go to the Contact app -Choose any contact -In the contact form> go to the "sales & purchase" tab and try to assign a user in the "salesperson" fields Problem: You can choose any user regardless of their type. While normally we can only choose internal users Solution: Add a domain to the "user_id" fields to only see users of the kind "internal type" opw-2468819 closes odoo/odoo#67642 X-original-commit: 1361686fe502be137a4757c9092fab4223d484f8 Signed-off-by: Yannick Tivisse (yti) Signed-off-by: Jorge Pinna Puissant (jpp) --- odoo/addons/base/models/res_partner.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/odoo/addons/base/models/res_partner.py b/odoo/addons/base/models/res_partner.py index d7481b3969f..a50362deefa 100644 --- a/odoo/addons/base/models/res_partner.py +++ b/odoo/addons/base/models/res_partner.py @@ -169,7 +169,7 @@ class Partner(models.Model): tz_offset = fields.Char(compute='_compute_tz_offset', string='Timezone offset', invisible=True) user_id = fields.Many2one('res.users', string='Salesperson', - help='The internal user in charge of this contact.') + help='The internal user in charge of this contact.', domain=lambda self: [('groups_id', 'in', self.env.ref('base.group_user').id)]) vat = fields.Char(string='Tax ID', index=True, help="The Tax Identification Number. Complete it if the contact is subjected to government taxes. Used in some legal statements.") same_vat_partner_id = fields.Many2one('res.partner', string='Partner with same Tax ID', compute='_compute_same_vat_partner_id', store=False) bank_ids = fields.One2many('res.partner.bank', 'partner_id', string='Banks')