From a8d3ba8a8be75103c7ef1496bfa7daed2f14a92d Mon Sep 17 00:00:00 2001 From: Kevin Baptiste Date: Fri, 11 Feb 2022 13:35:16 +0000 Subject: [PATCH] [IMP] hr_skills: ensure Progress is positive It was possible to have negative Progress on a skill, which doesn't make sense. Here we ensure it's a valid percentage between 0 and 100 inclusive. odoo/upgrade#3238 closes odoo/odoo#84442 Taskid: 2762009 Signed-off-by: Kevin Baptiste --- addons/hr_skills/models/hr_skills.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/addons/hr_skills/models/hr_skills.py b/addons/hr_skills/models/hr_skills.py index 12b2950f2a1..040b121c37d 100644 --- a/addons/hr_skills/models/hr_skills.py +++ b/addons/hr_skills/models/hr_skills.py @@ -74,6 +74,10 @@ class SkillLevel(models.Model): level_progress = fields.Integer(string="Progress", help="Progress from zero knowledge (0%) to fully mastered (100%).") default_level = fields.Boolean(help="If checked, this level will be the default one selected when choosing this skill.") + _sql_constraints = [ + ('check_level_progress', 'CHECK(level_progress BETWEEN 0 AND 100)', "Progress should be a number between 0 and 100."), + ] + def name_get(self): if not self._context.get('from_skill_level_dropdown'): return super().name_get()