From a8a6729eed07d5f34f5250088552f45025f6d85c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= <tde@odoo.com>
Date: Wed, 19 Dec 2018 12:22:53 +0000
Subject: [PATCH] [IMP] hr_recruitment_survey: add recruitment survey category

Purpose of this commit is to add a new survey category for applicants. That
way surveys created and/or used through recruitment process are correctly
set in their own category allowing to filter them. When creating a new
recruitment only surveys linked to recruitment process are shown. Moreover
default values are propagated when creating new surveys so that they are
correctly configured by default as recruitment and invite-only surveys.

This commit is linked to task ID 1911586 and PR #28986.
---
 addons/hr_recruitment_survey/__manifest__.py        |  1 +
 addons/hr_recruitment_survey/data/survey_demo.xml   |  1 +
 addons/hr_recruitment_survey/models/__init__.py     |  2 ++
 addons/hr_recruitment_survey/models/hr_job.py       |  1 +
 .../hr_recruitment_survey/models/survey_survey.py   |  9 +++++++++
 addons/hr_recruitment_survey/views/hr_job_views.xml |  7 ++++---
 .../views/survey_survey_views.xml                   | 13 +++++++++++++
 7 files changed, 31 insertions(+), 3 deletions(-)
 create mode 100644 addons/hr_recruitment_survey/models/survey_survey.py
 create mode 100644 addons/hr_recruitment_survey/views/survey_survey_views.xml

diff --git a/addons/hr_recruitment_survey/__manifest__.py b/addons/hr_recruitment_survey/__manifest__.py
index b3228699f0e..6d04b788b10 100644
--- a/addons/hr_recruitment_survey/__manifest__.py
+++ b/addons/hr_recruitment_survey/__manifest__.py
@@ -14,6 +14,7 @@
         'security/hr_recruitment_survey_security.xml',
         'views/hr_job_views.xml',
         'views/hr_applicant_views.xml',
+        'views/survey_survey_views.xml',
         'views/res_config_setting_views.xml',
     ],
     'demo': [
diff --git a/addons/hr_recruitment_survey/data/survey_demo.xml b/addons/hr_recruitment_survey/data/survey_demo.xml
index 2f98596d8db..f7480ec6d6b 100644
--- a/addons/hr_recruitment_survey/data/survey_demo.xml
+++ b/addons/hr_recruitment_survey/data/survey_demo.xml
@@ -4,6 +4,7 @@
         <field name="title">Recruitment Form</field>
         <field name="stage_id" ref="survey.stage_permanent"/>
         <field name="access_mode">token</field>
+        <field name="category">hr_recruitment</field>
         <field name="users_can_go_back" eval="True"/>
         <field name="description" type="html">
 <p>
diff --git a/addons/hr_recruitment_survey/models/__init__.py b/addons/hr_recruitment_survey/models/__init__.py
index 3d3ce8e9b0b..dc295255d0c 100644
--- a/addons/hr_recruitment_survey/models/__init__.py
+++ b/addons/hr_recruitment_survey/models/__init__.py
@@ -1,4 +1,6 @@
 # -*- coding: utf-8 -*-
+# Part of Odoo. See LICENSE file for full copyright and licensing details.
 
 from . import hr_job
 from . import hr_applicant
+from . import survey_survey
diff --git a/addons/hr_recruitment_survey/models/hr_job.py b/addons/hr_recruitment_survey/models/hr_job.py
index 9f424d34b52..eb24574e55a 100644
--- a/addons/hr_recruitment_survey/models/hr_job.py
+++ b/addons/hr_recruitment_survey/models/hr_job.py
@@ -8,6 +8,7 @@ class Job(models.Model):
 
     survey_id = fields.Many2one(
         'survey.survey', "Interview Form",
+        domain=[('category', '=', 'hr_recruitment')],
         help="Choose an interview form for this job position and you will be able to print/answer this interview from all applicants who apply for this job")
 
     @api.multi
diff --git a/addons/hr_recruitment_survey/models/survey_survey.py b/addons/hr_recruitment_survey/models/survey_survey.py
new file mode 100644
index 00000000000..21674e84ee6
--- /dev/null
+++ b/addons/hr_recruitment_survey/models/survey_survey.py
@@ -0,0 +1,9 @@
+# Part of Odoo. See LICENSE file for full copyright and licensing details.
+
+from odoo import fields, models
+
+
+class Survey(models.Model):
+    _inherit = 'survey.survey'
+
+    category = fields.Selection(selection_add=[('hr_recruitment', 'Recruitment')])
diff --git a/addons/hr_recruitment_survey/views/hr_job_views.xml b/addons/hr_recruitment_survey/views/hr_job_views.xml
index 1cab317718c..7223f1c6834 100644
--- a/addons/hr_recruitment_survey/views/hr_job_views.xml
+++ b/addons/hr_recruitment_survey/views/hr_job_views.xml
@@ -6,9 +6,10 @@
         <field name="inherit_id" ref="hr_recruitment.hr_job_survey"/>
         <field name="arch" type="xml">
             <xpath expr="//field[@name='address_id']" position="before">
-                <label for="survey_id" groups="base.group_user"/>
-                <div groups="base.group_user" class="o_row">
-                    <field name="survey_id"/>
+                <label for="survey_id" groups="survey.group_survey_user"/>
+                <div groups="survey.group_survey_user" class="o_row">
+                    <field name="survey_id"
+                        context="{'default_category': 'hr_recruitment', 'default_access_mode': 'token'}"/>
                     <button string="Display Interview Form" name="action_print_survey" type="object" attrs="{'invisible':[('survey_id','=',False)]}" class="oe_link"/>
                 </div>
             </xpath>
diff --git a/addons/hr_recruitment_survey/views/survey_survey_views.xml b/addons/hr_recruitment_survey/views/survey_survey_views.xml
new file mode 100644
index 00000000000..a6f51da722e
--- /dev/null
+++ b/addons/hr_recruitment_survey/views/survey_survey_views.xml
@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="utf-8"?>
+<odoo><data>
+    <record id="survey_survey_view_form" model="ir.ui.view">
+        <field name="name">survey.survey.view.form.inherit.hr_recruitment</field>
+        <field name="model">survey.survey</field>
+        <field name="inherit_id" ref="survey.survey_form"/>
+        <field name="arch" type="xml">
+            <xpath expr="//field[@name='category']" position="attributes">
+                <attribute name="invisible">0</attribute>
+            </xpath>
+        </field>
+    </record>
+</data></odoo>