From a7e221ae62ce373fbfe8e028cb5e1b3d9de8ae64 Mon Sep 17 00:00:00 2001
From: jbw <jbw@odoo.com>
Date: Wed, 14 Apr 2021 09:49:33 +0000
Subject: [PATCH] [FIX] account: fix small view bugs with pre 14.3 payments
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Hide "A second payment will be created automatically in the destination journal." message when
  a payment is posted. Used to only check if payment has a paired_internal_transfer_payment_id,
  but posted pre14.3 do not have a value for this field.
- Render "destination_journal_id" only required when payment is draft. As it might be NULL on
  pre 14.3 payments, and trigger “invalid fields” error when the user interacts with the view.

closes odoo/odoo#69410

X-original-commit: f942e132dc3b5a37f649e0ab2c11627b497d641c
Signed-off-by: William André (wan) <wan@odoo.com>
---
 addons/account/views/account_payment_view.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/addons/account/views/account_payment_view.xml b/addons/account/views/account_payment_view.xml
index 5d6f92a4de0..98f827d4b89 100644
--- a/addons/account/views/account_payment_view.xml
+++ b/addons/account/views/account_payment_view.xml
@@ -160,7 +160,7 @@
                                 attrs="{'invisible': ['|', '|', ('state', '!=', 'posted'), ('is_move_sent', '=', False), ('payment_method_code', '!=', 'manual')]}"/>
                         <field name="state" widget="statusbar" statusbar_visible="draft,posted"/>
                     </header>
-                    <div class="alert alert-info text-center" role="alert" attrs="{'invisible': ['|',('paired_internal_transfer_payment_id','!=',False),('is_internal_transfer','=',False)]}">
+                    <div class="alert alert-info text-center" role="alert" attrs="{'invisible': ['|','|',('paired_internal_transfer_payment_id','!=',False),('is_internal_transfer','=',False),('state','!=','draft')]}">
                         A second payment will be created automatically in the destination journal.
                     </div>
                     <div class="alert alert-warning text-center" role="alert" attrs="{
@@ -283,7 +283,7 @@
                                         }"/>
                                 <field name="destination_journal_id" context="{'default_partner_id': partner_id}"
                                        attrs="{'invisible': [('is_internal_transfer', '=', False)],
-                                       'readonly': [('state', '!=', 'draft')], 'required': [('is_internal_transfer', '=', True)]}"/>
+                                       'readonly': [('state', '!=', 'draft')], 'required': [('is_internal_transfer', '=', True),('state', '=', 'draft')]}"/>
                             </group>
                             <group>
                                 <field name="qr_code" invisible="1"/>