From a7b68c288bdc7bdac6a3289b51993a0d46fe5124 Mon Sep 17 00:00:00 2001
From: Goffin Simon <sig@odoo.com>
Date: Tue, 26 Jul 2016 14:26:09 +0200
Subject: [PATCH] [FIX] delivery: Many fields still available for editing after
 delivery is done

carrier_id, carrier_tracking_ref and number_of_packages must be in readonly if
the stock.picking is in done state.

opw:683810
---
 addons/delivery/views/delivery_view.xml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/addons/delivery/views/delivery_view.xml b/addons/delivery/views/delivery_view.xml
index 804e0191da4..a581f187419 100644
--- a/addons/delivery/views/delivery_view.xml
+++ b/addons/delivery/views/delivery_view.xml
@@ -174,11 +174,11 @@
                 <separator string="Carrier Information"/>
                 <group>
                     <group name='carrier_data'>
-                        <field name="carrier_id"/>
+                        <field name="carrier_id" attrs="{'readonly': [('state', '=', 'done')]}"/>
                         <field name="delivery_type" attrs="{'invisible':True}"/>
                         <label for="carrier_tracking_ref"/>
                         <div>
-                            <field name="carrier_tracking_ref" class="oe_inline"/>
+                            <field name="carrier_tracking_ref" class="oe_inline" attrs="{'readonly': [('state', '=', 'done')]}"/>
                             <button type='object' class="fa fa-arrow-right oe_link" name="cancel_shipment" string="Cancel" attrs="{'invisible':['|','|','|',('carrier_tracking_ref','=',False),('delivery_type','in', ['fixed', 'base_on_rule']),('delivery_type','=',False),('state','not in',('done'))]}"/>
                         </div>
                         <field name="carrier_price"/>
@@ -189,7 +189,7 @@
                             <field name="weight" class="oe_inline"/>
                             <field name="weight_uom_id" nolabel="1" class="oe_inline"/>
                         </div>
-                        <field name="number_of_packages"/>
+                        <field name="number_of_packages" attrs="{'readonly': [('state', '=', 'done')]}"/>
                     </group>
                 </group>
                 </xpath>
@@ -276,11 +276,11 @@
             <field name="arch" type="xml">
                 <xpath expr='//group[@name="carrier_data"]' position='replace'>
                     <group name='carrier_data'>
-                      <field name="carrier_id" attrs="{'invisible': [('picking_type_code', '=', 'incoming')]}"/>
+                      <field name="carrier_id" attrs="{'invisible': [('picking_type_code', '=', 'incoming')], 'readonly': [('state', '=', 'done')]}"/>
                       <field name="delivery_type" attrs="{'invisible':True}"/>
                       <label for="carrier_tracking_ref"/>
                       <div>
-                          <field name="carrier_tracking_ref" class="oe_inline"/>
+                          <field name="carrier_tracking_ref" class="oe_inline" attrs="{'readonly': [('state', '=', 'done')]}"/>
                           <button type='object' class="fa fa-arrow-right oe_link" name="cancel_shipment" string="Cancel" attrs="{'invisible':['|','|','|',('carrier_tracking_ref','=',False),('delivery_type','in', ['fixed', 'base_on_rule']),('delivery_type','=',False),('state','not in',('done'))]}"/>
                       </div>
                       <field name="carrier_price"/>