From a7b3003f9fdb23138b9f76acffb06f0409c2431f Mon Sep 17 00:00:00 2001 From: David Beguin Date: Mon, 18 Jan 2021 10:37:37 +0000 Subject: [PATCH] [FIX] im_livechat, website_livechat: fix rating values Rating values have been reviewed to be between 1 and 5 but not in livechat apps. This commit align rating values. Task ID-2301261 PR odoo/odoo#60549 X-original-commit: ed408d45e8d35eff94a73e37183cbf2e91833f15 --- addons/rating/models/rating_mixin.py | 2 +- addons/website_livechat/controllers/main.py | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/addons/rating/models/rating_mixin.py b/addons/rating/models/rating_mixin.py index 182d3d08b14..62d0d6c1767 100644 --- a/addons/rating/models/rating_mixin.py +++ b/addons/rating/models/rating_mixin.py @@ -248,7 +248,7 @@ class RatingMixin(models.AbstractModel): for key in data: if key >= RATING_LIMIT_SATISFIED: res['great'] += data[key] - elif key > RATING_LIMIT_OK: + elif key >= RATING_LIMIT_OK: res['okay'] += data[key] else: res['bad'] += data[key] diff --git a/addons/website_livechat/controllers/main.py b/addons/website_livechat/controllers/main.py index b3749180ee8..56a263e01d2 100644 --- a/addons/website_livechat/controllers/main.py +++ b/addons/website_livechat/controllers/main.py @@ -36,7 +36,8 @@ class WebsiteLivechat(LivechatController): ratings_per_partner = {partner_id: dict(great=0, okay=0, bad=0) for partner_id in ratings.mapped('rated_partner_id.id')} total_ratings_per_partner = dict.fromkeys(ratings.mapped('rated_partner_id.id'), 0) - rating_texts = {10: 'great', 5: 'okay', 1: 'bad'} + # keep 10 for backward compatibility + rating_texts = {10: 'great', 5: 'great', 3: 'okay', 1: 'bad'} for rating in ratings: partner_id = rating.rated_partner_id.id