From a7592986b73c4e02097dfd2c65338644ba1a8481 Mon Sep 17 00:00:00 2001
From: qsm-odoo <qsm@odoo.com>
Date: Thu, 25 Aug 2022 11:35:39 +0000
Subject: [PATCH] [REF] website: remove useless proxys to reach page manager
 act_window

A model method was initially introduced at [1] to return an URL action
reaching the frontend page manager. Following [2] as part of the
"website in backend" merge, a second python method was created to
basically do the same and the first one was also adapted to reach the
backend page manager view.

In fact, both those methods can be removed and replaced by XML-defined
actions that can be triggered via the right XML definitions in views.

[1]: https://github.com/odoo/odoo/commit/553e24ccd191f7aaa13b70242703003e71a91b2b
[2]: https://github.com/odoo/odoo/commit/0db19449d00aab20c35218ab8108e731717cb0fe

task-2889981

Part-of: odoo/odoo#98937
---
 addons/website/models/ir_ui_view.py    |  3 ---
 addons/website/models/website_page.py  |  8 --------
 addons/website/views/website_views.xml | 16 +++++++---------
 3 files changed, 7 insertions(+), 20 deletions(-)

diff --git a/addons/website/models/ir_ui_view.py b/addons/website/models/ir_ui_view.py
index 7586f3abe2b..4088e1a99b4 100644
--- a/addons/website/models/ir_ui_view.py
+++ b/addons/website/models/ir_ui_view.py
@@ -426,9 +426,6 @@ class View(models.Model):
         else:
             return super(View, self).get_default_lang_code()
 
-    def redirect_to_page_manager(self):
-        return self.env["ir.actions.server"]._for_xml_id('website.action_website_pages_list')
-
     def _read_template_keys(self):
         return super(View, self)._read_template_keys() + ['website_id']
 
diff --git a/addons/website/models/website_page.py b/addons/website/models/website_page.py
index f3db86dd355..f742e24775d 100644
--- a/addons/website/models/website_page.py
+++ b/addons/website/models/website_page.py
@@ -277,14 +277,6 @@ class Page(models.Model):
         url = '/' + slugify(page_url, max_length=1024, path=True)
         return self.env['website'].with_context(website_id=website_id).get_unique_path(url)
 
-    def action_manage_website_pages(self):
-        return {
-            'name': _('Website Pages'),
-            'type': 'ir.actions.act_window',
-            'res_model': 'website.page',
-            'view_mode': 'tree',
-            'view_id': self.env.ref('website.website_pages_tree_view').id,
-        }
 
 # this is just a dummy function to be used as ormcache key
 def _cached_response():
diff --git a/addons/website/views/website_views.xml b/addons/website/views/website_views.xml
index 92787631d44..eb732bb363d 100644
--- a/addons/website/views/website_views.xml
+++ b/addons/website/views/website_views.xml
@@ -215,13 +215,11 @@
             </field>
         </record>
 
-        <record id="action_website_pages_list" model="ir.actions.server">
-            <field name="name">Website: Pages</field>
-            <field name="model_id" ref="website.model_website_page"/>
-            <field name="state">code</field>
-            <field name="code">
-                action = model.action_manage_website_pages()
-            </field>
+        <record id="action_website_pages_list" model="ir.actions.act_window">
+            <field name="name">Website Pages</field>
+            <field name="res_model">website.page</field>
+            <field name="view_mode">tree</field>
+            <field name="view_id" ref="website.website_pages_tree_view"/>
         </record>
 
         <!-- ====== website.menu views =========================================
@@ -328,8 +326,8 @@
                 </field>
                 <sheet position="before">
                     <header>
-                        <button name="redirect_to_page_manager" string="Go to Page Manager"
-                            type="object" attrs="{'invisible': [('page_ids', '=', [])]}"/>
+                        <button type="action" name="website.action_website_pages_list"
+                            string="Go to Page Manager" attrs="{'invisible': [('page_ids', '=', [])]}"/>
                     </header>
                 </sheet>
                 <field name="active" position="after">