From a72112d70e303fc2fd16c3a269f5e3c69a21ffcb Mon Sep 17 00:00:00 2001 From: niyasraphy Date: Fri, 28 Jul 2023 07:18:15 +0000 Subject: [PATCH] [FIX] maintenance: compute method failed to assign error before this commit, on opening equipment form view a traceback is shown saying ompute method failed to assign error for field display_name this is related to: https://github.com/odoo/odoo/commit/3c62ca1eb96d571b2b686b5caee370324c589ab4 after this commit, no traceback wont be shown to user closes odoo/odoo#129978 Signed-off-by: Tiffany Chang --- addons/maintenance/models/maintenance.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/maintenance/models/maintenance.py b/addons/maintenance/models/maintenance.py index 6e6d9cdfa2b..63c9b71f9d4 100644 --- a/addons/maintenance/models/maintenance.py +++ b/addons/maintenance/models/maintenance.py @@ -95,9 +95,9 @@ class MaintenanceEquipment(models.Model): @api.depends('serial_no') def _compute_display_name(self): for record in self: - if record.name and record.serial_no: + if record.serial_no: record.display_name = record.name + '/' + record.serial_no - if record.name and not record.serial_no: + else: record.display_name = record.name @api.model