From a6507f0fa9fec6a071c21928dce76cd5c9916ddd Mon Sep 17 00:00:00 2001 From: qsm-odoo Date: Mon, 14 Oct 2019 11:42:53 +0000 Subject: [PATCH] [FIX] website_sale_comparison: fix compare animate The animation was not waiting for the target to be displayed. Part of https://github.com/odoo/odoo/pull/37132 task-2070507 X-original-commit: fb00568464e8d2a39975c373016616a2970aa501 --- .../static/src/js/website_sale_comparison.js | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/addons/website_sale_comparison/static/src/js/website_sale_comparison.js b/addons/website_sale_comparison/static/src/js/website_sale_comparison.js index f701374b350..b425f4cc852 100644 --- a/addons/website_sale_comparison/static/src/js/website_sale_comparison.js +++ b/addons/website_sale_comparison/static/src/js/website_sale_comparison.js @@ -106,18 +106,17 @@ var ProductComparison = publicWidget.Widget.extend(VariantMixin, { false ).then(function (productId) { productId = parseInt(productId, 10); - if (!productId) { return; } - - self._addNewProducts(productId); - website_sale_utils.animateClone( - $('#comparelist .o_product_panel_header'), - $elem.closest('form'), - -50, - 10 - ); + self._addNewProducts(productId).then(function () { + website_sale_utils.animateClone( + $('#comparelist .o_product_panel_header'), + $elem.closest('form'), + -50, + 10 + ); + }); }); } else { this.$('.o_comparelist_limit_warning').show(); @@ -158,7 +157,7 @@ var ProductComparison = publicWidget.Widget.extend(VariantMixin, { * @private */ _addNewProducts: function (product_id) { - this.guard.exec(this._addNewProductsImpl.bind(this, product_id)); + return this.guard.exec(this._addNewProductsImpl.bind(this, product_id)); }, _addNewProductsImpl: function (product_id) { var self = this;