From a64f5e33b87222e39d0823fdf973483bb2a14dff Mon Sep 17 00:00:00 2001
From: Denis Ledoux <dle@odoo.com>
Date: Tue, 2 Aug 2022 13:22:57 +0000
Subject: [PATCH] [IMP] sale_project: move group inside the view

The goal being to get rid of the `groups_id` feature for backend views

Part-of: odoo/odoo#98551
---
 .../sale_project/views/project_task_views.xml | 22 ++++---------------
 1 file changed, 4 insertions(+), 18 deletions(-)

diff --git a/addons/sale_project/views/project_task_views.xml b/addons/sale_project/views/project_task_views.xml
index 9653e6d79a9..3d1d0956f85 100644
--- a/addons/sale_project/views/project_task_views.xml
+++ b/addons/sale_project/views/project_task_views.xml
@@ -136,29 +136,15 @@
                 <field name="allow_billable" invisible="1"/>
                 <group attrs="{'invisible': [('allow_billable', '=', False)]}">
                     <field name="project_partner_id" invisible="1"/>
-                    <field name="sale_line_id" options="{'no_open': True}" readonly="1"/>
-                    <field name="quantity_percentage" widget="percentage" readonly="1"/>
+                    <field name="sale_line_id" groups="!sales_team.group_sale_salesman" options="{'no_open': True}" readonly="1"/>
+                    <field name="sale_line_id" groups="sales_team.group_sale_salesman" options="{'no_create': True}" readonly="0"/>
+                    <field name="quantity_percentage" groups="!sales_team.group_sale_salesman" widget="percentage" readonly="1"/>
+                    <field name="quantity_percentage" groups="sales_team.group_sale_salesman" widget="percentage" readonly="0"/>
                 </group>
             </xpath>
         </field>
     </record>
 
-    <record id="project_milestone_view_form_salesman" model="ir.ui.view">
-        <field name="name">project.milestone.view.form.inherit.salesman</field>
-        <field name="model">project.milestone</field>
-        <field name="inherit_id" ref="project_milestone_view_form"/>
-        <field name="groups_id" eval="[Command.link(ref('sales_team.group_sale_salesman'))]"/>
-        <field name="arch" type="xml">
-            <field name="sale_line_id" position="attributes">
-                <attribute name="options">{'no_create': True}</attribute>
-                <attribute name="readonly">0</attribute>
-            </field>
-            <field name="quantity_percentage" position="attributes">
-                <attribute name="readonly">0</attribute>
-            </field>
-        </field>
-    </record>
-
     <record id="project_milestone_view_tree" model="ir.ui.view">
         <field name="name">project.milestone.view.tree.inherit</field>
         <field name="model">project.milestone</field>