From a58458fb560eca6539d8e9cca502806fdc91bd05 Mon Sep 17 00:00:00 2001 From: Adrien Horgnies Date: Fri, 12 Jun 2020 08:33:09 +0000 Subject: [PATCH] [FIX] sale: set payment type to form current expression implies that any payment of a quote from the portal (/my/quotes) will try to save a token whenever the user says they want the customer to pay online, which seems bizarre. Normally you'd only want that for quotes with subscription products, and there is an override of that method in sale_subscription for that specific case. closes odoo/odoo#53024 X-original-commit: 47f7230cd38c4e5a2f644a04f87fa0b5a844f73b Signed-off-by: Damien Bouvy (dbo) --- addons/sale/models/sale.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/sale/models/sale.py b/addons/sale/models/sale.py index d03f56ac682..cd6abfd9f5e 100644 --- a/addons/sale/models/sale.py +++ b/addons/sale/models/sale.py @@ -1033,7 +1033,7 @@ Reason(s) of this behavior could be: def _get_payment_type(self): self.ensure_one() - return 'form_save' if self.require_payment else 'form' + return 'form' def _get_portal_return_action(self): """ Return the action used to display orders when returning from customer portal. """