From a502366525131ea3d44db4bc376db104ba4c8156 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= <tde@odoo.com>
Date: Wed, 27 Oct 2021 14:54:51 +0000
Subject: [PATCH] [REM] hr_recruitment, maintenance: remove unused aliases

Those modules hold default aliases to respectively create applicants or
maintenance request. Issue with those generic aliases are

  * they are not bound to any context (container document). For example jobs
    is not linked to any job record. Applicants will not have any job_id set;
  * they are not displayed anywhere. Applicant kanban view displays a helper
    when having no content, with an email address to start populating the
    view. This emails is however based on job in context, aka alias record
    created through the alias mixin on the job.
  * maintenance does not even try to use aliases in any view or code and just
    defines a dummy alias;
  * as default data they can be wrong: taking ``jobs`` and ``helpdesk`` is
    not necessarily a good idea. Indeed it depends on mail server configuration
    (e.g. not always owning all possible emails of a domain when using its own
    address like gmail). This may also conflicts with existing email addresses
    or already-defined aliases without being really configurable;
  * they are not configurable. They are not displayed in any configuration flow
    (setting or container document). Only going into technical menus to find all
    aliases allows to find them;

Conclusion: cleanup and remove.

Task-2710804 (Mail: Clean MailThread Posting API)
Prepares Task-36879 (Mail: Support MultiCompany Aliases)

Part-of: odoo/odoo#105992
---
 addons/hr_recruitment/__manifest__.py          |  1 -
 addons/hr_recruitment/data/mail_alias_data.xml | 11 -----------
 addons/maintenance/__manifest__.py             |  1 -
 addons/maintenance/data/mail_alias_data.xml    | 11 -----------
 4 files changed, 24 deletions(-)
 delete mode 100644 addons/hr_recruitment/data/mail_alias_data.xml
 delete mode 100644 addons/maintenance/data/mail_alias_data.xml

diff --git a/addons/hr_recruitment/__manifest__.py b/addons/hr_recruitment/__manifest__.py
index 136c6596858..bd4984fadd0 100644
--- a/addons/hr_recruitment/__manifest__.py
+++ b/addons/hr_recruitment/__manifest__.py
@@ -20,7 +20,6 @@
         'security/hr_recruitment_security.xml',
         'security/ir.model.access.csv',
         'data/digest_data.xml',
-        'data/mail_alias_data.xml',
         'data/mail_message_subtype_data.xml',
         'data/mail_template_data.xml',
         'data/mail_templates.xml',
diff --git a/addons/hr_recruitment/data/mail_alias_data.xml b/addons/hr_recruitment/data/mail_alias_data.xml
deleted file mode 100644
index 8a3df2c9f23..00000000000
--- a/addons/hr_recruitment/data/mail_alias_data.xml
+++ /dev/null
@@ -1,11 +0,0 @@
-<?xml version="1.0"?>
-<odoo>
-<data noupdate="1">
-    <record id="mail_alias_jobs" model="mail.alias">
-        <field name="alias_name">jobs</field>
-        <field name="alias_model_id" ref="model_hr_applicant"/>
-        <field name="alias_user_id" ref="base.user_admin"/>
-        <field name="alias_parent_model_id" ref="model_hr_job"/>
-    </record>
-</data>
-</odoo>
diff --git a/addons/maintenance/__manifest__.py b/addons/maintenance/__manifest__.py
index 725ad9e1b76..4fe51707eca 100644
--- a/addons/maintenance/__manifest__.py
+++ b/addons/maintenance/__manifest__.py
@@ -14,7 +14,6 @@
         'security/maintenance.xml',
         'security/ir.model.access.csv',
         'data/maintenance_data.xml',
-        'data/mail_alias_data.xml',
         'data/mail_activity_type_data.xml',
         'data/mail_message_subtype_data.xml',
         'views/maintenance_views.xml',
diff --git a/addons/maintenance/data/mail_alias_data.xml b/addons/maintenance/data/mail_alias_data.xml
deleted file mode 100644
index c0922547099..00000000000
--- a/addons/maintenance/data/mail_alias_data.xml
+++ /dev/null
@@ -1,11 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<odoo>
-<data noupdate="1">
-    <!-- email alias for maintenance requests -->
-    <record id="mail_alias_equipment" model="mail.alias">
-        <field name="alias_name">helpdesk</field>
-        <field name="alias_model_id" ref="model_maintenance_request"/>
-        <field name="alias_user_id" ref="base.user_admin"/>
-    </record>
-</data>
-</odoo>