From a4a3bfd373908fb44cb561fbd7cdcf129b5ddc93 Mon Sep 17 00:00:00 2001 From: jev Date: Thu, 24 Jan 2019 16:48:58 +0000 Subject: [PATCH] [FIX] mail: activity, crash when activity type is null When activity_type_id is null on an activity marking it as 'done and schedule schedule next' crashed OPW-1928989 closes odoo/odoo#30522 --- addons/mail/static/src/js/activity.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/mail/static/src/js/activity.js b/addons/mail/static/src/js/activity.js index 3c7e491edeb..e4470431d51 100644 --- a/addons/mail/static/src/js/activity.js +++ b/addons/mail/static/src/js/activity.js @@ -265,7 +265,7 @@ var Activity = AbstractActivityField.extend({ $popover.find('#activity_feedback').val(self.feedbackValue[activity_id]); $popover.on('click', '.o_activity_popover_done_next', function () { var feedback = _.escape($popover.find('#activity_feedback').val()); - var previous_activity_type_id = $popover_el.data('previous-activity-type-id'); + var previous_activity_type_id = $popover_el.data('previous-activity-type-id') || false; self._markActivityDone(activity_id, feedback) .then(self.scheduleActivity.bind(self, previous_activity_type_id)); });