From a45c1b53cc3f981782626539c0ff835cb61dbbd4 Mon Sep 17 00:00:00 2001
From: "jerome hanke (jhk)" <jhk@odoo.com>
Date: Fri, 27 Dec 2019 13:16:54 +0000
Subject: [PATCH] [FIX] mail: next activity due date type is required

Steps to reproduce:
-install base_automation and contacts
-go to settings > technical > automated actions
-create an automated action on new contact creation
-set your action to "create next activity"
-leave the activity due type to blank
-trigger the automated action by creating a new contact

Previous behavior:
you get a traceback error
"TypeError: __init__() keywords must be strings"

Current behavior:
the field is required when activity_date_deadline_range is not 0
and does not allow a blank type

opw-2159755

closes odoo/odoo#42503

X-original-commit: 04dff5ad6c5935f899c7946cb1924afaea9e547c
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
---
 addons/mail/views/ir_actions_views.xml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/addons/mail/views/ir_actions_views.xml b/addons/mail/views/ir_actions_views.xml
index 6d75522b755..0c7e2ef6247 100644
--- a/addons/mail/views/ir_actions_views.xml
+++ b/addons/mail/views/ir_actions_views.xml
@@ -18,7 +18,9 @@
                                 <label for="activity_date_deadline_range"/>
                                 <div class="o_row">
                                     <field name="activity_date_deadline_range"/>
-                                    <field name="activity_date_deadline_range_type"/>
+                                    <field name="activity_date_deadline_range_type" attrs="{
+                                        'required': [('state', '=', 'next_activity'), ('activity_date_deadline_range', '>', 0)]
+                                    }"/>
                                 </div>
                                 <field name="activity_user_type"/>
                                 <field name="activity_user_field_name" attrs="{