From a3fd6a2072020f8be41ab76986bc04c1a298528d Mon Sep 17 00:00:00 2001 From: len-odoo Date: Tue, 17 Jul 2018 13:45:23 +0200 Subject: [PATCH] [FIX] web_forum: fix the comparison of tags ids When checking if tags had changed, a missing .ids made it that a recordset was compared to a set of ids (integers). As a result, to make an edit the forum would always check that the user had sufficent karma to retag, even if it was not needed. opw 1866019 --- addons/website_forum/models/forum.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/website_forum/models/forum.py b/addons/website_forum/models/forum.py index ebe6bd80b2d..8bbf4717a70 100644 --- a/addons/website_forum/models/forum.py +++ b/addons/website_forum/models/forum.py @@ -502,7 +502,7 @@ class Post(models.Model): self.env.user.sudo().add_karma(post.forum_id.karma_gen_answer_accept * mult) if 'tag_ids' in vals: tag_ids = set(tag.get('id') for tag in self.resolve_2many_commands('tag_ids', vals['tag_ids'])) - if any(set(post.tag_ids) != tag_ids for post in self) and any(self.env.user.karma < post.forum_id.karma_edit_retag for post in self): + if any(set(post.tag_ids.ids) != tag_ids for post in self) and any(self.env.user.karma < post.forum_id.karma_edit_retag for post in self): raise KarmaError(_('Not enough karma to retag.')) if any(key not in trusted_keys for key in vals) and any(not post.can_edit for post in self): raise KarmaError('Not enough karma to edit a post.')