From 53ac302eabb1e6bd77734334e1dc7e0c367af3a5 Mon Sep 17 00:00:00 2001
From: Haresh Shyara <hsh@odoo.com>
Date: Thu, 23 Nov 2017 15:32:59 +0530
Subject: [PATCH 01/17] [REM] stock: removed stock_quant on traceability report

---
 addons/stock/models/stock_traceability.py     | 67 +++----------------
 .../js/stock_traceability_report_widgets.js   |  2 -
 .../xml/stock_traceability_report_line.xml    |  3 +-
 .../stock/views/report_stock_traceability.xml |  4 +-
 4 files changed, 12 insertions(+), 64 deletions(-)

diff --git a/addons/stock/models/stock_traceability.py b/addons/stock/models/stock_traceability.py
index dfd920088a8..a8f5dc5699e 100644
--- a/addons/stock/models/stock_traceability.py
+++ b/addons/stock/models/stock_traceability.py
@@ -70,13 +70,11 @@ class MrpStockReport(models.TransientModel):
         model = False
         model_id = False
         level = 1
-        parent_quant = False
         if kw:
             level = kw['level']
             model = kw['model_name']
             model_id = kw['model_id']
             stream = kw['stream']
-            parent_quant = kw['parent_quant']
         res = []
         if context.get('active_id') and not context.get('model') or context.get('model') == 'stock.production.lot':
             if stream == "downstream":
@@ -86,15 +84,8 @@ class MrpStockReport(models.TransientModel):
                     ('state', '=', 'done'),
                     ('move_id.returned_move_ids', '=', False),
                 ])
-                res += self._lines(line_id, model_id=model_id, model='stock.move.line', level=level, parent_quant=parent_quant,
+                res += self._lines(line_id, model_id=model_id, model='stock.move.line', level=level,
                                   stream=stream, obj_ids=move_ids)
-                quant_ids = self.env['stock.quant'].search([
-                    ('lot_id', '=', context.get('active_id')),
-                    ('quantity', '<', 0),
-                    ('location_id.usage', '=', 'internal'),
-                ])
-                res += self._lines(line_id, model_id=model_id, model='stock.quant', level=level,
-                                   parent_quant=parent_quant, stream=stream, obj_ids=quant_ids)
             else:
                 move_ids = self.env['stock.move.line'].search([
                     ('lot_id', '=', context.get('active_id')),
@@ -102,23 +93,16 @@ class MrpStockReport(models.TransientModel):
                     ('state', '=', 'done'),
                     ('move_id.returned_move_ids', '=', False),
                 ])
-                res += self._lines(line_id, model_id=model_id, model='stock.move.line', level=level, parent_quant=parent_quant,
+                res += self._lines(line_id, model_id=model_id, model='stock.move.line', level=level,
                                   stream=stream, obj_ids=move_ids)
-                quant_ids = self.env['stock.quant'].search([
-                    ('lot_id', '=', context.get('active_id')),
-                    ('quantity', '>', 0),
-                    ('location_id.usage', '=', 'internal'),
-                ])
-                res += self._lines(line_id, model_id=model_id, model='stock.quant', level=level,
-                                   parent_quant=parent_quant, stream=stream, obj_ids=quant_ids)
         elif context.get('active_id') and context.get('model') == 'stock.picking':
             move_ids = self.env['stock.picking'].browse(context['active_id']).move_lines.mapped('move_line_ids').filtered(lambda m: m.lot_id and m.state == 'done')
-            res = self._lines(line_id, model_id=model_id, model='stock.move.line', level=level, parent_quant=parent_quant, stream=stream, obj_ids=move_ids)
+            res = self._lines(line_id, model_id=model_id, model='stock.move.line', level=level, stream=stream, obj_ids=move_ids)
         elif context.get('active_id') and context.get('model') == 'stock.move.line':
             move_line_ids = self.env['stock.move.line'].browse(context.get('active_id'))
-            res = self._lines(line_id, model_id=context.get('active_id'), model=context.get('model'), level=level, parent_quant=parent_quant, stream=stream, obj_ids=move_line_ids)
+            res = self._lines(line_id, model_id=context.get('active_id'), model=context.get('model'), level=level, stream=stream, obj_ids=move_line_ids)
         else:
-            res = self._lines(line_id,  model_id=model_id, model=model, level=level, parent_quant=parent_quant, stream=stream)
+            res = self._lines(line_id,  model_id=model_id, model=model, level=level, stream=stream)
         reverse_sort = True
         if stream == "downstream":
             reverse_sort = False
@@ -179,35 +163,13 @@ class MrpStockReport(models.TransientModel):
                 'location': move_line.location_dest_id.name,
                 'stream': stream,
                 'reference_id': False}]
-        elif model == 'stock.quant':
-            data = [{
-                'level': level,
-                'unfoldable': True,
-                'date': move_line.write_date,
-                'model_id': move_line.id,
-                'parent_id': parent_id,
-                'model': model or 'stock.quant',
-                'product_id': move_line.product_id.display_name,
-                'lot_id': move_line.lot_id.name,
-                'product_qty_uom': str(move_line.quantity) + ' ' + move_line.product_id.uom_id.name,
-                'location': move_line.location_id.name,
-                'stream': stream,
-                'reference_id': False}]
         return data
 
     @api.model
-    def upstream_traceability(self, level, stream=False, line_id=False, model=False, model_obj=False, parent_quant=False):
+    def upstream_traceability(self, level, stream=False, line_id=False, model=False, model_obj=False):
         final_vals =[]
         if model == 'stock.move.line':
             moves = self.get_move_lines_upstream(model_obj)
-        elif model == 'stock.quant':
-            moves = self.env['stock.move.line'].search([
-                ('location_dest_id', '=', model_obj.location_id.id),
-                ('lot_id', '=', model_obj.lot_id.id),
-                ('date', '<=', model_obj.write_date),
-                ('state', '=', 'done'),
-            ])
-            moves |= self.get_move_lines_upstream(moves)
         for move in moves:
             unfoldable = False
             if move.consume_line_ids:
@@ -216,18 +178,10 @@ class MrpStockReport(models.TransientModel):
         return final_vals
 
     @api.model
-    def downstream_traceability(self, level, stream=False, line_id=False, model=False, model_obj=False, parent_quant=False):
+    def downstream_traceability(self, level, stream=False, line_id=False, model=False, model_obj=False):
         final_vals = []
         if model == 'stock.move.line':
             moves = self.get_move_lines_downstream(model_obj)
-        elif model == 'stock.quant':
-            moves = self.env['stock.move.line'].search([
-                ('location_id', '=', model_obj.location_id.id),
-                ('lot_id', '=', model_obj.lot_id.id),
-                ('date', '>=', model_obj.write_date),
-                ('state', '=', 'done'),
-            ])
-            moves |= self.get_move_lines_downstream(moves)
         for move in moves:
             unfoldable = False
             if move.produce_line_ids:
@@ -245,7 +199,6 @@ class MrpStockReport(models.TransientModel):
                 'model_id': data['model_id'],
                 'stream': data['stream'] or 'upstream',
                 'parent_id': data['parent_id'],
-                'parent_quant': data.get('parent_quant', False),
                 'type': 'line',
                 'reference': data.get('reference_id', False),
                 'res_id': data.get('res_id', False),
@@ -262,19 +215,19 @@ class MrpStockReport(models.TransientModel):
         return lines
 
     @api.model
-    def _lines(self, line_id=None, model_id=False, model=False, level=0, parent_quant=False, stream=False, obj_ids=[], **kw):
+    def _lines(self, line_id=None, model_id=False, model=False, level=0, stream=False, obj_ids=[], **kw):
         final_vals = []
         if model and line_id:
             model_obj = self.env[model].browse(model_id)
             if stream == "downstream":
-                final_vals += self.downstream_traceability(level, stream='downstream', line_id=line_id, model=model, model_obj=model_obj, parent_quant=parent_quant)
+                final_vals += self.downstream_traceability(level, stream='downstream', line_id=line_id, model=model, model_obj=model_obj)
                 if model == 'stock.move.line':
                     if model_obj.produce_line_ids:
                         final_vals += self.get_produced_or_consumed_vals(model_obj.produce_line_ids, level, model=model, stream=stream, parent_id=line_id)
                     else:
                         final_vals = self.make_dict_move(level, stream=stream, parent_id=line_id,move_line=model_obj) + final_vals
             else:
-                final_vals += self.upstream_traceability(level, stream='upstream', line_id=line_id, model=model, model_obj=model_obj, parent_quant=parent_quant)
+                final_vals += self.upstream_traceability(level, stream='upstream', line_id=line_id, model=model, model_obj=model_obj)
                 if model == 'stock.move.line':
                     if model_obj.consume_line_ids:
                         final_vals += self.get_produced_or_consumed_vals(model_obj.consume_line_ids, level, model=model, stream=stream, parent_id=line_id)
diff --git a/addons/stock/static/src/js/stock_traceability_report_widgets.js b/addons/stock/static/src/js/stock_traceability_report_widgets.js
index c1abff89a56..ffc0b67cb40 100644
--- a/addons/stock/static/src/js/stock_traceability_report_widgets.js
+++ b/addons/stock/static/src/js/stock_traceability_report_widgets.js
@@ -84,7 +84,6 @@ var ReportWidget = Widget.extend({
         var active_model_id = $CurretElement.data('model_id');
         var row_level = $CurretElement.data('level');
         var stream = $CurretElement.data('stream');
-        var parent_quant = $CurretElement.data('parent_quant');
         var $cursor = $(e.target).parents('tr');
         this._rpc({
                 model: 'stock.traceability.report',
@@ -94,7 +93,6 @@ var ReportWidget = Widget.extend({
                     'model_id': active_model_id,
                     'model_name': active_model_name,
                     'stream': stream || 'upstream',
-                    'parent_quant': parseInt(parent_quant) || false,
                     'level': parseInt(row_level) + 30 || 1
                 },
             })
diff --git a/addons/stock/static/src/xml/stock_traceability_report_line.xml b/addons/stock/static/src/xml/stock_traceability_report_line.xml
index 53c0fd5a111..1a55f7088a1 100644
--- a/addons/stock/static/src/xml/stock_traceability_report_line.xml
+++ b/addons/stock/static/src/xml/stock_traceability_report_line.xml
@@ -13,7 +13,6 @@
     <t t-name="report_mrp_line">
         <t t-set="trclass" t-value="'o_stock_reports_default_style'"/>
         <t t-if="l.model == 'stock.move.line'"><t t-set="trclass" t-value="'o_stock_reports_level0'"/></t>
-        <t t-if="l.model == 'stock.quant'"><t t-set="trclass" t-value="'o_stock_reports_level0'"/></t>
         <t t-set="space_td" t-value="'margin-left: '+ l.level + 'px;'"/>
         <t t-set="domainClass" t-value="'o_stock_reports_domain_line_0'"/>
         <t t-if="l.unfoldable == false">
@@ -25,7 +24,7 @@
             <t t-set="column" t-value="0" />
             <t t-foreach="l.columns" t-as="c">
                 <t t-set="column" t-value="column + 1" />
-                <td style="white-space: nowrap;" t-att-data-id="l.id" t-att-data-stream="l.stream" t-att-data-model="l.model" t-att-data-model_id="l.model_id" t-att-class="tdclass" t-att-data-level="l.level" t-att-data-parent_quant="l.parent_quant">
+                <td style="white-space: nowrap;" t-att-data-id="l.id" t-att-data-stream="l.stream" t-att-data-model="l.model" t-att-data-model_id="l.model_id" t-att-class="tdclass" t-att-data-level="l.level">
                     <t t-if="column == 1">
                         <span t-att-style="space_td" t-att-class="domainClass"></span>
                         <t t-if="l.unfoldable">
diff --git a/addons/stock/views/report_stock_traceability.xml b/addons/stock/views/report_stock_traceability.xml
index 1260264e094..e18bf61d0b9 100644
--- a/addons/stock/views/report_stock_traceability.xml
+++ b/addons/stock/views/report_stock_traceability.xml
@@ -5,7 +5,6 @@
         <t t-foreach="lines" t-as="a">
             <t t-set="trclass" t-value="'o_stock_reports_default_style'"/>
             <t t-if="a.get('model') == 'stock.move.line'"><t t-set="trclass" t-value="'o_stock_reports_level0'"/></t>
-            <t t-if="a.get('model') == 'stock.quant'"><t t-set="trclass" t-value="'o_stock_reports_level0'"/></t>
             <t t-set="domainClass" t-value="'o_stock_reports_domain_line'"/>
             <t t-if="a['unfoldable'] == false">
                 <t t-set="domainClass" t-value="'o_stock_reports_domain_line_1'"/>
@@ -17,7 +16,7 @@
                 <t t-set="column" t-value="0" />
                 <t t-foreach="a['columns']" t-as="c">
                     <t t-set="column" t-value="column + 1" />
-                      <td t-att-data-id="a.get('id')" t-att-data-model="a['model']" t-att-data-model_id="a['model_id']" t-att-data-stream="a['stream']" t-att-class="tdclass" t-att-data-level="a['level']" t-att-data-parent_quant="a['parent_quant']">
+                      <td t-att-data-id="a.get('id')" t-att-data-model="a['model']" t-att-data-model_id="a['model_id']" t-att-data-stream="a['stream']" t-att-class="tdclass" t-att-data-level="a['level']">
                         <t t-if="column == 1">
                             <span t-att-data-active-id="a['id']" t-att-class="a['type'] + ' ' + domainClass"></span>
                             <t t-if="a.get('unfoldable')">
@@ -98,7 +97,6 @@
                             <t t-set="space_td" t-value="'margin-left: '+ str(a['level']) + 'px;'"/>
                             <t t-set="trclass" t-value="'o_stock_reports_default_style'"/>
                             <t t-if="a.get('model') == 'stock.move.line'"><t t-set="trclass" t-value="'o_stock_reports_level0'"/></t>
-                            <t t-if="a.get('model') == 'stock.quant'"><t t-set="trclass" t-value="'o_stock_reports_level0'"/></t>
                             <t t-set="column" t-value="0" />
                             <tr t-att-data-type="a['type']" t-att-data-stream="a['stream']" t-att-data-id="a['id']" t-att-data-model="a['model']" t-att-class="trclass">
                                 <t t-set="tdclass" t-value="''" />

From 90333dc0a46153a82b78c681ae7e8c97d3378b6f Mon Sep 17 00:00:00 2001
From: Haresh Shyara <hsh@odoo.com>
Date: Thu, 23 Nov 2017 16:03:08 +0530
Subject: [PATCH 02/17] [IMP] stock: added and arrange some columns on
 traceability report

---
 addons/stock/models/stock_traceability.py     | 31 ++++++++++++-------
 .../stock/views/report_stock_traceability.xml | 25 ++++++++-------
 2 files changed, 34 insertions(+), 22 deletions(-)

diff --git a/addons/stock/models/stock_traceability.py b/addons/stock/models/stock_traceability.py
index a8f5dc5699e..8aa325329c0 100644
--- a/addons/stock/models/stock_traceability.py
+++ b/addons/stock/models/stock_traceability.py
@@ -140,7 +140,8 @@ class MrpStockReport(models.TransientModel):
             'model':'stock.move.line',
             'product_id': move_line.product_id.display_name,
             'product_qty_uom': str(move_line.product_uom_id._compute_quantity(move_line.qty_done, move_line.product_id.uom_id, rounding_method='HALF-UP')) + ' ' + move_line.product_id.uom_id.name,
-            'location': move_line.location_id.name + ' -> ' + move_line.location_dest_id.name,
+            'location_source': move_line.location_id.name,
+            'location_destination': move_line.location_dest_id.name,
             'reference_id': ref,
             'res_id': res_id,
             'stream': stream,
@@ -148,6 +149,7 @@ class MrpStockReport(models.TransientModel):
         return data
 
     def make_dict_head(self, level, parent_id, model=False, stream=False, move_line=False):
+        res_model, res_id, ref = self.get_links(move_line)
         data = []
         if model == 'stock.move.line':
             data = [{
@@ -160,9 +162,12 @@ class MrpStockReport(models.TransientModel):
                 'product_id': move_line.product_id.display_name,
                 'lot_id': move_line.lot_id.name,
                 'product_qty_uom': str(move_line.product_uom_id._compute_quantity(move_line.qty_done, move_line.product_id.uom_id, rounding_method='HALF-UP')) + ' ' + move_line.product_id.uom_id.name,
-                'location': move_line.location_dest_id.name,
+                'location_source': move_line.location_id.name,
+                'location_destination': move_line.location_dest_id.name,
                 'stream': stream,
-                'reference_id': False}]
+                'reference_id': ref,
+                'res_id': res_id,
+                'res_model': res_model}]
         return data
 
     @api.model
@@ -204,11 +209,13 @@ class MrpStockReport(models.TransientModel):
                 'res_id': data.get('res_id', False),
                 'res_model': data.get('res_model', False),
                 'name': _(data.get('lot_id', False)),
-                'columns': [data.get('reference_id', False) or data.get('product_id', False),
-                            data.get('lot_id', False),
+                'columns': [data.get('reference_id', False),
+                            data.get('product_id', False),
                             data.get('date', False),
-                            data.get('product_qty_uom', 0),
-                            data.get('location', False)],
+                            data.get('lot_id', False),
+                            data.get('location_source', False),
+                            data.get('location_destination', False),
+                            data.get('product_qty_uom', 0)],
                 'level': level,
                 'unfoldable': data['unfoldable'],
             })
@@ -264,11 +271,13 @@ class MrpStockReport(models.TransientModel):
                 'stream': "%s" % (data['stream']),
                 'type': 'line',
                 'name': _(data.get('lot_id')),
-                'columns': [data.get('reference_id') or data.get('product_id'),
-                            data.get('lot_id'),
+                'columns': [data.get('reference_id'),
+                            data.get('product_id'),
                             data.get('date'),
-                            data.get('product_qty_uom', 0),
-                            data.get('location')],
+                            data.get('lot_id'),
+                            data.get('location_source', False),
+                            data.get('location_destination', False),
+                            data.get('product_qty_uom', 0)],
                 'level': data['level'],
                 'unfoldable': data['unfoldable'],
             })
diff --git a/addons/stock/views/report_stock_traceability.xml b/addons/stock/views/report_stock_traceability.xml
index e18bf61d0b9..0deafb2d219 100644
--- a/addons/stock/views/report_stock_traceability.xml
+++ b/addons/stock/views/report_stock_traceability.xml
@@ -46,12 +46,13 @@
                     <table width='100%' class="table-responsive">
                         <thead>
                             <tr class="o_report_header">
-                                <th class="o_report_line_header">PRODUCT</th>
-                                <th class="o_report_line_header">LOT/SERIAL NUMBER</th>
-                                <th class="o_report_line_header">DATE</th>
-                                <th class="o_report_line_header">QUANTITY</th>
-                                <th class="o_report_line_header">LOCATION</th>
-                                <th></th>
+                                <th class="o_report_line_header">Reference</th>
+                                <th class="o_report_line_header">Product</th>
+                                <th class="o_report_line_header">Date</th>
+                                <th class="o_report_line_header">Lot/Serial #</th>
+                                <th class="o_report_line_header">From</th>
+                                <th class="o_report_line_header">To</th>
+                                <th class="o_report_line_header">Quantity</th>
                             </tr>
                         </thead>
                         <tbody>
@@ -84,11 +85,13 @@
                 <table width='100%' class="o_stock_reports_table">
                     <thead>
                         <tr class="o_report_header">
-                            <th class="o_report_line_header">PRODUCT</th>
-                            <th class="o_report_line_header">LOT/SERIAL NUMBER</th>
-                            <th class="o_report_line_header">DATE</th>
-                            <th class="o_report_line_header">QUANTITY</th>
-                            <th class="o_report_line_header">LOCATION</th>
+                            <th class="o_report_line_header">Reference</th>
+                            <th class="o_report_line_header">Product</th>
+                            <th class="o_report_line_header">Date</th>
+                            <th class="o_report_line_header">Lot/Serial #</th>
+                            <th class="o_report_line_header">From</th>
+                            <th class="o_report_line_header">To</th>
+                            <th class="o_report_line_header">Quantity</th>
                         </tr>
                     </thead>
                     <tbody>

From 5fcbc116f1262db8ba9ab02cecdf7dd58508da6c Mon Sep 17 00:00:00 2001
From: Haresh Shyara <hsh@odoo.com>
Date: Thu, 23 Nov 2017 17:56:06 +0530
Subject: [PATCH 03/17] [REM] stock: removed upstream and downstream
 traceability in report

---
 addons/stock/models/stock_traceability.py     | 117 ++++--------------
 .../js/stock_traceability_report_backend.js   |   4 +-
 .../js/stock_traceability_report_widgets.js   |   9 +-
 .../xml/stock_traceability_report_line.xml    |  10 +-
 .../stock/views/report_stock_traceability.xml |   8 +-
 5 files changed, 35 insertions(+), 113 deletions(-)

diff --git a/addons/stock/models/stock_traceability.py b/addons/stock/models/stock_traceability.py
index 8aa325329c0..b8d65304c10 100644
--- a/addons/stock/models/stock_traceability.py
+++ b/addons/stock/models/stock_traceability.py
@@ -20,7 +20,7 @@ class MrpStockReport(models.TransientModel):
     _name = 'stock.traceability.report'
 
     @api.model
-    def get_move_lines_upstream(self, move_lines):
+    def get_move_lines(self, move_lines):
         res = self.env['stock.move.line']
         for move_line in move_lines:
             # if MTO
@@ -38,35 +38,12 @@ class MrpStockReport(models.TransientModel):
                         ('date', '<', move_line.date),
                     ])
         if res:
-            res |= self.get_move_lines_upstream(res)
-        return res
-
-    @api.model
-    def get_move_lines_downstream(self, move_lines):
-        res = self.env['stock.move.line']
-        for move_line in move_lines:
-            # if MTO
-            if move_line.move_id.move_dest_ids:
-                res |= move_line.move_id.move_dest_ids.mapped('move_line_ids').filtered(
-                    lambda m: m.lot_id.id == move_line.lot_id.id)
-            # if MTS
-            else:
-                if move_line.location_dest_id.usage == 'internal':
-                    res |= self.env['stock.move.line'].search([
-                        ('product_id', '=', move_line.product_id.id),
-                        ('lot_id', '=', move_line.lot_id.id),
-                        ('location_id', '=', move_line.location_dest_id.id),
-                        ('id', '!=', move_line.id),
-                        ('date', '>', move_line.date),
-                    ])
-        if res:
-            res |= self.get_move_lines_downstream(res)
+            res |= self.get_move_lines(res)
         return res
 
     @api.model
     def get_lines(self, line_id=None, **kw):
         context = dict(self.env.context)
-        stream = context.get('ttype')
         model = False
         model_id = False
         level = 1
@@ -74,39 +51,23 @@ class MrpStockReport(models.TransientModel):
             level = kw['level']
             model = kw['model_name']
             model_id = kw['model_id']
-            stream = kw['stream']
         res = []
         if context.get('active_id') and not context.get('model') or context.get('model') == 'stock.production.lot':
-            if stream == "downstream":
-                move_ids = self.env['stock.move.line'].search([
-                    ('lot_id', '=', context.get('active_id')),
-                    ('location_id.usage', '!=', 'internal'),
-                    ('state', '=', 'done'),
-                    ('move_id.returned_move_ids', '=', False),
-                ])
-                res += self._lines(line_id, model_id=model_id, model='stock.move.line', level=level,
-                                  stream=stream, obj_ids=move_ids)
-            else:
-                move_ids = self.env['stock.move.line'].search([
-                    ('lot_id', '=', context.get('active_id')),
-                    ('location_dest_id.usage', '!=', 'internal'),
-                    ('state', '=', 'done'),
-                    ('move_id.returned_move_ids', '=', False),
-                ])
-                res += self._lines(line_id, model_id=model_id, model='stock.move.line', level=level,
-                                  stream=stream, obj_ids=move_ids)
+            move_ids = self.env['stock.move.line'].search([
+                ('lot_id', '=', context.get('active_id')),
+                ('state', '=', 'done'),
+                ('move_id.returned_move_ids', '=', False),
+            ])
+            res += self._lines(line_id, model_id=model_id, model='stock.move.line', level=level, obj_ids=move_ids)
         elif context.get('active_id') and context.get('model') == 'stock.picking':
             move_ids = self.env['stock.picking'].browse(context['active_id']).move_lines.mapped('move_line_ids').filtered(lambda m: m.lot_id and m.state == 'done')
-            res = self._lines(line_id, model_id=model_id, model='stock.move.line', level=level, stream=stream, obj_ids=move_ids)
+            res = self._lines(line_id, model_id=model_id, model='stock.move.line', level=level, obj_ids=move_ids)
         elif context.get('active_id') and context.get('model') == 'stock.move.line':
             move_line_ids = self.env['stock.move.line'].browse(context.get('active_id'))
-            res = self._lines(line_id, model_id=context.get('active_id'), model=context.get('model'), level=level, stream=stream, obj_ids=move_line_ids)
+            res = self._lines(line_id, model_id=context.get('active_id'), model=context.get('model'), level=level, obj_ids=move_line_ids)
         else:
-            res = self._lines(line_id,  model_id=model_id, model=model, level=level, stream=stream)
-        reverse_sort = True
-        if stream == "downstream":
-            reverse_sort = False
-        final_vals = sorted(res, key=lambda v: v['date'], reverse=reverse_sort)
+            res = self._lines(line_id,  model_id=model_id, model=model, level=level)
+        final_vals = sorted(res, key=lambda v: v['date'], reverse=True)
         lines = self.final_vals_to_lines(final_vals, level)
         return lines
 
@@ -129,7 +90,7 @@ class MrpStockReport(models.TransientModel):
             ref = move_line.move_id.scrap_ids[0].name
         return res_model, res_id, ref
 
-    def make_dict_move(self, level, parent_id, move_line, stream=False, unfoldable=False):
+    def make_dict_move(self, level, parent_id, move_line, unfoldable=False):
         res_model, res_id, ref = self.get_links(move_line)
         data = [{
             'level': level,
@@ -144,11 +105,10 @@ class MrpStockReport(models.TransientModel):
             'location_destination': move_line.location_dest_id.name,
             'reference_id': ref,
             'res_id': res_id,
-            'stream': stream,
             'res_model': res_model}]
         return data
 
-    def make_dict_head(self, level, parent_id, model=False, stream=False, move_line=False):
+    def make_dict_head(self, level, parent_id, model=False, move_line=False):
         res_model, res_id, ref = self.get_links(move_line)
         data = []
         if model == 'stock.move.line':
@@ -164,34 +124,21 @@ class MrpStockReport(models.TransientModel):
                 'product_qty_uom': str(move_line.product_uom_id._compute_quantity(move_line.qty_done, move_line.product_id.uom_id, rounding_method='HALF-UP')) + ' ' + move_line.product_id.uom_id.name,
                 'location_source': move_line.location_id.name,
                 'location_destination': move_line.location_dest_id.name,
-                'stream': stream,
                 'reference_id': ref,
                 'res_id': res_id,
                 'res_model': res_model}]
         return data
 
     @api.model
-    def upstream_traceability(self, level, stream=False, line_id=False, model=False, model_obj=False):
+    def get_traceability(self, level, line_id=False, model=False, model_obj=False):
         final_vals =[]
         if model == 'stock.move.line':
-            moves = self.get_move_lines_upstream(model_obj)
+            moves = self.get_move_lines(model_obj)
         for move in moves:
             unfoldable = False
             if move.consume_line_ids:
                 unfoldable = True
-            final_vals += self.make_dict_move(level, stream=stream, parent_id=line_id, move_line=move, unfoldable=unfoldable)
-        return final_vals
-
-    @api.model
-    def downstream_traceability(self, level, stream=False, line_id=False, model=False, model_obj=False):
-        final_vals = []
-        if model == 'stock.move.line':
-            moves = self.get_move_lines_downstream(model_obj)
-        for move in moves:
-            unfoldable = False
-            if move.produce_line_ids:
-                unfoldable = True
-            final_vals += self.make_dict_move(level, stream=stream, parent_id=line_id, move_line=move, unfoldable=unfoldable)
+            final_vals += self.make_dict_move(level, parent_id=line_id, move_line=move, unfoldable=unfoldable)
         return final_vals
 
     @api.model
@@ -202,7 +149,6 @@ class MrpStockReport(models.TransientModel):
                 'id': autoIncrement(),
                 'model': data['model'],
                 'model_id': data['model_id'],
-                'stream': data['stream'] or 'upstream',
                 'parent_id': data['parent_id'],
                 'type': 'line',
                 'reference': data.get('reference_id', False),
@@ -222,34 +168,26 @@ class MrpStockReport(models.TransientModel):
         return lines
 
     @api.model
-    def _lines(self, line_id=None, model_id=False, model=False, level=0, stream=False, obj_ids=[], **kw):
+    def _lines(self, line_id=None, model_id=False, model=False, level=0, obj_ids=[], **kw):
         final_vals = []
         if model and line_id:
             model_obj = self.env[model].browse(model_id)
-            if stream == "downstream":
-                final_vals += self.downstream_traceability(level, stream='downstream', line_id=line_id, model=model, model_obj=model_obj)
-                if model == 'stock.move.line':
-                    if model_obj.produce_line_ids:
-                        final_vals += self.get_produced_or_consumed_vals(model_obj.produce_line_ids, level, model=model, stream=stream, parent_id=line_id)
-                    else:
-                        final_vals = self.make_dict_move(level, stream=stream, parent_id=line_id,move_line=model_obj) + final_vals
-            else:
-                final_vals += self.upstream_traceability(level, stream='upstream', line_id=line_id, model=model, model_obj=model_obj)
-                if model == 'stock.move.line':
-                    if model_obj.consume_line_ids:
-                        final_vals += self.get_produced_or_consumed_vals(model_obj.consume_line_ids, level, model=model, stream=stream, parent_id=line_id)
-                    else:
-                        final_vals = self.make_dict_move(level, stream=stream, parent_id=line_id, move_line=model_obj) + final_vals
+            final_vals += self.get_traceability(level, line_id=line_id, model=model, model_obj=model_obj)
+            if model == 'stock.move.line':
+                if model_obj.consume_line_ids:
+                    final_vals += self.get_produced_or_consumed_vals(model_obj.consume_line_ids, level, model=model, parent_id=line_id)
+                else:
+                    final_vals = self.make_dict_move(level, parent_id=line_id, move_line=model_obj) + final_vals
         else:
             for move_line in obj_ids:
-                final_vals += self.make_dict_head(level, stream=stream, parent_id=line_id, model=model or 'stock.pack.operation', move_line=move_line)
+                final_vals += self.make_dict_head(level, parent_id=line_id, model=model or 'stock.pack.operation', move_line=move_line)
         return final_vals
 
     @api.model
-    def get_produced_or_consumed_vals(self, move_lines, level, model, stream, parent_id):
+    def get_produced_or_consumed_vals(self, move_lines, level, model, parent_id):
         final_vals = []
         for line in move_lines:
-            final_vals += self.make_dict_head(level, model=model, stream=stream, parent_id=parent_id, move_line=line)
+            final_vals += self.make_dict_head(level, model=model, parent_id=parent_id, move_line=line)
         return final_vals
 
     def get_pdf_lines(self, line_data=[]):
@@ -268,7 +206,6 @@ class MrpStockReport(models.TransientModel):
                 'model': data['model'],
                 'model_id': data['model_id'],
                 'parent_id': data['parent_id'],
-                'stream': "%s" % (data['stream']),
                 'type': 'line',
                 'name': _(data.get('lot_id')),
                 'columns': [data.get('reference_id'),
diff --git a/addons/stock/static/src/js/stock_traceability_report_backend.js b/addons/stock/static/src/js/stock_traceability_report_backend.js
index d342742122c..962b0e57b1c 100644
--- a/addons/stock/static/src/js/stock_traceability_report_backend.js
+++ b/addons/stock/static/src/js/stock_traceability_report_backend.js
@@ -37,9 +37,7 @@ var stock_report_generic = Widget.extend(ControlPanelMixin, {
         }
         def.then(function () {
             self.report_widget.$el.html(self.html);
-            if(self.given_context['ttype'] == 'downstream'){
-                self.report_widget.$el.find('.o_report_heading').html('<h1>Downstream Traceability</h1>');
-            }
+            self.report_widget.$el.find('.o_report_heading').html('<h1>Traceability Report</h1>')
         });
     },
     start: function() {
diff --git a/addons/stock/static/src/js/stock_traceability_report_widgets.js b/addons/stock/static/src/js/stock_traceability_report_widgets.js
index ffc0b67cb40..031de5a5c99 100644
--- a/addons/stock/static/src/js/stock_traceability_report_widgets.js
+++ b/addons/stock/static/src/js/stock_traceability_report_widgets.js
@@ -32,12 +32,8 @@ var ReportWidget = Widget.extend({
         });
     },
     updownStream: function(e) {
-        var stream = $(e.target).parent().data('stream');
         var $el = $(e.target).parents('tr');
-        var string = "Upstream Traceability"
-        if (stream == 'downstream') {
-            string = "Downstream Traceability"
-        }
+        var string = "Traceability Report"
         this.do_action({
             type: "ir.actions.client",
             tag: 'stock_report_generic',
@@ -45,7 +41,6 @@ var ReportWidget = Widget.extend({
             context: {
                 active_id : $el.data('model_id'),
                 active_model : $el.data('model'),
-                ttype: stream || false,
                 url: '/stock/output_format/stock/active_id'
             },
         });
@@ -83,7 +78,6 @@ var ReportWidget = Widget.extend({
         var active_model_name = $CurretElement.data('model');
         var active_model_id = $CurretElement.data('model_id');
         var row_level = $CurretElement.data('level');
-        var stream = $CurretElement.data('stream');
         var $cursor = $(e.target).parents('tr');
         this._rpc({
                 model: 'stock.traceability.report',
@@ -92,7 +86,6 @@ var ReportWidget = Widget.extend({
                 kwargs: {
                     'model_id': active_model_id,
                     'model_name': active_model_name,
-                    'stream': stream || 'upstream',
                     'level': parseInt(row_level) + 30 || 1
                 },
             })
diff --git a/addons/stock/static/src/xml/stock_traceability_report_line.xml b/addons/stock/static/src/xml/stock_traceability_report_line.xml
index 1a55f7088a1..845fb4ddf84 100644
--- a/addons/stock/static/src/xml/stock_traceability_report_line.xml
+++ b/addons/stock/static/src/xml/stock_traceability_report_line.xml
@@ -19,12 +19,12 @@
             <t t-set="domainClass" t-value="'o_stock_reports_domain_line_1'"/>
         </t>
 
-        <tr t-att-data-type="l.type" t-att-data-unfold="l.unfoldable" t-att-data-parent_id="l.parent_id" t-att-data-id="l.id" t-att-data-stream="'l.stream'" t-att-data-model_id="l.model_id" t-att-data-model="l.model" t-att-class="trclass">
+        <tr t-att-data-type="l.type" t-att-data-unfold="l.unfoldable" t-att-data-parent_id="l.parent_id" t-att-data-id="l.id"  t-att-data-model_id="l.model_id" t-att-data-model="l.model" t-att-class="trclass">
             <t t-if="l.unfoldable == true"><t t-set="tdclass" t-value="'o_stock_reports_unfoldable'" /></t>
             <t t-set="column" t-value="0" />
             <t t-foreach="l.columns" t-as="c">
                 <t t-set="column" t-value="column + 1" />
-                <td style="white-space: nowrap;" t-att-data-id="l.id" t-att-data-stream="l.stream" t-att-data-model="l.model" t-att-data-model_id="l.model_id" t-att-class="tdclass" t-att-data-level="l.level">
+                <td style="white-space: nowrap;" t-att-data-id="l.id" t-att-data-model="l.model" t-att-data-model_id="l.model_id" t-att-class="tdclass" t-att-data-level="l.level">
                     <t t-if="column == 1">
                         <span t-att-style="space_td" t-att-class="domainClass"></span>
                         <t t-if="l.unfoldable">
@@ -71,12 +71,6 @@
                     </t>
                 </td>
             </t>
-            <td>
-                <t t-if="l.model == 'stock.move.line'">
-                    <span t-if="l.stream == 'downstream'" class="o_stock_reports_stream text-muted" data-stream="upstream" title="Upstream Traceability"><i class="fa fa-arrow-up"></i></span>
-                    <span t-if="l.stream == 'upstream'" class="o_stock_reports_stream" data-stream="downstream" title="Downstream Traceability"><i class="fa fa-arrow-down"></i></span>
-                </t>
-            </td>
         </tr>
     </t>
 
diff --git a/addons/stock/views/report_stock_traceability.xml b/addons/stock/views/report_stock_traceability.xml
index 0deafb2d219..02a549efbfa 100644
--- a/addons/stock/views/report_stock_traceability.xml
+++ b/addons/stock/views/report_stock_traceability.xml
@@ -10,13 +10,13 @@
                 <t t-set="domainClass" t-value="'o_stock_reports_domain_line_1'"/>
             </t>
             <t t-set="column" t-value="0" />
-            <tr t-att-data-type="a['type']" t-att-data-stream="a['stream']" t-att-data-unfold="a['unfoldable']" t-att-data-parent_id="a['parent_id']" t-att-data-id="a['id']" t-att-data-model_id="a['model_id']" t-att-data-model="a['model']" t-att-class="trclass">
+            <tr t-att-data-type="a['type']" t-att-data-unfold="a['unfoldable']" t-att-data-parent_id="a['parent_id']" t-att-data-id="a['id']" t-att-data-model_id="a['model_id']" t-att-data-model="a['model']" t-att-class="trclass">
                 <t t-set="tdclass" t-value="''" />
                 <t t-if="a.get('unfoldable')"><t t-set="tdclass" t-value="'o_stock_reports_unfoldable'" /></t>
                 <t t-set="column" t-value="0" />
                 <t t-foreach="a['columns']" t-as="c">
                     <t t-set="column" t-value="column + 1" />
-                      <td t-att-data-id="a.get('id')" t-att-data-model="a['model']" t-att-data-model_id="a['model_id']" t-att-data-stream="a['stream']" t-att-class="tdclass" t-att-data-level="a['level']">
+                      <td t-att-data-id="a.get('id')" t-att-data-model="a['model']" t-att-data-model_id="a['model_id']" t-att-class="tdclass" t-att-data-level="a['level']">
                         <t t-if="column == 1">
                             <span t-att-data-active-id="a['id']" t-att-class="a['type'] + ' ' + domainClass"></span>
                             <t t-if="a.get('unfoldable')">
@@ -36,7 +36,7 @@
 
     <template id="report_stock_inventory">
         <div class="container o_stock_reports_page o_stock_reports_no_print">
-            <span t-if="lines" class="o_report_heading text-left"><h1>Upstream Traceability</h1></span>
+            <span t-if="lines" class="o_report_heading text-left"><h1>Traceability Report</h1></span>
             <span><t t-esc="context"/></span>
             <div class="o_stock_reports_table">
                 <t t-if="not lines">
@@ -101,7 +101,7 @@
                             <t t-set="trclass" t-value="'o_stock_reports_default_style'"/>
                             <t t-if="a.get('model') == 'stock.move.line'"><t t-set="trclass" t-value="'o_stock_reports_level0'"/></t>
                             <t t-set="column" t-value="0" />
-                            <tr t-att-data-type="a['type']" t-att-data-stream="a['stream']" t-att-data-id="a['id']" t-att-data-model="a['model']" t-att-class="trclass">
+                            <tr t-att-data-type="a['type']" t-att-data-id="a['id']" t-att-data-model="a['model']" t-att-class="trclass">
                                 <t t-set="tdclass" t-value="''" />
                                 <t t-if="a.get('unfoldable')"><t t-set="tdclass" t-value="'o_stock_reports_unfoldable'" /></t>
                                 <t t-set="column" t-value="0" />

From acd0254d48d9550efa9094b694da0cf61d4da35c Mon Sep 17 00:00:00 2001
From: Haresh Shyara <hsh@odoo.com>
Date: Thu, 23 Nov 2017 18:51:00 +0530
Subject: [PATCH 04/17] [IMP] stock: clickable reference on traceability report

- make all references clickable for all model and remove unused code.
---
 .../xml/stock_traceability_report_line.xml    | 27 +------------------
 .../stock/views/report_stock_traceability.xml | 13 ++++++---
 2 files changed, 11 insertions(+), 29 deletions(-)

diff --git a/addons/stock/static/src/xml/stock_traceability_report_line.xml b/addons/stock/static/src/xml/stock_traceability_report_line.xml
index 845fb4ddf84..697dd94271b 100644
--- a/addons/stock/static/src/xml/stock_traceability_report_line.xml
+++ b/addons/stock/static/src/xml/stock_traceability_report_line.xml
@@ -31,32 +31,7 @@
                             <span class="o_stock_reports_unfoldable o_stock_reports_caret_icon"><i class="fa fa-fw fa-caret-right"></i></span>
                         </t>
                     </t>
-                    <t t-if="l.res_model == 'mrp.production' and l.reference == c">
-                        <span t-if="c">
-                            <a t-att-data-active-id="l.res_id" t-att-data-res-model="l.res_model" class="o_stock_reports_web_action"><t t-raw="c" /></a>
-                        </span>
-                    </t>
-                    <t t-if="l.res_model == 'mrp.unbuild' and l.reference == c">
-                        <span t-if="c">
-                            <a t-att-data-active-id="l.res_id" t-att-data-res-model="l.res_model" class="o_stock_reports_web_action"><t t-raw="c" /></a>
-                        </span>
-                    </t>
-                    <t t-if="l.res_model == 'repair.order' and l.reference == c">
-                        <span t-if="c">
-                            <a t-att-data-active-id="l.res_id" t-att-data-res-model="l.res_model" class="o_stock_reports_web_action"><t t-raw="c" /></a>
-                        </span>
-                    </t>
-                    <t t-if="l.res_model == 'stock.scrap' and l.reference == c">
-                        <span t-if="c">
-                            <a t-att-data-active-id="l.res_id" t-att-data-res-model="l.res_model" class="o_stock_reports_web_action"><t t-raw="c" /></a>
-                        </span>
-                    </t>
-                    <t t-if="l.res_model == 'stock.inventory' and l.reference == c">
-                        <span t-if="c">
-                            <a t-att-data-active-id="l.res_id" t-att-data-res-model="l.res_model" class="o_stock_reports_web_action"><t t-raw="c" /></a>
-                        </span>
-                    </t>
-                    <t t-if="l.res_model == 'stock.picking' and l.reference == c">
+                    <t t-if="l.reference == c">
                         <span t-if="c">
                             <a t-att-data-active-id="l.res_id" t-att-data-res-model="l.res_model" class="o_stock_reports_web_action"><t t-raw="c" /></a>
                         </span>
diff --git a/addons/stock/views/report_stock_traceability.xml b/addons/stock/views/report_stock_traceability.xml
index 02a549efbfa..6999a1c96fc 100644
--- a/addons/stock/views/report_stock_traceability.xml
+++ b/addons/stock/views/report_stock_traceability.xml
@@ -23,9 +23,16 @@
                                 <span t-att-data-id="a['id']" class="o_stock_reports_unfoldable o_stock_reports_caret_icon"><i class="fa fa-fw fa-caret-right"></i></span>
                             </t>
                         </t>
-                        <span>
-                            <t t-raw="c" />
-                        </span>
+                        <t t-if="a['reference'] == c">
+                            <span>
+                                <a t-att-data-active-id="a['res_id']" t-att-data-res-model="a['res_model']" class="o_stock_reports_web_action"><t t-raw="c" /></a>
+                            </span>
+                        </t>
+                        <t t-else="">
+                            <span>
+                                <t t-raw="c"/>
+                            </span>
+                        </t>
                     </td>
                 </t>
             <td>

From 387c441f7c41c029bd732f864388375072c5b4c7 Mon Sep 17 00:00:00 2001
From: Haresh Shyara <hsh@odoo.com>
Date: Fri, 12 Jan 2018 12:54:43 +0530
Subject: [PATCH 05/17] [IMP] stock, mrp, repair: get linked consumed or
 produced lines for this operation

- When unfold down MO, Repair Order, Unbuild Order to display produced or consumed materials even product is trackable or not.
- Normal products(not trackable) are directly displayed with source and destination not foldable.
- Unfoldable line has no caret icon to unfold, so move it to margin-left 15px to make parellel.
- Invisible source and destination location on head lines if product trackable.
---
 addons/mrp/models/stock_traceability.py       |  9 +++++
 addons/repair/models/stock_traceability.py    |  9 +++++
 addons/stock/models/stock_traceability.py     | 33 +++++++++++--------
 .../src/less/stock_traceability_report.less   |  3 ++
 .../xml/stock_traceability_report_line.xml    |  3 +-
 .../stock/views/report_stock_traceability.xml |  4 ++-
 6 files changed, 46 insertions(+), 15 deletions(-)

diff --git a/addons/mrp/models/stock_traceability.py b/addons/mrp/models/stock_traceability.py
index 2d5c0aae6b7..48157da82c9 100644
--- a/addons/mrp/models/stock_traceability.py
+++ b/addons/mrp/models/stock_traceability.py
@@ -19,3 +19,12 @@ class MrpStockReport(models.TransientModel):
             res_id = move_line.move_id.consume_unbuild_id.id
             ref = move_line.move_id.consume_unbuild_id.name
         return res_model, res_id, ref
+
+    @api.model
+    def _get_linked_move_lines(self, move_line):
+        move_lines, is_used = super(MrpStockReport, self)._get_linked_move_lines(move_line)
+        if not move_lines:
+            move_lines = (move_line.move_id.consume_unbuild_id and move_line.produce_line_ids) or (move_line.move_id.production_id and move_line.consume_line_ids)
+        if not is_used:
+            is_used = (move_line.move_id.unbuild_id and move_line.consume_line_ids) or (move_line.move_id.raw_material_production_id and move_line.produce_line_ids)
+        return move_lines, is_used
diff --git a/addons/repair/models/stock_traceability.py b/addons/repair/models/stock_traceability.py
index f9c9846e42e..cc912e2ea29 100644
--- a/addons/repair/models/stock_traceability.py
+++ b/addons/repair/models/stock_traceability.py
@@ -11,3 +11,12 @@ class MrpStockReport(models.TransientModel):
             res_id = move_line.move_id.repair_id.id
             ref = move_line.move_id.repair_id.name
         return res_model, res_id, ref
+
+    @api.model
+    def _get_linked_move_lines(self, move_line):
+        move_lines, is_used = super(MrpStockReport, self)._get_linked_move_lines(move_line)
+        if not move_lines:
+            move_lines = move_line.move_id.repair_id and move_line.consume_line_ids
+        if not is_used:
+            is_used = move_line.move_id.repair_id and move_line.produce_line_ids
+        return move_lines, is_used
diff --git a/addons/stock/models/stock_traceability.py b/addons/stock/models/stock_traceability.py
index b8d65304c10..ca772dd546f 100644
--- a/addons/stock/models/stock_traceability.py
+++ b/addons/stock/models/stock_traceability.py
@@ -100,6 +100,7 @@ class MrpStockReport(models.TransientModel):
             'model_id': move_line.id,
             'model':'stock.move.line',
             'product_id': move_line.product_id.display_name,
+            'lot_id': move_line.lot_id.name,
             'product_qty_uom': str(move_line.product_uom_id._compute_quantity(move_line.qty_done, move_line.product_id.uom_id, rounding_method='HALF-UP')) + ' ' + move_line.product_id.uom_id.name,
             'location_source': move_line.location_id.name,
             'location_destination': move_line.location_dest_id.name,
@@ -114,7 +115,7 @@ class MrpStockReport(models.TransientModel):
         if model == 'stock.move.line':
             data = [{
                 'level': level,
-                'unfoldable': True,
+                'unfoldable': False if not move_line.lot_id else True,
                 'date': move_line.move_id.date,
                 'model_id': move_line.id,
                 'parent_id': parent_id,
@@ -122,8 +123,8 @@ class MrpStockReport(models.TransientModel):
                 'product_id': move_line.product_id.display_name,
                 'lot_id': move_line.lot_id.name,
                 'product_qty_uom': str(move_line.product_uom_id._compute_quantity(move_line.qty_done, move_line.product_id.uom_id, rounding_method='HALF-UP')) + ' ' + move_line.product_id.uom_id.name,
-                'location_source': move_line.location_id.name,
-                'location_destination': move_line.location_dest_id.name,
+                'location_source': move_line.location_id.name if not move_line.lot_id else False,
+                'location_destination': move_line.location_dest_id.name if not move_line.lot_id else False,
                 'reference_id': ref,
                 'res_id': res_id,
                 'res_model': res_model}]
@@ -131,7 +132,7 @@ class MrpStockReport(models.TransientModel):
 
     @api.model
     def get_traceability(self, level, line_id=False, model=False, model_obj=False):
-        final_vals =[]
+        final_vals = []
         if model == 'stock.move.line':
             moves = self.get_move_lines(model_obj)
         for move in moves:
@@ -167,20 +168,25 @@ class MrpStockReport(models.TransientModel):
             })
         return lines
 
+    def _get_linked_move_lines(self, move_line):
+        """ This method will return the consumed line or produced line for this operation."""
+        return False, False
+
     @api.model
     def _lines(self, line_id=None, model_id=False, model=False, level=0, obj_ids=[], **kw):
         final_vals = []
         if model and line_id:
-            model_obj = self.env[model].browse(model_id)
-            final_vals += self.get_traceability(level, line_id=line_id, model=model, model_obj=model_obj)
-            if model == 'stock.move.line':
-                if model_obj.consume_line_ids:
-                    final_vals += self.get_produced_or_consumed_vals(model_obj.consume_line_ids, level, model=model, parent_id=line_id)
-                else:
-                    final_vals = self.make_dict_move(level, parent_id=line_id, move_line=model_obj) + final_vals
+            move_line = self.env[model].browse(model_id)
+            move_lines, dummy = self._get_linked_move_lines(move_line)
+            if move_lines:
+                final_vals += self.get_produced_or_consumed_vals(move_lines, level, model=model, parent_id=line_id)
+            else:
+                final_vals += self.get_traceability(level, line_id=line_id, model=model, model_obj=move_line)
+                final_vals = self.make_dict_move(level, parent_id=line_id, move_line=move_line) + final_vals
         else:
             for move_line in obj_ids:
-                final_vals += self.make_dict_head(level, parent_id=line_id, model=model or 'stock.pack.operation', move_line=move_line)
+                unfoldable = bool(move_line.produce_line_ids or move_line.consume_line_ids)
+                final_vals += self.make_dict_move(level, parent_id=line_id, move_line=move_line, unfoldable=unfoldable)
         return final_vals
 
     @api.model
@@ -195,7 +201,8 @@ class MrpStockReport(models.TransientModel):
         lines = []
         for line in line_data:
             model = self.env[line['model_name']].browse(line['model_id'])
-            if line.get('unfoldable'):
+            dummy, move_line = self._get_linked_move_lines(model)
+            if line.get('unfoldable') and move_line:
                     final_vals += self.make_dict_head(line['level'], model=line['model_name'], parent_id=line['id'], move_line=model)
             else:
                 if line['model_name'] == 'stock.move.line':
diff --git a/addons/stock/static/src/less/stock_traceability_report.less b/addons/stock/static/src/less/stock_traceability_report.less
index 2950ec1361f..2454dd1ad6f 100644
--- a/addons/stock/static/src/less/stock_traceability_report.less
+++ b/addons/stock/static/src/less/stock_traceability_report.less
@@ -43,6 +43,9 @@
     .o_stock_reports_unfolded {
         display: inline-block;
     }
+    .o_stock_reports_nofoldable {
+        margin-left: 17px;
+    }
     table > tbody > tr > td ~ td > span {
         margin-left: 10px;
     }
diff --git a/addons/stock/static/src/xml/stock_traceability_report_line.xml b/addons/stock/static/src/xml/stock_traceability_report_line.xml
index 697dd94271b..ff816ee5a9d 100644
--- a/addons/stock/static/src/xml/stock_traceability_report_line.xml
+++ b/addons/stock/static/src/xml/stock_traceability_report_line.xml
@@ -16,6 +16,7 @@
         <t t-set="space_td" t-value="'margin-left: '+ l.level + 'px;'"/>
         <t t-set="domainClass" t-value="'o_stock_reports_domain_line_0'"/>
         <t t-if="l.unfoldable == false">
+            <t t-set="spanclass" t-value="'o_stock_reports_nofoldable'" />
             <t t-set="domainClass" t-value="'o_stock_reports_domain_line_1'"/>
         </t>
 
@@ -32,7 +33,7 @@
                         </t>
                     </t>
                     <t t-if="l.reference == c">
-                        <span t-if="c">
+                        <span t-if="c" t-att-class="spanclass">
                             <a t-att-data-active-id="l.res_id" t-att-data-res-model="l.res_model" class="o_stock_reports_web_action"><t t-raw="c" /></a>
                         </span>
                     </t>
diff --git a/addons/stock/views/report_stock_traceability.xml b/addons/stock/views/report_stock_traceability.xml
index 6999a1c96fc..50cf22d9881 100644
--- a/addons/stock/views/report_stock_traceability.xml
+++ b/addons/stock/views/report_stock_traceability.xml
@@ -12,7 +12,9 @@
             <t t-set="column" t-value="0" />
             <tr t-att-data-type="a['type']" t-att-data-unfold="a['unfoldable']" t-att-data-parent_id="a['parent_id']" t-att-data-id="a['id']" t-att-data-model_id="a['model_id']" t-att-data-model="a['model']" t-att-class="trclass">
                 <t t-set="tdclass" t-value="''" />
+                <t t-set="spanclass" t-value="''" />
                 <t t-if="a.get('unfoldable')"><t t-set="tdclass" t-value="'o_stock_reports_unfoldable'" /></t>
+                <t t-if="not a.get('unfoldable')"><t t-set="spanclass" t-value="'o_stock_reports_nofoldable'" /></t>
                 <t t-set="column" t-value="0" />
                 <t t-foreach="a['columns']" t-as="c">
                     <t t-set="column" t-value="column + 1" />
@@ -24,7 +26,7 @@
                             </t>
                         </t>
                         <t t-if="a['reference'] == c">
-                            <span>
+                            <span t-if="c" t-att-class="spanclass">
                                 <a t-att-data-active-id="a['res_id']" t-att-data-res-model="a['res_model']" class="o_stock_reports_web_action"><t t-raw="c" /></a>
                             </span>
                         </t>

From 8de1e54f65f6476d451af9abb197f79a276912a9 Mon Sep 17 00:00:00 2001
From: Haresh Shyara <hsh@odoo.com>
Date: Fri, 12 Jan 2018 15:29:40 +0530
Subject: [PATCH 06/17] [IMP] stock: added button on components to switch
 report on finished product

---
 addons/stock/models/stock_traceability.py     | 18 ++++++++++--
 .../js/stock_traceability_report_backend.js   |  7 +++++
 .../js/stock_traceability_report_widgets.js   | 29 ++++++++++++-------
 .../xml/stock_traceability_report_line.xml    |  2 +-
 .../stock/views/report_stock_traceability.xml |  7 +++--
 5 files changed, 48 insertions(+), 15 deletions(-)

diff --git a/addons/stock/models/stock_traceability.py b/addons/stock/models/stock_traceability.py
index ca772dd546f..d60b46e89c0 100644
--- a/addons/stock/models/stock_traceability.py
+++ b/addons/stock/models/stock_traceability.py
@@ -52,6 +52,7 @@ class MrpStockReport(models.TransientModel):
             model = kw['model_name']
             model_id = kw['model_id']
         res = []
+        move_line = self.env['stock.move.line']
         if context.get('active_id') and not context.get('model') or context.get('model') == 'stock.production.lot':
             move_ids = self.env['stock.move.line'].search([
                 ('lot_id', '=', context.get('active_id')),
@@ -63,8 +64,16 @@ class MrpStockReport(models.TransientModel):
             move_ids = self.env['stock.picking'].browse(context['active_id']).move_lines.mapped('move_line_ids').filtered(lambda m: m.lot_id and m.state == 'done')
             res = self._lines(line_id, model_id=model_id, model='stock.move.line', level=level, obj_ids=move_ids)
         elif context.get('active_id') and context.get('model') == 'stock.move.line':
-            move_line_ids = self.env['stock.move.line'].browse(context.get('active_id'))
-            res = self._lines(line_id, model_id=context.get('active_id'), model=context.get('model'), level=level, obj_ids=move_line_ids)
+            move_ids = self.env['stock.move.line'].search([
+                ('lot_id', '=', context.get('lot_id')),
+                ('state', '=', 'done'),
+                ('move_id.returned_move_ids', '=', False),
+            ])
+            for line in move_ids:
+                dummy, is_used = self._get_linked_move_lines(line)
+                if is_used:
+                    move_line |= is_used
+            res = self._lines(line_id, model_id=context.get('active_id'), model=context.get('model'), level=level, obj_ids=move_line)
         else:
             res = self._lines(line_id,  model_id=model_id, model=model, level=level)
         final_vals = sorted(res, key=lambda v: v['date'], reverse=True)
@@ -92,11 +101,13 @@ class MrpStockReport(models.TransientModel):
 
     def make_dict_move(self, level, parent_id, move_line, unfoldable=False):
         res_model, res_id, ref = self.get_links(move_line)
+        dummy, is_used = self._get_linked_move_lines(move_line)
         data = [{
             'level': level,
             'unfoldable': unfoldable,
             'date': move_line.move_id.date,
             'parent_id': parent_id,
+            'is_used': bool(is_used),
             'model_id': move_line.id,
             'model':'stock.move.line',
             'product_id': move_line.product_id.display_name,
@@ -104,6 +115,7 @@ class MrpStockReport(models.TransientModel):
             'product_qty_uom': str(move_line.product_uom_id._compute_quantity(move_line.qty_done, move_line.product_id.uom_id, rounding_method='HALF-UP')) + ' ' + move_line.product_id.uom_id.name,
             'location_source': move_line.location_id.name,
             'location_destination': move_line.location_dest_id.name,
+
             'reference_id': ref,
             'res_id': res_id,
             'res_model': res_model}]
@@ -151,6 +163,8 @@ class MrpStockReport(models.TransientModel):
                 'model': data['model'],
                 'model_id': data['model_id'],
                 'parent_id': data['parent_id'],
+                'is_used': data.get('is_used', False),
+                'lot_id': data.get('lot_id', False),
                 'type': 'line',
                 'reference': data.get('reference_id', False),
                 'res_id': data.get('res_id', False),
diff --git a/addons/stock/static/src/js/stock_traceability_report_backend.js b/addons/stock/static/src/js/stock_traceability_report_backend.js
index 962b0e57b1c..472bd93ff04 100644
--- a/addons/stock/static/src/js/stock_traceability_report_backend.js
+++ b/addons/stock/static/src/js/stock_traceability_report_backend.js
@@ -23,6 +23,8 @@ var stock_report_generic = Widget.extend(ControlPanelMixin, {
         this.given_context.active_id = action.context.active_id || action.params.active_id;
         this.given_context.model = action.context.active_model || false;
         this.given_context.ttype = action.context.ttype || false;
+        this.given_context.auto_unfold = action.context.auto_unfold || false;
+        this.given_context.lot_id = action.context.lot_id || false;
         return this._super.apply(this, arguments);
     },
     willStart: function() {
@@ -38,6 +40,11 @@ var stock_report_generic = Widget.extend(ControlPanelMixin, {
         def.then(function () {
             self.report_widget.$el.html(self.html);
             self.report_widget.$el.find('.o_report_heading').html('<h1>Traceability Report</h1>')
+            if (self.given_context.auto_unfold) {
+                _.each(self.$el.find('.fa-caret-right'), function (line) {
+                    self.report_widget.autounfold(line, self.given_context.lot_id);
+                });
+            }
         });
     },
     start: function() {
diff --git a/addons/stock/static/src/js/stock_traceability_report_widgets.js b/addons/stock/static/src/js/stock_traceability_report_widgets.js
index 031de5a5c99..f7e68de8b3a 100644
--- a/addons/stock/static/src/js/stock_traceability_report_widgets.js
+++ b/addons/stock/static/src/js/stock_traceability_report_widgets.js
@@ -33,7 +33,8 @@ var ReportWidget = Widget.extend({
     },
     updownStream: function(e) {
         var $el = $(e.target).parents('tr');
-        var string = "Traceability Report"
+        var string = "Traceability Report";
+        console.log($el.data('lot_id'));
         this.do_action({
             type: "ir.actions.client",
             tag: 'stock_report_generic',
@@ -41,6 +42,8 @@ var ReportWidget = Widget.extend({
             context: {
                 active_id : $el.data('model_id'),
                 active_model : $el.data('model'),
+                auto_unfold: true,
+                lot_id: $el.data('lot_id') !== undefined && $el.data('lot_id').toString(),
                 url: '/stock/output_format/stock/active_id'
             },
         });
@@ -71,14 +74,15 @@ var ReportWidget = Widget.extend({
         $(e.target).parents('tr').find('span.o_stock_reports_foldable').replaceWith(QWeb.render("unfoldable", {lineId: active_id}));
         $(e.target).parents('tr').toggleClass('o_stock_reports_unfolded');
     },
-    unfold: function(e) {
+    autounfold: function(target, lot_id) {
+        var self = this;
         var $CurretElement;
-        $CurretElement = $(e.target).parents('tr').find('td.o_stock_reports_unfoldable');
+        $CurretElement = $(target).parents('tr').find('td.o_stock_reports_unfoldable');
         var active_id = $CurretElement.data('id');
         var active_model_name = $CurretElement.data('model');
         var active_model_id = $CurretElement.data('model_id');
         var row_level = $CurretElement.data('level');
-        var $cursor = $(e.target).parents('tr');
+        var $cursor = $(target).parents('tr');
         this._rpc({
                 model: 'stock.traceability.report',
                 method: 'get_lines',
@@ -90,15 +94,20 @@ var ReportWidget = Widget.extend({
                 },
             })
             .then(function (lines) {// After loading the line
-                var line;
-                for (line in lines) { // Render each line
-                    $cursor.after(QWeb.render("report_mrp_line", {l: lines[line]}));
+                _.each(lines, function (line) { // Render each line
+                    $cursor.after(QWeb.render("report_mrp_line", {l: line}));
                     $cursor = $cursor.next();
-                }
+                    if ($cursor && line.unfoldable && line.lot_id == lot_id) {
+                        self.autounfold($cursor.find(".fa-caret-right"), lot_id);
+                    }
+                });
             });
         $CurretElement.attr('class', 'o_stock_reports_foldable ' + active_id); // Change the class, and rendering of the unfolded line
-        $(e.target).parents('tr').find('span.o_stock_reports_unfoldable').replaceWith(QWeb.render("foldable", {lineId: active_id}));
-        $(e.target).parents('tr').toggleClass('o_stock_reports_unfolded');
+        $(target).parents('tr').find('span.o_stock_reports_unfoldable').replaceWith(QWeb.render("foldable", {lineId: active_id}));
+        $(target).parents('tr').toggleClass('o_stock_reports_unfolded');
+    },
+    unfold: function(e) {
+        this.autounfold($(e.target));
     },
 
 });
diff --git a/addons/stock/static/src/xml/stock_traceability_report_line.xml b/addons/stock/static/src/xml/stock_traceability_report_line.xml
index ff816ee5a9d..60903e6a4e5 100644
--- a/addons/stock/static/src/xml/stock_traceability_report_line.xml
+++ b/addons/stock/static/src/xml/stock_traceability_report_line.xml
@@ -25,7 +25,7 @@
             <t t-set="column" t-value="0" />
             <t t-foreach="l.columns" t-as="c">
                 <t t-set="column" t-value="column + 1" />
-                <td style="white-space: nowrap;" t-att-data-id="l.id" t-att-data-model="l.model" t-att-data-model_id="l.model_id" t-att-class="tdclass" t-att-data-level="l.level">
+                <td style="white-space: nowrap;" t-att-data-id="l.id" t-att-data-model="l.model" t-att-data-model_id="l.model_id" t-att-class="tdclass" t-att-data-level="l.level" t-att-data-lot_id="l.lot_id">
                     <t t-if="column == 1">
                         <span t-att-style="space_td" t-att-class="domainClass"></span>
                         <t t-if="l.unfoldable">
diff --git a/addons/stock/views/report_stock_traceability.xml b/addons/stock/views/report_stock_traceability.xml
index 50cf22d9881..b940082d5ca 100644
--- a/addons/stock/views/report_stock_traceability.xml
+++ b/addons/stock/views/report_stock_traceability.xml
@@ -10,7 +10,7 @@
                 <t t-set="domainClass" t-value="'o_stock_reports_domain_line_1'"/>
             </t>
             <t t-set="column" t-value="0" />
-            <tr t-att-data-type="a['type']" t-att-data-unfold="a['unfoldable']" t-att-data-parent_id="a['parent_id']" t-att-data-id="a['id']" t-att-data-model_id="a['model_id']" t-att-data-model="a['model']" t-att-class="trclass">
+            <tr t-att-data-type="a['type']" t-att-data-unfold="a['unfoldable']" t-att-data-parent_id="a['parent_id']" t-att-data-id="a['id']" t-att-data-model_id="a['model_id']" t-att-data-model="a['model']" t-att-data-lot_id="a['lot_id']" t-att-class="trclass">
                 <t t-set="tdclass" t-value="''" />
                 <t t-set="spanclass" t-value="''" />
                 <t t-if="a.get('unfoldable')"><t t-set="tdclass" t-value="'o_stock_reports_unfoldable'" /></t>
@@ -21,9 +21,12 @@
                       <td t-att-data-id="a.get('id')" t-att-data-model="a['model']" t-att-data-model_id="a['model_id']" t-att-class="tdclass" t-att-data-level="a['level']">
                         <t t-if="column == 1">
                             <span t-att-data-active-id="a['id']" t-att-class="a['type'] + ' ' + domainClass"></span>
-                            <t t-if="a.get('unfoldable')">
+                            <t t-if="a.get('unfoldable') and not a.get('is_used')">
                                 <span t-att-data-id="a['id']" class="o_stock_reports_unfoldable o_stock_reports_caret_icon"><i class="fa fa-fw fa-caret-right"></i></span>
                             </t>
+                            <t t-if="a.get('is_used')">
+                                <span class="o_stock_reports_stream" title="Traceability Report"><i class="fa fa-fw fa-level-up fa-rotate-270"></i></span>
+                            </t>
                         </t>
                         <t t-if="a['reference'] == c">
                             <span t-if="c" t-att-class="spanclass">

From 523092e6f49ef03af624e41a7f5bce7cb27da5d1 Mon Sep 17 00:00:00 2001
From: Haresh Shyara <hsh@odoo.com>
Date: Fri, 12 Jan 2018 15:39:14 +0530
Subject: [PATCH 07/17] [REF] stock: renamed 'UP/Down Stream traceability' to
 'Traceability Report

---
 addons/stock/data/stock_traceability_report_data.xml | 2 +-
 addons/stock/views/stock_picking_views.xml           | 2 +-
 addons/stock/views/stock_production_lot_views.xml    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/addons/stock/data/stock_traceability_report_data.xml b/addons/stock/data/stock_traceability_report_data.xml
index 52c237d822f..a9cff53dfe9 100644
--- a/addons/stock/data/stock_traceability_report_data.xml
+++ b/addons/stock/data/stock_traceability_report_data.xml
@@ -2,7 +2,7 @@
 <odoo>
 
     <record id="action_stock_report" model="ir.actions.client">
-        <field name="name">Upstream Traceability</field>
+        <field name="name">Traceability Report</field>
         <field name="tag">stock_report_generic</field>
         <field name="context" eval="{'url': '/stock/output_format/stock/active_id', 'model': 'stock.traceability.report'}" />
     </record>
diff --git a/addons/stock/views/stock_picking_views.xml b/addons/stock/views/stock_picking_views.xml
index 55b44f59b2e..5d8aac0c355 100644
--- a/addons/stock/views/stock_picking_views.xml
+++ b/addons/stock/views/stock_picking_views.xml
@@ -231,7 +231,7 @@
                         <button name="action_see_packages" string="Packages" type="object"
                             class="oe_stat_button" icon="fa-cubes"
                             attrs="{'invisible': [('has_packages', '=', False)]}"/>
-                        <button name="%(action_stock_report)d" icon="fa-arrow-up" class="oe_stat_button" string="Up/Down Traceability" type="action" states="done" groups="stock.group_production_lot"/>
+                        <button name="%(action_stock_report)d" icon="fa-arrow-up" class="oe_stat_button" string="Traceability Report" type="action" states="done" groups="stock.group_production_lot"/>
                     </div>
                     <h1 class="hidden-xs">
                         <field name="name" attrs="{'invisible': [('name','=','/')]}" readonly="1"/>
diff --git a/addons/stock/views/stock_production_lot_views.xml b/addons/stock/views/stock_production_lot_views.xml
index 64860c3a932..4df59d15b2e 100644
--- a/addons/stock/views/stock_production_lot_views.xml
+++ b/addons/stock/views/stock_production_lot_views.xml
@@ -15,7 +15,7 @@
                 <sheet>
                 <div class="oe_button_box" name="button_box">
                         <button name="%(lot_open_quants)d" icon="fa-arrows" class="oe_stat_button" string="Locate" type="action"/>
-                        <button name="%(action_stock_report)d" icon="fa-arrow-up" class="oe_stat_button" string="Up/Down Traceability" type="action"/>
+                        <button name="%(action_stock_report)d" icon="fa-arrow-up" class="oe_stat_button" string="Traceability Report" type="action"/>
                 </div>
                 <div class="oe_title">
                     <label for="name" class="oe_edit_only"/>

From 827beb96626d6d0f9ceccb3b05d6ea2e6724d66e Mon Sep 17 00:00:00 2001
From: Haresh Shyara <hsh@odoo.com>
Date: Fri, 12 Jan 2018 16:01:59 +0530
Subject: [PATCH 08/17] [IMP] mrp: added stat button on MO to open Traceability
 Report

- Remove some reusable code in get_lines()
---
 addons/mrp/views/mrp_production_views.xml |  1 +
 addons/stock/models/stock_traceability.py | 47 ++++++++++-------------
 2 files changed, 21 insertions(+), 27 deletions(-)

diff --git a/addons/mrp/views/mrp_production_views.xml b/addons/mrp/views/mrp_production_views.xml
index 03acdd8a549..f9cfe13ed6c 100644
--- a/addons/mrp/views/mrp_production_views.xml
+++ b/addons/mrp/views/mrp_production_views.xml
@@ -56,6 +56,7 @@
                     <field name="post_visible" invisible="1"/>
                     <field name="unreserve_visible" invisible="1"/>
                     <div class="oe_button_box" name="button_box">
+                        <button name="%(stock.action_stock_report)d" icon="fa-arrow-up" class="oe_stat_button" string="Traceability Report" type="action" states="done" groups="stock.group_production_lot"/>
                         <button name="%(action_mrp_workorder_production_specific)d" type="action" attrs="{'invisible': [('workorder_count', '=', 0)]}" class="oe_stat_button" icon="fa-play-circle-o">
                             <div class="o_field_widget o_stat_info">
                                 <span class="o_stat_value"><field name="workorder_done_count" widget="statinfo" nolabel="1"/> / <field name="workorder_count" widget="statinfo" nolabel="1"/></span>
diff --git a/addons/stock/models/stock_traceability.py b/addons/stock/models/stock_traceability.py
index d60b46e89c0..a1d1ad6cfa7 100644
--- a/addons/stock/models/stock_traceability.py
+++ b/addons/stock/models/stock_traceability.py
@@ -44,38 +44,31 @@ class MrpStockReport(models.TransientModel):
     @api.model
     def get_lines(self, line_id=None, **kw):
         context = dict(self.env.context)
-        model = False
-        model_id = False
-        level = 1
-        if kw:
-            level = kw['level']
-            model = kw['model_name']
-            model_id = kw['model_id']
+        model = kw and kw['model_name'] or context.get('model')
+        rec_id = kw and kw['model_id'] or context.get('active_id')
+        level = kw and kw['level'] or 1
+        lines = []
         res = []
         move_line = self.env['stock.move.line']
-        if context.get('active_id') and not context.get('model') or context.get('model') == 'stock.production.lot':
-            move_ids = self.env['stock.move.line'].search([
-                ('lot_id', '=', context.get('active_id')),
+        if rec_id and model in ('stock.production.lot', 'stock.move.line'):
+            lines = self.env['stock.move.line'].search([
+                ('lot_id', '=', context.get('lot_id') or rec_id),
                 ('state', '=', 'done'),
                 ('move_id.returned_move_ids', '=', False),
             ])
-            res += self._lines(line_id, model_id=model_id, model='stock.move.line', level=level, obj_ids=move_ids)
-        elif context.get('active_id') and context.get('model') == 'stock.picking':
-            move_ids = self.env['stock.picking'].browse(context['active_id']).move_lines.mapped('move_line_ids').filtered(lambda m: m.lot_id and m.state == 'done')
-            res = self._lines(line_id, model_id=model_id, model='stock.move.line', level=level, obj_ids=move_ids)
-        elif context.get('active_id') and context.get('model') == 'stock.move.line':
-            move_ids = self.env['stock.move.line'].search([
-                ('lot_id', '=', context.get('lot_id')),
-                ('state', '=', 'done'),
-                ('move_id.returned_move_ids', '=', False),
-            ])
-            for line in move_ids:
-                dummy, is_used = self._get_linked_move_lines(line)
-                if is_used:
-                    move_line |= is_used
-            res = self._lines(line_id, model_id=context.get('active_id'), model=context.get('model'), level=level, obj_ids=move_line)
-        else:
-            res = self._lines(line_id,  model_id=model_id, model=model, level=level)
+            if model == 'stock.move.line':
+                for line in lines:
+                    dummy, is_used = self._get_linked_move_lines(line)
+                    if is_used:
+                        move_line |= is_used
+                lines = move_line
+        elif rec_id and model in ('stock.picking', 'mrp.production'):
+            res = self.env[model].browse(rec_id)
+            if model == 'stock.picking':
+                lines = res.move_lines.mapped('move_line_ids').filtered(lambda m: m.lot_id and m.state == 'done')
+            else:
+                lines = res.move_finished_ids.mapped('move_line_ids').filtered(lambda m: m.lot_id and m.state == 'done')
+        res = self._lines(line_id, model_id=rec_id, model=model, level=level, obj_ids=lines)
         final_vals = sorted(res, key=lambda v: v['date'], reverse=True)
         lines = self.final_vals_to_lines(final_vals, level)
         return lines

From 0a9c5c9aa529ea029642f5583fde491306c3a078 Mon Sep 17 00:00:00 2001
From: Haresh Shyara <hsh@odoo.com>
Date: Fri, 12 Jan 2018 16:19:47 +0530
Subject: [PATCH 09/17] [IMP] stock: open traceability report from picking

- Make lot/serial number is clickable to open traceability report
---
 addons/stock/models/stock_traceability.py         |  1 -
 .../src/js/stock_traceability_report_widgets.js   | 15 +++++++++++++++
 .../src/less/stock_traceability_report.less       |  3 +++
 addons/stock/views/report_stock_traceability.xml  |  5 +++++
 4 files changed, 23 insertions(+), 1 deletion(-)

diff --git a/addons/stock/models/stock_traceability.py b/addons/stock/models/stock_traceability.py
index a1d1ad6cfa7..9bddd8cabf0 100644
--- a/addons/stock/models/stock_traceability.py
+++ b/addons/stock/models/stock_traceability.py
@@ -108,7 +108,6 @@ class MrpStockReport(models.TransientModel):
             'product_qty_uom': str(move_line.product_uom_id._compute_quantity(move_line.qty_done, move_line.product_id.uom_id, rounding_method='HALF-UP')) + ' ' + move_line.product_id.uom_id.name,
             'location_source': move_line.location_id.name,
             'location_destination': move_line.location_dest_id.name,
-
             'reference_id': ref,
             'res_id': res_id,
             'res_model': res_model}]
diff --git a/addons/stock/static/src/js/stock_traceability_report_widgets.js b/addons/stock/static/src/js/stock_traceability_report_widgets.js
index f7e68de8b3a..187f229b868 100644
--- a/addons/stock/static/src/js/stock_traceability_report_widgets.js
+++ b/addons/stock/static/src/js/stock_traceability_report_widgets.js
@@ -14,6 +14,7 @@ var ReportWidget = Widget.extend({
         'click span.o_stock_reports_unfoldable': 'unfold',
         'click .o_stock_reports_web_action': 'boundLink',
         'click .o_stock_reports_stream': 'updownStream',
+        'click .o_stock_report_lot_action': 'actionOpenLot'
     },
     init: function(parent) {
         this._super.apply(this, arguments);
@@ -31,6 +32,20 @@ var ReportWidget = Widget.extend({
             target: 'current'
         });
     },
+    actionOpenLot: function(e) {
+        var $el = $(e.target).parents('tr');
+        var lot_id = $el.data('lot_id');
+        this.do_action({
+            type: 'ir.actions.client',
+            tag: 'stock_report_generic',
+            name: $el.data('lot_id'),
+            context: {
+                active_id : lot_id,
+                active_model : 'stock.production.lot',
+                url: '/stock/output_format/stock/active_id'
+            },
+        });
+    },
     updownStream: function(e) {
         var $el = $(e.target).parents('tr');
         var string = "Traceability Report";
diff --git a/addons/stock/static/src/less/stock_traceability_report.less b/addons/stock/static/src/less/stock_traceability_report.less
index 2454dd1ad6f..c26304ab13d 100644
--- a/addons/stock/static/src/less/stock_traceability_report.less
+++ b/addons/stock/static/src/less/stock_traceability_report.less
@@ -46,6 +46,9 @@
     .o_stock_reports_nofoldable {
         margin-left: 17px;
     }
+    a.o_stock_report_lot_action  {
+        cursor: pointer;
+    }
     table > tbody > tr > td ~ td > span {
         margin-left: 10px;
     }
diff --git a/addons/stock/views/report_stock_traceability.xml b/addons/stock/views/report_stock_traceability.xml
index b940082d5ca..4b6eb03c36a 100644
--- a/addons/stock/views/report_stock_traceability.xml
+++ b/addons/stock/views/report_stock_traceability.xml
@@ -33,6 +33,11 @@
                                 <a t-att-data-active-id="a['res_id']" t-att-data-res-model="a['res_model']" class="o_stock_reports_web_action"><t t-raw="c" /></a>
                             </span>
                         </t>
+                        <t t-elif="a['lot_id'] == c and env.context.get('model') == 'stock.picking'">
+                            <span t-att-class="spanclass">
+                                <a class="o_stock_report_lot_action"><t t-raw="c"/></a>
+                            </span>
+                        </t>
                         <t t-else="">
                             <span>
                                 <t t-raw="c"/>

From a88bb28ad536d6beae2ec1000eb39546c8057d15 Mon Sep 17 00:00:00 2001
From: Haresh Shyara <hsh@odoo.com>
Date: Fri, 12 Jan 2018 16:26:43 +0530
Subject: [PATCH 10/17] [IMP] mrp: added production_id in vals when generate
 consumed move lines

---
 addons/mrp/models/stock_move.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/addons/mrp/models/stock_move.py b/addons/mrp/models/stock_move.py
index 73f4c861727..6a67b2107de 100644
--- a/addons/mrp/models/stock_move.py
+++ b/addons/mrp/models/stock_move.py
@@ -238,6 +238,7 @@ class StockMove(models.Model):
                 'move_id': self.id,
                 'product_id': self.product_id.id,
                 'location_id': location_id.id if location_id else self.location_id.id,
+                'production_id': self.raw_material_production_id.id,
                 'location_dest_id': self.location_dest_id.id,
                 'product_uom_qty': 0,
                 'product_uom_id': self.product_uom.id,

From 276e7ac769e928ff4d5125069608cb798084774b Mon Sep 17 00:00:00 2001
From: Haresh Shyara <hsh@odoo.com>
Date: Fri, 12 Jan 2018 16:30:11 +0530
Subject: [PATCH 11/17] [IMP] stock: scroll in traceability report

---
 .../stock/static/src/less/stock_traceability_report.less  | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/addons/stock/static/src/less/stock_traceability_report.less b/addons/stock/static/src/less/stock_traceability_report.less
index c26304ab13d..a19485865cd 100644
--- a/addons/stock/static/src/less/stock_traceability_report.less
+++ b/addons/stock/static/src/less/stock_traceability_report.less
@@ -15,7 +15,15 @@
     }
 }
 
+.o_main_content {
+    .o_stock_reports_page {
+        position: absolute;
+    }
+}
 .o_stock_reports_page {
+    @media (max-width: @screen-md-min) {
+        overflow-x:scroll;
+    }
     background-color: @odoo-view-background-color;
     color: @odoo-main-text-color;
     &.o_stock_reports_no_print {

From 776457fee96ee04aae95698121f17df31bdd0a1e Mon Sep 17 00:00:00 2001
From: Haresh Shyara <hsh@odoo.com>
Date: Fri, 12 Jan 2018 16:31:55 +0530
Subject: [PATCH 12/17] [IMP] stock: set text align left in PDF report header

---
 addons/stock/static/src/less/stock_traceability_report.less | 1 +
 1 file changed, 1 insertion(+)

diff --git a/addons/stock/static/src/less/stock_traceability_report.less b/addons/stock/static/src/less/stock_traceability_report.less
index a19485865cd..3c0c4bce65d 100644
--- a/addons/stock/static/src/less/stock_traceability_report.less
+++ b/addons/stock/static/src/less/stock_traceability_report.less
@@ -39,6 +39,7 @@
             margin-top: 30px;
         }
         .o_report_line_header {
+            text-align: left;
             padding-left: 10px;
         }
         .o_report_header {

From 05305729ee95f427a91143b7737bfad15859c5e0 Mon Sep 17 00:00:00 2001
From: Haresh Shyara <hsh@odoo.com>
Date: Fri, 12 Jan 2018 16:54:59 +0530
Subject: [PATCH 13/17] [IMP] mrp: moved 'Traceability: Lots' menu into Master
 Data

- Renamed 'Traceability: Lots' to 'Lots/Serial Numbers'
---
 addons/mrp/views/stock_move_views.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/addons/mrp/views/stock_move_views.xml b/addons/mrp/views/stock_move_views.xml
index dee35480569..7a5bf1a4011 100644
--- a/addons/mrp/views/stock_move_views.xml
+++ b/addons/mrp/views/stock_move_views.xml
@@ -88,11 +88,11 @@
         </record>
 
     <menuitem id="menu_mrp_traceability"
-          name="Traceability: Lots"
-          parent="menu_mrp_reporting"
+          name="Lots/Serial Numbers"
+          parent="menu_mrp_bom"
           action="stock.action_production_lot_form"
           groups="stock.group_production_lot"
-          sequence="10"/>
+          sequence="15"/>
 
     <menuitem id="menu_mrp_scrap"
             name="Scrap Orders"

From 4d77748e7627a453c02936c8795584e47faad91c Mon Sep 17 00:00:00 2001
From: Haresh Shyara <hsh@odoo.com>
Date: Fri, 12 Jan 2018 17:37:41 +0530
Subject: [PATCH 14/17] [IMP] stock: set text color on report line

- Outgoing moves should be in red (if going out of the stock).
- Incoming moves should be in green (if entering the stock).
- Internal moves should be in black.
- No lines in bold anymore in the report.
---
 addons/stock/models/stock_traceability.py           | 13 +++++++++++++
 .../static/src/less/stock_traceability_report.less  |  6 ++----
 .../src/xml/stock_traceability_report_line.xml      |  6 +++++-
 addons/stock/views/report_stock_traceability.xml    |  5 ++++-
 4 files changed, 24 insertions(+), 6 deletions(-)

diff --git a/addons/stock/models/stock_traceability.py b/addons/stock/models/stock_traceability.py
index 9bddd8cabf0..7cb3b3ba18c 100644
--- a/addons/stock/models/stock_traceability.py
+++ b/addons/stock/models/stock_traceability.py
@@ -92,6 +92,16 @@ class MrpStockReport(models.TransientModel):
             ref = move_line.move_id.scrap_ids[0].name
         return res_model, res_id, ref
 
+    def _get_usage(self, move_line):
+        usage = ''
+        if (move_line.location_id.usage == 'internal') and (move_line.location_dest_id.usage == 'internal'):
+            usage = 'internal'
+        elif (move_line.location_id.usage != 'internal') and (move_line.location_dest_id.usage == 'internal'):
+            usage = 'in'
+        else:
+            usage = 'out'
+        return usage
+
     def make_dict_move(self, level, parent_id, move_line, unfoldable=False):
         res_model, res_id, ref = self.get_links(move_line)
         dummy, is_used = self._get_linked_move_lines(move_line)
@@ -101,6 +111,7 @@ class MrpStockReport(models.TransientModel):
             'date': move_line.move_id.date,
             'parent_id': parent_id,
             'is_used': bool(is_used),
+            'usage': self._get_usage(move_line),
             'model_id': move_line.id,
             'model':'stock.move.line',
             'product_id': move_line.product_id.display_name,
@@ -122,6 +133,7 @@ class MrpStockReport(models.TransientModel):
                 'unfoldable': False if not move_line.lot_id else True,
                 'date': move_line.move_id.date,
                 'model_id': move_line.id,
+                'usage': self._get_usage(move_line),
                 'parent_id': parent_id,
                 'model': model or 'stock.move.line',
                 'product_id': move_line.product_id.display_name,
@@ -155,6 +167,7 @@ class MrpStockReport(models.TransientModel):
                 'model': data['model'],
                 'model_id': data['model_id'],
                 'parent_id': data['parent_id'],
+                'usage': data.get('usage', False),
                 'is_used': data.get('is_used', False),
                 'lot_id': data.get('lot_id', False),
                 'type': 'line',
diff --git a/addons/stock/static/src/less/stock_traceability_report.less b/addons/stock/static/src/less/stock_traceability_report.less
index 3c0c4bce65d..8d4052b9683 100644
--- a/addons/stock/static/src/less/stock_traceability_report.less
+++ b/addons/stock/static/src/less/stock_traceability_report.less
@@ -1,8 +1,7 @@
-.o_stock_reports_lines(@border-width: 5px, @color: inherit, @font-weight: inherit, @border-top-style: initial, @border-bottom-style: initial) {
+.o_stock_reports_lines(@border-width: 5px, @font-weight: inherit, @border-top-style: initial, @border-bottom-style: initial) {
     border-width: @border-width;
     border-left-style: hidden;
     border-right-style: hidden;
-    color: @color;
     font-weight: @font-weight;
     border-top-style: @border-top-style;
     border-bottom-style: @border-bottom-style;
@@ -25,13 +24,12 @@
         overflow-x:scroll;
     }
     background-color: @odoo-view-background-color;
-    color: @odoo-main-text-color;
     &.o_stock_reports_no_print {
         padding-bottom: 125px;
         margin: @odoo-horizontal-padding auto;
         .o-webclient-padding(@top: @odoo-sheet-vpadding, @bottom: @odoo-sheet-vpadding);
         .o_stock_reports_level0 {
-            .o_stock_reports_lines(@border-width: 1px, @color: @odoo-brand-primary, @font-weight: bold, @border-top-style: solid, @border-bottom-style: groove);
+            .o_stock_reports_lines(@border-width: 1px, @font-weight: normal, @border-top-style: solid, @border-bottom-style: groove);
         }
         .o_stock_reports_table {
             white-space: nowrap;
diff --git a/addons/stock/static/src/xml/stock_traceability_report_line.xml b/addons/stock/static/src/xml/stock_traceability_report_line.xml
index 60903e6a4e5..1a4cc85fdc1 100644
--- a/addons/stock/static/src/xml/stock_traceability_report_line.xml
+++ b/addons/stock/static/src/xml/stock_traceability_report_line.xml
@@ -20,6 +20,10 @@
             <t t-set="domainClass" t-value="'o_stock_reports_domain_line_1'"/>
         </t>
 
+        <t t-set="span_color" t-value="'color: #666666;'"/>
+        <t t-if="l.usage == 'in'"><t t-set="span_color" t-value="'color: #3c763d;'"/></t>
+        <t t-if="l.usage == 'out'"><t t-set="span_color" t-value="'color: #a94442;'"/></t>
+
         <tr t-att-data-type="l.type" t-att-data-unfold="l.unfoldable" t-att-data-parent_id="l.parent_id" t-att-data-id="l.id"  t-att-data-model_id="l.model_id" t-att-data-model="l.model" t-att-class="trclass">
             <t t-if="l.unfoldable == true"><t t-set="tdclass" t-value="'o_stock_reports_unfoldable'" /></t>
             <t t-set="column" t-value="0" />
@@ -38,7 +42,7 @@
                         </span>
                     </t>
                     <t t-if="l.reference != c">
-                        <t t-if="typeof c == 'string' || typeof c == 'number'"><span>
+                        <t t-if="typeof c == 'string' || typeof c == 'number'"><span t-att-style="span_color">
                             <t t-raw="c"/>
                         </span></t>
                         <t t-if="typeof c != 'string' &amp; typeof c != 'number'"><span t-att-style="c[1]">
diff --git a/addons/stock/views/report_stock_traceability.xml b/addons/stock/views/report_stock_traceability.xml
index 4b6eb03c36a..d4800eac77c 100644
--- a/addons/stock/views/report_stock_traceability.xml
+++ b/addons/stock/views/report_stock_traceability.xml
@@ -13,6 +13,9 @@
             <tr t-att-data-type="a['type']" t-att-data-unfold="a['unfoldable']" t-att-data-parent_id="a['parent_id']" t-att-data-id="a['id']" t-att-data-model_id="a['model_id']" t-att-data-model="a['model']" t-att-data-lot_id="a['lot_id']" t-att-class="trclass">
                 <t t-set="tdclass" t-value="''" />
                 <t t-set="spanclass" t-value="''" />
+                <t t-set="span_color" t-value="'color: #666666;'"/>
+                <t t-if="a['usage'] == 'in'"><t t-set="span_color" t-value="'color: #3c763d;'"/></t>
+                <t t-if="a['usage'] == 'out'"><t t-set="span_color" t-value="'color: #a94442;'"/></t>
                 <t t-if="a.get('unfoldable')"><t t-set="tdclass" t-value="'o_stock_reports_unfoldable'" /></t>
                 <t t-if="not a.get('unfoldable')"><t t-set="spanclass" t-value="'o_stock_reports_nofoldable'" /></t>
                 <t t-set="column" t-value="0" />
@@ -39,7 +42,7 @@
                             </span>
                         </t>
                         <t t-else="">
-                            <span>
+                            <span t-att-style="span_color">
                                 <t t-raw="c"/>
                             </span>
                         </t>

From 23ab8019c05c948c69301a0dd63bfe2381eaae0c Mon Sep 17 00:00:00 2001
From: Haresh Shyara <hsh@odoo.com>
Date: Tue, 16 Jan 2018 15:27:26 +0530
Subject: [PATCH 15/17] [IMP] stock: improve unbuild order traceability

- Traked component in case of consumed in.
- removed unused get_traceability method to move michanism into _lines()
---
 addons/stock/models/stock_traceability.py | 24 +++++++----------------
 1 file changed, 7 insertions(+), 17 deletions(-)

diff --git a/addons/stock/models/stock_traceability.py b/addons/stock/models/stock_traceability.py
index 7cb3b3ba18c..89ffdfbc8ec 100644
--- a/addons/stock/models/stock_traceability.py
+++ b/addons/stock/models/stock_traceability.py
@@ -29,11 +29,10 @@ class MrpStockReport(models.TransientModel):
                     lambda m: m.lot_id.id == move_line.lot_id.id)
             # if MTS
             else:
-                if move_line.location_id.usage == 'internal':
+                if move_line:
                     res |= self.env['stock.move.line'].search([
                         ('product_id', '=', move_line.product_id.id),
                         ('lot_id', '=', move_line.lot_id.id),
-                        ('location_dest_id', '=', move_line.location_id.id),
                         ('id', '!=', move_line.id),
                         ('date', '<', move_line.date),
                     ])
@@ -146,18 +145,6 @@ class MrpStockReport(models.TransientModel):
                 'res_model': res_model}]
         return data
 
-    @api.model
-    def get_traceability(self, level, line_id=False, model=False, model_obj=False):
-        final_vals = []
-        if model == 'stock.move.line':
-            moves = self.get_move_lines(model_obj)
-        for move in moves:
-            unfoldable = False
-            if move.consume_line_ids:
-                unfoldable = True
-            final_vals += self.make_dict_move(level, parent_id=line_id, move_line=move, unfoldable=unfoldable)
-        return final_vals
-
     @api.model
     def final_vals_to_lines(self, final_vals, level):
         lines = []
@@ -196,12 +183,15 @@ class MrpStockReport(models.TransientModel):
         final_vals = []
         if model and line_id:
             move_line = self.env[model].browse(model_id)
-            move_lines, dummy = self._get_linked_move_lines(move_line)
+            move_lines, is_used = self._get_linked_move_lines(move_line)
             if move_lines:
                 final_vals += self.get_produced_or_consumed_vals(move_lines, level, model=model, parent_id=line_id)
             else:
-                final_vals += self.get_traceability(level, line_id=line_id, model=model, model_obj=move_line)
-                final_vals = self.make_dict_move(level, parent_id=line_id, move_line=move_line) + final_vals
+                lines = self.get_move_lines(move_line)
+                if is_used:
+                    move_line |= lines
+                for line in move_line:
+                    final_vals += self.make_dict_move(level, parent_id=line_id, move_line=line)
         else:
             for move_line in obj_ids:
                 unfoldable = bool(move_line.produce_line_ids or move_line.consume_line_ids)

From 476ebd08d768be144ee2c65aca579c94085a5cd6 Mon Sep 17 00:00:00 2001
From: Haresh Shyara <hsh@odoo.com>
Date: Wed, 17 Jan 2018 14:36:32 +0530
Subject: [PATCH 16/17] [IMP]stock: lot_serial number clickable on traceability
 report

- click on lot/serial number directly send to the traceability of that SN
---
 addons/stock/models/stock_traceability.py       | 17 ++++++++++-------
 .../src/js/stock_traceability_report_backend.js |  4 ++--
 .../src/js/stock_traceability_report_widgets.js | 14 ++++++--------
 .../src/xml/stock_traceability_report_line.xml  | 11 ++++++++---
 .../stock/views/report_stock_traceability.xml   |  6 +++---
 5 files changed, 29 insertions(+), 23 deletions(-)

diff --git a/addons/stock/models/stock_traceability.py b/addons/stock/models/stock_traceability.py
index 89ffdfbc8ec..f43a0977827 100644
--- a/addons/stock/models/stock_traceability.py
+++ b/addons/stock/models/stock_traceability.py
@@ -51,7 +51,7 @@ class MrpStockReport(models.TransientModel):
         move_line = self.env['stock.move.line']
         if rec_id and model in ('stock.production.lot', 'stock.move.line'):
             lines = self.env['stock.move.line'].search([
-                ('lot_id', '=', context.get('lot_id') or rec_id),
+                ('lot_id', '=', context.get('lot_name') or rec_id),
                 ('state', '=', 'done'),
                 ('move_id.returned_move_ids', '=', False),
             ])
@@ -114,7 +114,8 @@ class MrpStockReport(models.TransientModel):
             'model_id': move_line.id,
             'model':'stock.move.line',
             'product_id': move_line.product_id.display_name,
-            'lot_id': move_line.lot_id.name,
+            'lot_name': move_line.lot_id.name,
+            'lot_id': move_line.lot_id.id,
             'product_qty_uom': str(move_line.product_uom_id._compute_quantity(move_line.qty_done, move_line.product_id.uom_id, rounding_method='HALF-UP')) + ' ' + move_line.product_id.uom_id.name,
             'location_source': move_line.location_id.name,
             'location_destination': move_line.location_dest_id.name,
@@ -136,7 +137,8 @@ class MrpStockReport(models.TransientModel):
                 'parent_id': parent_id,
                 'model': model or 'stock.move.line',
                 'product_id': move_line.product_id.display_name,
-                'lot_id': move_line.lot_id.name,
+                'lot_name': move_line.lot_id.name,
+                'lot_id': move_line.lot_id.id,
                 'product_qty_uom': str(move_line.product_uom_id._compute_quantity(move_line.qty_done, move_line.product_id.uom_id, rounding_method='HALF-UP')) + ' ' + move_line.product_id.uom_id.name,
                 'location_source': move_line.location_id.name if not move_line.lot_id else False,
                 'location_destination': move_line.location_dest_id.name if not move_line.lot_id else False,
@@ -156,16 +158,17 @@ class MrpStockReport(models.TransientModel):
                 'parent_id': data['parent_id'],
                 'usage': data.get('usage', False),
                 'is_used': data.get('is_used', False),
+                'lot_name': data.get('lot_name', False),
                 'lot_id': data.get('lot_id', False),
                 'type': 'line',
                 'reference': data.get('reference_id', False),
                 'res_id': data.get('res_id', False),
                 'res_model': data.get('res_model', False),
-                'name': _(data.get('lot_id', False)),
+                'name': _(data.get('lot_name', False)),
                 'columns': [data.get('reference_id', False),
                             data.get('product_id', False),
                             data.get('date', False),
-                            data.get('lot_id', False),
+                            data.get('lot_name', False),
                             data.get('location_source', False),
                             data.get('location_destination', False),
                             data.get('product_qty_uom', 0)],
@@ -223,11 +226,11 @@ class MrpStockReport(models.TransientModel):
                 'model_id': data['model_id'],
                 'parent_id': data['parent_id'],
                 'type': 'line',
-                'name': _(data.get('lot_id')),
+                'name': _(data.get('lot_name')),
                 'columns': [data.get('reference_id'),
                             data.get('product_id'),
                             data.get('date'),
-                            data.get('lot_id'),
+                            data.get('lot_name'),
                             data.get('location_source', False),
                             data.get('location_destination', False),
                             data.get('product_qty_uom', 0)],
diff --git a/addons/stock/static/src/js/stock_traceability_report_backend.js b/addons/stock/static/src/js/stock_traceability_report_backend.js
index 472bd93ff04..553c155e94a 100644
--- a/addons/stock/static/src/js/stock_traceability_report_backend.js
+++ b/addons/stock/static/src/js/stock_traceability_report_backend.js
@@ -24,7 +24,7 @@ var stock_report_generic = Widget.extend(ControlPanelMixin, {
         this.given_context.model = action.context.active_model || false;
         this.given_context.ttype = action.context.ttype || false;
         this.given_context.auto_unfold = action.context.auto_unfold || false;
-        this.given_context.lot_id = action.context.lot_id || false;
+        this.given_context.lot_name = action.context.lot_name || false;
         return this._super.apply(this, arguments);
     },
     willStart: function() {
@@ -42,7 +42,7 @@ var stock_report_generic = Widget.extend(ControlPanelMixin, {
             self.report_widget.$el.find('.o_report_heading').html('<h1>Traceability Report</h1>')
             if (self.given_context.auto_unfold) {
                 _.each(self.$el.find('.fa-caret-right'), function (line) {
-                    self.report_widget.autounfold(line, self.given_context.lot_id);
+                    self.report_widget.autounfold(line, self.given_context.lot_name);
                 });
             }
         });
diff --git a/addons/stock/static/src/js/stock_traceability_report_widgets.js b/addons/stock/static/src/js/stock_traceability_report_widgets.js
index 187f229b868..ea08871828f 100644
--- a/addons/stock/static/src/js/stock_traceability_report_widgets.js
+++ b/addons/stock/static/src/js/stock_traceability_report_widgets.js
@@ -34,13 +34,12 @@ var ReportWidget = Widget.extend({
     },
     actionOpenLot: function(e) {
         var $el = $(e.target).parents('tr');
-        var lot_id = $el.data('lot_id');
         this.do_action({
             type: 'ir.actions.client',
             tag: 'stock_report_generic',
-            name: $el.data('lot_id'),
+            name: $el.data('lot_name'),
             context: {
-                active_id : lot_id,
+                active_id : $el.data('lot_id'),
                 active_model : 'stock.production.lot',
                 url: '/stock/output_format/stock/active_id'
             },
@@ -49,7 +48,6 @@ var ReportWidget = Widget.extend({
     updownStream: function(e) {
         var $el = $(e.target).parents('tr');
         var string = "Traceability Report";
-        console.log($el.data('lot_id'));
         this.do_action({
             type: "ir.actions.client",
             tag: 'stock_report_generic',
@@ -58,7 +56,7 @@ var ReportWidget = Widget.extend({
                 active_id : $el.data('model_id'),
                 active_model : $el.data('model'),
                 auto_unfold: true,
-                lot_id: $el.data('lot_id') !== undefined && $el.data('lot_id').toString(),
+                lot_name: $el.data('lot_name') !== undefined && $el.data('lot_name').toString(),
                 url: '/stock/output_format/stock/active_id'
             },
         });
@@ -89,7 +87,7 @@ var ReportWidget = Widget.extend({
         $(e.target).parents('tr').find('span.o_stock_reports_foldable').replaceWith(QWeb.render("unfoldable", {lineId: active_id}));
         $(e.target).parents('tr').toggleClass('o_stock_reports_unfolded');
     },
-    autounfold: function(target, lot_id) {
+    autounfold: function(target, lot_name) {
         var self = this;
         var $CurretElement;
         $CurretElement = $(target).parents('tr').find('td.o_stock_reports_unfoldable');
@@ -112,8 +110,8 @@ var ReportWidget = Widget.extend({
                 _.each(lines, function (line) { // Render each line
                     $cursor.after(QWeb.render("report_mrp_line", {l: line}));
                     $cursor = $cursor.next();
-                    if ($cursor && line.unfoldable && line.lot_id == lot_id) {
-                        self.autounfold($cursor.find(".fa-caret-right"), lot_id);
+                    if ($cursor && line.unfoldable && line.lot_name == lot_name) {
+                        self.autounfold($cursor.find(".fa-caret-right"), lot_name);
                     }
                 });
             });
diff --git a/addons/stock/static/src/xml/stock_traceability_report_line.xml b/addons/stock/static/src/xml/stock_traceability_report_line.xml
index 1a4cc85fdc1..f8778dff2ab 100644
--- a/addons/stock/static/src/xml/stock_traceability_report_line.xml
+++ b/addons/stock/static/src/xml/stock_traceability_report_line.xml
@@ -24,12 +24,12 @@
         <t t-if="l.usage == 'in'"><t t-set="span_color" t-value="'color: #3c763d;'"/></t>
         <t t-if="l.usage == 'out'"><t t-set="span_color" t-value="'color: #a94442;'"/></t>
 
-        <tr t-att-data-type="l.type" t-att-data-unfold="l.unfoldable" t-att-data-parent_id="l.parent_id" t-att-data-id="l.id"  t-att-data-model_id="l.model_id" t-att-data-model="l.model" t-att-class="trclass">
+        <tr t-att-data-type="l.type" t-att-data-unfold="l.unfoldable" t-att-data-parent_id="l.parent_id" t-att-data-id="l.id"  t-att-data-model_id="l.model_id" t-att-data-model="l.model" t-att-class="trclass" t-att-data-lot_name="l.lot_name" t-att-data-lot_id="l.lot_id">
             <t t-if="l.unfoldable == true"><t t-set="tdclass" t-value="'o_stock_reports_unfoldable'" /></t>
             <t t-set="column" t-value="0" />
             <t t-foreach="l.columns" t-as="c">
                 <t t-set="column" t-value="column + 1" />
-                <td style="white-space: nowrap;" t-att-data-id="l.id" t-att-data-model="l.model" t-att-data-model_id="l.model_id" t-att-class="tdclass" t-att-data-level="l.level" t-att-data-lot_id="l.lot_id">
+                <td style="white-space: nowrap;" t-att-data-id="l.id" t-att-data-model="l.model" t-att-data-model_id="l.model_id" t-att-class="tdclass" t-att-data-level="l.level" t-att-data-lot_name="l.lot_name">
                     <t t-if="column == 1">
                         <span t-att-style="space_td" t-att-class="domainClass"></span>
                         <t t-if="l.unfoldable">
@@ -41,7 +41,12 @@
                             <a t-att-data-active-id="l.res_id" t-att-data-res-model="l.res_model" class="o_stock_reports_web_action"><t t-raw="c" /></a>
                         </span>
                     </t>
-                    <t t-if="l.reference != c">
+                    <t t-elif="l.lot_name == c and l.lot_name != false">
+                            <span>
+                                <a class="o_stock_report_lot_action"><t t-raw="c"/></a>
+                            </span>
+                        </t>
+                    <t t-if="l.reference != c and l.lot_name != c">
                         <t t-if="typeof c == 'string' || typeof c == 'number'"><span t-att-style="span_color">
                             <t t-raw="c"/>
                         </span></t>
diff --git a/addons/stock/views/report_stock_traceability.xml b/addons/stock/views/report_stock_traceability.xml
index d4800eac77c..b8030f818a9 100644
--- a/addons/stock/views/report_stock_traceability.xml
+++ b/addons/stock/views/report_stock_traceability.xml
@@ -10,7 +10,7 @@
                 <t t-set="domainClass" t-value="'o_stock_reports_domain_line_1'"/>
             </t>
             <t t-set="column" t-value="0" />
-            <tr t-att-data-type="a['type']" t-att-data-unfold="a['unfoldable']" t-att-data-parent_id="a['parent_id']" t-att-data-id="a['id']" t-att-data-model_id="a['model_id']" t-att-data-model="a['model']" t-att-data-lot_id="a['lot_id']" t-att-class="trclass">
+            <tr t-att-data-type="a['type']" t-att-data-unfold="a['unfoldable']" t-att-data-parent_id="a['parent_id']" t-att-data-id="a['id']" t-att-data-model_id="a['model_id']" t-att-data-model="a['model']" t-att-data-lot_name="a['lot_name']" t-att-data-lot_id="a['lot_id']" t-att-class="trclass">
                 <t t-set="tdclass" t-value="''" />
                 <t t-set="spanclass" t-value="''" />
                 <t t-set="span_color" t-value="'color: #666666;'"/>
@@ -36,8 +36,8 @@
                                 <a t-att-data-active-id="a['res_id']" t-att-data-res-model="a['res_model']" class="o_stock_reports_web_action"><t t-raw="c" /></a>
                             </span>
                         </t>
-                        <t t-elif="a['lot_id'] == c and env.context.get('model') == 'stock.picking'">
-                            <span t-att-class="spanclass">
+                        <t t-elif="a['lot_name'] == c">
+                            <span>
                                 <a class="o_stock_report_lot_action"><t t-raw="c"/></a>
                             </span>
                         </t>

From 68061e25176168d50c5212f9d3df1ed05de0a7e2 Mon Sep 17 00:00:00 2001
From: Haresh Shyara <hsh@odoo.com>
Date: Fri, 19 Jan 2018 17:15:24 +0530
Subject: [PATCH 17/17] [IMP] stock, mrp, repair: optimization traceability
 report based on stock move lines

- Optimized _lines() to fold/unfold mechanism and use stock move line in get lines.
- Merged into single method (make_dict_move and make_dict_head) to get parent & child traceability result
  and use unfolfable to make line unfoldable.
- Removed _get_produced_or_consumed_vals method and move mechanisam into _line method will do same for this.
- Make some methods private.
- Removed useless vals from dict.
---
 addons/mrp/models/stock_traceability.py       |   4 +-
 addons/repair/models/stock_traceability.py    |   4 +-
 addons/stock/models/stock_traceability.py     | 115 +++++-------------
 .../xml/stock_traceability_report_line.xml    |   2 +-
 .../stock/views/report_stock_traceability.xml |   5 +-
 5 files changed, 38 insertions(+), 92 deletions(-)

diff --git a/addons/mrp/models/stock_traceability.py b/addons/mrp/models/stock_traceability.py
index 48157da82c9..accacb081a9 100644
--- a/addons/mrp/models/stock_traceability.py
+++ b/addons/mrp/models/stock_traceability.py
@@ -4,8 +4,8 @@ class MrpStockReport(models.TransientModel):
     _inherit = 'stock.traceability.report'
 
     @api.model
-    def get_links(self, move_line):
-        res_model, res_id, ref = super(MrpStockReport, self).get_links(move_line)
+    def _get_reference(self, move_line):
+        res_model, res_id, ref = super(MrpStockReport, self)._get_reference(move_line)
         if move_line.production_id:
             res_model = 'mrp.production'
             res_id = move_line.production_id.id
diff --git a/addons/repair/models/stock_traceability.py b/addons/repair/models/stock_traceability.py
index cc912e2ea29..09ee6430946 100644
--- a/addons/repair/models/stock_traceability.py
+++ b/addons/repair/models/stock_traceability.py
@@ -4,8 +4,8 @@ class MrpStockReport(models.TransientModel):
     _inherit = 'stock.traceability.report'
 
     @api.model
-    def get_links(self, move_line):
-        res_model, res_id, ref = super(MrpStockReport, self).get_links(move_line)
+    def _get_reference(self, move_line):
+        res_model, res_id, ref = super(MrpStockReport, self)._get_reference(move_line)
         if move_line.move_id.repair_id:
             res_model = 'repair.order'
             res_id = move_line.move_id.repair_id.id
diff --git a/addons/stock/models/stock_traceability.py b/addons/stock/models/stock_traceability.py
index f43a0977827..3b683002c05 100644
--- a/addons/stock/models/stock_traceability.py
+++ b/addons/stock/models/stock_traceability.py
@@ -20,7 +20,7 @@ class MrpStockReport(models.TransientModel):
     _name = 'stock.traceability.report'
 
     @api.model
-    def get_move_lines(self, move_lines):
+    def _get_move_lines(self, move_lines):
         res = self.env['stock.move.line']
         for move_line in move_lines:
             # if MTO
@@ -37,7 +37,7 @@ class MrpStockReport(models.TransientModel):
                         ('date', '<', move_line.date),
                     ])
         if res:
-            res |= self.get_move_lines(res)
+            res |= self._get_move_lines(res)
         return res
 
     @api.model
@@ -47,10 +47,9 @@ class MrpStockReport(models.TransientModel):
         rec_id = kw and kw['model_id'] or context.get('active_id')
         level = kw and kw['level'] or 1
         lines = []
-        res = []
         move_line = self.env['stock.move.line']
         if rec_id and model in ('stock.production.lot', 'stock.move.line'):
-            lines = self.env['stock.move.line'].search([
+            lines = move_line.search([
                 ('lot_id', '=', context.get('lot_name') or rec_id),
                 ('state', '=', 'done'),
                 ('move_id.returned_move_ids', '=', False),
@@ -62,18 +61,18 @@ class MrpStockReport(models.TransientModel):
                         move_line |= is_used
                 lines = move_line
         elif rec_id and model in ('stock.picking', 'mrp.production'):
-            res = self.env[model].browse(rec_id)
+            record = self.env[model].browse(rec_id)
             if model == 'stock.picking':
-                lines = res.move_lines.mapped('move_line_ids').filtered(lambda m: m.lot_id and m.state == 'done')
+                lines = record.move_lines.mapped('move_line_ids').filtered(lambda m: m.lot_id and m.state == 'done')
             else:
-                lines = res.move_finished_ids.mapped('move_line_ids').filtered(lambda m: m.lot_id and m.state == 'done')
-        res = self._lines(line_id, model_id=rec_id, model=model, level=level, obj_ids=lines)
-        final_vals = sorted(res, key=lambda v: v['date'], reverse=True)
-        lines = self.final_vals_to_lines(final_vals, level)
+                lines = record.move_finished_ids.mapped('move_line_ids').filtered(lambda m: m.lot_id and m.state == 'done')
+        move_line_vals = self._lines(line_id, model_id=rec_id, model=model, level=level, move_lines=lines)
+        final_vals = sorted(move_line_vals, key=lambda v: v['date'], reverse=True)
+        lines = self._final_vals_to_lines(final_vals, level)
         return lines
 
     @api.model
-    def get_links(self, move_line):
+    def _get_reference(self, move_line):
         res_model = ''
         ref = ''
         res_id = False
@@ -101,9 +100,10 @@ class MrpStockReport(models.TransientModel):
             usage = 'out'
         return usage
 
-    def make_dict_move(self, level, parent_id, move_line, unfoldable=False):
-        res_model, res_id, ref = self.get_links(move_line)
+    def _make_dict_move(self, level, parent_id, move_line, unfoldable=False):
+        res_model, res_id, ref = self._get_reference(move_line)
         dummy, is_used = self._get_linked_move_lines(move_line)
+        unfoldable = False if not move_line.lot_id else unfoldable
         data = [{
             'level': level,
             'unfoldable': unfoldable,
@@ -112,43 +112,20 @@ class MrpStockReport(models.TransientModel):
             'is_used': bool(is_used),
             'usage': self._get_usage(move_line),
             'model_id': move_line.id,
-            'model':'stock.move.line',
+            'model': 'stock.move.line',
             'product_id': move_line.product_id.display_name,
             'lot_name': move_line.lot_id.name,
             'lot_id': move_line.lot_id.id,
             'product_qty_uom': str(move_line.product_uom_id._compute_quantity(move_line.qty_done, move_line.product_id.uom_id, rounding_method='HALF-UP')) + ' ' + move_line.product_id.uom_id.name,
-            'location_source': move_line.location_id.name,
-            'location_destination': move_line.location_dest_id.name,
+            'location_source': move_line.location_id.name if not unfoldable or level == 1 else False,
+            'location_destination': move_line.location_dest_id.name if not unfoldable or level == 1 else False,
             'reference_id': ref,
             'res_id': res_id,
             'res_model': res_model}]
         return data
 
-    def make_dict_head(self, level, parent_id, model=False, move_line=False):
-        res_model, res_id, ref = self.get_links(move_line)
-        data = []
-        if model == 'stock.move.line':
-            data = [{
-                'level': level,
-                'unfoldable': False if not move_line.lot_id else True,
-                'date': move_line.move_id.date,
-                'model_id': move_line.id,
-                'usage': self._get_usage(move_line),
-                'parent_id': parent_id,
-                'model': model or 'stock.move.line',
-                'product_id': move_line.product_id.display_name,
-                'lot_name': move_line.lot_id.name,
-                'lot_id': move_line.lot_id.id,
-                'product_qty_uom': str(move_line.product_uom_id._compute_quantity(move_line.qty_done, move_line.product_id.uom_id, rounding_method='HALF-UP')) + ' ' + move_line.product_id.uom_id.name,
-                'location_source': move_line.location_id.name if not move_line.lot_id else False,
-                'location_destination': move_line.location_dest_id.name if not move_line.lot_id else False,
-                'reference_id': ref,
-                'res_id': res_id,
-                'res_model': res_model}]
-        return data
-
     @api.model
-    def final_vals_to_lines(self, final_vals, level):
+    def _final_vals_to_lines(self, final_vals, level):
         lines = []
         for data in final_vals:
             lines.append({
@@ -160,11 +137,9 @@ class MrpStockReport(models.TransientModel):
                 'is_used': data.get('is_used', False),
                 'lot_name': data.get('lot_name', False),
                 'lot_id': data.get('lot_id', False),
-                'type': 'line',
                 'reference': data.get('reference_id', False),
                 'res_id': data.get('res_id', False),
                 'res_model': data.get('res_model', False),
-                'name': _(data.get('lot_name', False)),
                 'columns': [data.get('reference_id', False),
                             data.get('product_id', False),
                             data.get('date', False),
@@ -182,62 +157,34 @@ class MrpStockReport(models.TransientModel):
         return False, False
 
     @api.model
-    def _lines(self, line_id=None, model_id=False, model=False, level=0, obj_ids=[], **kw):
+    def _lines(self, line_id=None, model_id=False, model=False, level=0, move_lines=[], **kw):
         final_vals = []
+        lines = move_lines or []
         if model and line_id:
             move_line = self.env[model].browse(model_id)
             move_lines, is_used = self._get_linked_move_lines(move_line)
             if move_lines:
-                final_vals += self.get_produced_or_consumed_vals(move_lines, level, model=model, parent_id=line_id)
+                lines = move_lines
             else:
-                lines = self.get_move_lines(move_line)
                 if is_used:
-                    move_line |= lines
+                    # Traceability in case of consumed in.
+                    move_line |= self._get_move_lines(move_line)
                 for line in move_line:
-                    final_vals += self.make_dict_move(level, parent_id=line_id, move_line=line)
-        else:
-            for move_line in obj_ids:
-                unfoldable = bool(move_line.produce_line_ids or move_line.consume_line_ids)
-                final_vals += self.make_dict_move(level, parent_id=line_id, move_line=move_line, unfoldable=unfoldable)
-        return final_vals
-
-    @api.model
-    def get_produced_or_consumed_vals(self, move_lines, level, model, parent_id):
-        final_vals = []
-        for line in move_lines:
-            final_vals += self.make_dict_head(level, model=model, parent_id=parent_id, move_line=line)
+                    final_vals += self._make_dict_move(level, parent_id=line_id, move_line=line)
+        for line in lines:
+            unfoldable = bool(line.produce_line_ids or line.consume_line_ids)
+            final_vals += self._make_dict_move(level, parent_id=line_id, move_line=line, unfoldable=unfoldable)
         return final_vals
 
     def get_pdf_lines(self, line_data=[]):
-        final_vals = []
         lines = []
         for line in line_data:
             model = self.env[line['model_name']].browse(line['model_id'])
-            dummy, move_line = self._get_linked_move_lines(model)
-            if line.get('unfoldable') and move_line:
-                    final_vals += self.make_dict_head(line['level'], model=line['model_name'], parent_id=line['id'], move_line=model)
-            else:
-                if line['model_name'] == 'stock.move.line':
-                    final_vals += self.make_dict_move(line['level'], parent_id=line['id'], move_line=model)
-        for data in final_vals:
-            lines.append({
-                'id': autoIncrement(),
-                'model': data['model'],
-                'model_id': data['model_id'],
-                'parent_id': data['parent_id'],
-                'type': 'line',
-                'name': _(data.get('lot_name')),
-                'columns': [data.get('reference_id'),
-                            data.get('product_id'),
-                            data.get('date'),
-                            data.get('lot_name'),
-                            data.get('location_source', False),
-                            data.get('location_destination', False),
-                            data.get('product_qty_uom', 0)],
-                'level': data['level'],
-                'unfoldable': data['unfoldable'],
-            })
-
+            unfoldable = False
+            if line.get('unfoldable'):
+                unfoldable = True
+            final_vals = self._make_dict_move(line['level'], parent_id=line['id'], move_line=model, unfoldable=unfoldable)
+            lines.append(self._final_vals_to_lines(final_vals, line['level'])[0])
         return lines
 
     def get_pdf(self, line_data=[]):
diff --git a/addons/stock/static/src/xml/stock_traceability_report_line.xml b/addons/stock/static/src/xml/stock_traceability_report_line.xml
index f8778dff2ab..48d309d8a27 100644
--- a/addons/stock/static/src/xml/stock_traceability_report_line.xml
+++ b/addons/stock/static/src/xml/stock_traceability_report_line.xml
@@ -24,7 +24,7 @@
         <t t-if="l.usage == 'in'"><t t-set="span_color" t-value="'color: #3c763d;'"/></t>
         <t t-if="l.usage == 'out'"><t t-set="span_color" t-value="'color: #a94442;'"/></t>
 
-        <tr t-att-data-type="l.type" t-att-data-unfold="l.unfoldable" t-att-data-parent_id="l.parent_id" t-att-data-id="l.id"  t-att-data-model_id="l.model_id" t-att-data-model="l.model" t-att-class="trclass" t-att-data-lot_name="l.lot_name" t-att-data-lot_id="l.lot_id">
+        <tr t-att-data-unfold="l.unfoldable" t-att-data-parent_id="l.parent_id" t-att-data-id="l.id"  t-att-data-model_id="l.model_id" t-att-data-model="l.model" t-att-class="trclass" t-att-data-lot_name="l.lot_name" t-att-data-lot_id="l.lot_id">
             <t t-if="l.unfoldable == true"><t t-set="tdclass" t-value="'o_stock_reports_unfoldable'" /></t>
             <t t-set="column" t-value="0" />
             <t t-foreach="l.columns" t-as="c">
diff --git a/addons/stock/views/report_stock_traceability.xml b/addons/stock/views/report_stock_traceability.xml
index b8030f818a9..4aa36ba7410 100644
--- a/addons/stock/views/report_stock_traceability.xml
+++ b/addons/stock/views/report_stock_traceability.xml
@@ -10,7 +10,7 @@
                 <t t-set="domainClass" t-value="'o_stock_reports_domain_line_1'"/>
             </t>
             <t t-set="column" t-value="0" />
-            <tr t-att-data-type="a['type']" t-att-data-unfold="a['unfoldable']" t-att-data-parent_id="a['parent_id']" t-att-data-id="a['id']" t-att-data-model_id="a['model_id']" t-att-data-model="a['model']" t-att-data-lot_name="a['lot_name']" t-att-data-lot_id="a['lot_id']" t-att-class="trclass">
+            <tr t-att-data-unfold="a['unfoldable']" t-att-data-parent_id="a['parent_id']" t-att-data-id="a['id']" t-att-data-model_id="a['model_id']" t-att-data-model="a['model']" t-att-data-lot_name="a['lot_name']" t-att-data-lot_id="a['lot_id']" t-att-class="trclass">
                 <t t-set="tdclass" t-value="''" />
                 <t t-set="spanclass" t-value="''" />
                 <t t-set="span_color" t-value="'color: #666666;'"/>
@@ -23,7 +23,6 @@
                     <t t-set="column" t-value="column + 1" />
                       <td t-att-data-id="a.get('id')" t-att-data-model="a['model']" t-att-data-model_id="a['model_id']" t-att-class="tdclass" t-att-data-level="a['level']">
                         <t t-if="column == 1">
-                            <span t-att-data-active-id="a['id']" t-att-class="a['type'] + ' ' + domainClass"></span>
                             <t t-if="a.get('unfoldable') and not a.get('is_used')">
                                 <span t-att-data-id="a['id']" class="o_stock_reports_unfoldable o_stock_reports_caret_icon"><i class="fa fa-fw fa-caret-right"></i></span>
                             </t>
@@ -121,7 +120,7 @@
                             <t t-set="trclass" t-value="'o_stock_reports_default_style'"/>
                             <t t-if="a.get('model') == 'stock.move.line'"><t t-set="trclass" t-value="'o_stock_reports_level0'"/></t>
                             <t t-set="column" t-value="0" />
-                            <tr t-att-data-type="a['type']" t-att-data-id="a['id']" t-att-data-model="a['model']" t-att-class="trclass">
+                            <tr t-att-data-id="a['id']" t-att-data-model="a['model']" t-att-class="trclass">
                                 <t t-set="tdclass" t-value="''" />
                                 <t t-if="a.get('unfoldable')"><t t-set="tdclass" t-value="'o_stock_reports_unfoldable'" /></t>
                                 <t t-set="column" t-value="0" />