From a2ba3739b8551bfdd9a1556ac453a8bbb485fcc3 Mon Sep 17 00:00:00 2001
From: Rob Coekaerts <roco@odoo.com>
Date: Fri, 10 Jun 2022 13:29:39 +0000
Subject: [PATCH] [IMP] hr_expense: disable quick creation of taxes

Disable the (quick) creation of taxes in places where
it is likely to result in faulty data entry. This forces
the user to fill in new tax records consciously.

task-2860025

closes odoo/odoo#93319

Signed-off-by: Kevin Baptiste <kba@odoo.com>
---
 addons/hr_expense/views/hr_expense_views.xml | 7 +++++--
 addons/sale_expense/views/product_view.xml   | 3 ++-
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/addons/hr_expense/views/hr_expense_views.xml b/addons/hr_expense/views/hr_expense_views.xml
index 7024d47ec60..27b7c76ecb5 100644
--- a/addons/hr_expense/views/hr_expense_views.xml
+++ b/addons/hr_expense/views/hr_expense_views.xml
@@ -169,7 +169,8 @@
                                         widget="many2many_tags"
                                         attrs="{'readonly': ['|', ('is_editable', '=', False), ('product_has_cost', '=', True)],
                                                 'invisible': [('product_has_tax', '=', False)]}"
-                                        context="{'default_company_id': company_id, 'default_type_tax_use': 'purchase', 'default_price_include': 1}"/>
+                                        context="{'default_company_id': company_id, 'default_type_tax_use': 'purchase', 'default_price_include': 1}"
+                                        options="{'no_create': True}"/>
                                 </div>
                                 <div class="d-flex pt-2">
                                     <span attrs="{'invisible': [('product_has_tax', '=', False)]}" class="oe_inline o_form_label ml-1 mr-1"> ( </span>
@@ -537,7 +538,9 @@
                             </group>
                             <group string="Accounting">
                                 <field name="property_account_expense_id" groups="account.group_account_readonly"/>
-                                <field name="supplier_taxes_id" domain="[('price_include', '=', True)]" widget="many2many_tags" context="{'default_type_tax_use':'purchase'}"/>
+                                <field name="supplier_taxes_id" domain="[('price_include', '=', True)]" widget="many2many_tags" 
+                                       context="{'default_type_tax_use':'purchase', 'default_price_include': 1}" 
+                                       options="{'no_quick_create': True}"/>
                             </group>
                         </group>
                         <notebook>
diff --git a/addons/sale_expense/views/product_view.xml b/addons/sale_expense/views/product_view.xml
index 58fa3461ac6..432bce0d780 100644
--- a/addons/sale_expense/views/product_view.xml
+++ b/addons/sale_expense/views/product_view.xml
@@ -16,7 +16,8 @@
                 <field name="list_price" attrs="{'invisible':[('expense_policy', '!=', 'sales_price')]}"/>
             </xpath>
             <xpath expr="//field[@name='supplier_taxes_id']" position="after">
-                <field name="taxes_id" widget="many2many_tags" attrs="{'invisible':[('expense_policy', '=', 'no')]}"/>
+                <field name="taxes_id" widget="many2many_tags" attrs="{'invisible':[('expense_policy', '=', 'no')]}"
+                       options="{'no_quick_create': True}"/>
             </xpath>
         </field>
     </record>