From a24d57daeb5a4386d7e8c1694d7e9d418877b7ac Mon Sep 17 00:00:00 2001
From: "Tiffany Chang (tic)" <tic@odoo.com>
Date: Fri, 2 Dec 2022 12:31:20 +0000
Subject: [PATCH] [FIX] mrp: correct unit cost in bom

Incorrect variable reference + calculation for unit BoM cost for
byproduct/product (to produce) within in BoM overview report. This
was leading to the displayed value having the cost_share being multipled
into the unit cost twice.

Steps to reproduce:

- create component with cost 100
- create BoM with 1 of this component + 1 byproduct with
  qty = 2 and cost_share = 50.00
- click on Overview

result before this commit:
Manufactured Product unit cost = 25.00
Byproduct unit cost = 12.50

actual result should be:
Manufactured Product unit cost = 50.00
Byproduct unit cost = 25.00

closes odoo/odoo#107410

X-original-commit: 2339bed170b5f670b1f5a6cebd533a9cee72d4db
Signed-off-by: Steve Van Essche <svs@odoo.com>
Signed-off-by: Tiffany Chang <tic@odoo.com>
---
 addons/mrp/report/mrp_report_bom_structure.xml                | 4 ++--
 .../components/bom_overview_table/mrp_bom_overview_table.xml  | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/addons/mrp/report/mrp_report_bom_structure.xml b/addons/mrp/report/mrp_report_bom_structure.xml
index bff4d85b55f..c222540fe67 100644
--- a/addons/mrp/report/mrp_report_bom_structure.xml
+++ b/addons/mrp/report/mrp_report_bom_structure.xml
@@ -65,7 +65,7 @@
                             <td t-if="data['show_availabilities']"/>
                             <td t-if="data['show_lead_times']"/>
                             <td/>
-                            <td class="text-end" t-esc="data['cost_share'] * data['bom_cost'] / data['quantity']" t-options='{"widget": "monetary", "display_currency": currency}'/>
+                            <td class="text-end" t-esc="data['bom_cost'] / data['quantity']" t-options='{"widget": "monetary", "display_currency": currency}'/>
                             <td class="text-end" t-esc="data['prod_cost']/data['quantity']" t-options='{"widget": "monetary", "display_currency": currency}'/>
                         </tr>
                         <t t-if="data['show_costs'] and data['byproducts']" t-foreach="data['byproducts']" t-as="byproduct">
@@ -78,7 +78,7 @@
                                 <td t-if="data['show_availabilities']"/>
                                 <td t-if="data['show_lead_times']"/>
                                 <td/>
-                                <td class="text-end" t-esc="byproduct['cost_share'] * data['bom_cost'] / byproduct['quantity']" t-options='{"widget": "monetary", "display_currency": currency}'/>
+                                <td class="text-end" t-esc="byproduct['bom_cost'] / byproduct['quantity']" t-options='{"widget": "monetary", "display_currency": currency}'/>
                                 <td class="text-end" t-esc="byproduct['prod_cost'] / byproduct['quantity']" t-options='{"widget": "monetary", "display_currency": currency}'/>
                             </tr>
                         </t>
diff --git a/addons/mrp/static/src/components/bom_overview_table/mrp_bom_overview_table.xml b/addons/mrp/static/src/components/bom_overview_table/mrp_bom_overview_table.xml
index bcbf4a0750f..6c15b91af6a 100644
--- a/addons/mrp/static/src/components/bom_overview_table/mrp_bom_overview_table.xml
+++ b/addons/mrp/static/src/components/bom_overview_table/mrp_bom_overview_table.xml
@@ -62,7 +62,7 @@
                             <td t-if="showAvailabilities"/>
                             <td t-if="showLeadTimes"/>
                             <td/>
-                            <td class="text-end" t-esc="formatMonetary(data.cost_share * data.bom_cost / data.quantity)"/>
+                            <td class="text-end" t-esc="formatMonetary(data.bom_cost / data.quantity)"/>
                             <td class="text-end" t-esc="formatMonetary(data.prod_cost / data.quantity)"/>
                             <td t-if="showAttachments"/>
                         </tr>
@@ -76,7 +76,7 @@
                                 <td t-if="showAvailabilities"/>
                                 <td t-if="showLeadTimes"/>
                                 <td/>
-                                <td class="text-end" t-esc="formatMonetary(byproduct.cost_share * data.bom_cost / byproduct.quantity)"/>
+                                <td class="text-end" t-esc="formatMonetary(byproduct.bom_cost / byproduct.quantity)"/>
                                 <td class="text-end" t-esc="formatMonetary(byproduct.prod_cost / byproduct.quantity)"/>
                                 <td t-if="showAttachments"/>
                             </tr>