From a2016359d0daae03a3cd37310be8605aa56ad4e7 Mon Sep 17 00:00:00 2001
From: Adrien Dieudonne <adr@odoo.com>
Date: Mon, 23 Oct 2023 14:32:33 +0200
Subject: [PATCH] [REF] web, *: avoid extend on h5 for kanban card title
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

´extends´ generates a lot of css rules.

So in this commit, we remove it by replacing it by the ´h5´ html tag.

closes odoo/odoo#139484

Related: odoo/enterprise#49408
Signed-off-by: Romeo Fragomeli (rfr) <rfr@odoo.com>
---
 .../views/account_journal_dashboard_view.xml  | 36 +++++++++----------
 addons/crm/views/crm_team_views.xml           |  6 ++--
 addons/hr_recruitment/views/hr_job_views.xml  | 12 +++----
 .../maintenance/views/maintenance_views.xml   |  8 ++---
 addons/mrp/views/mrp_workcenter_views.xml     |  8 ++---
 addons/mrp/views/stock_picking_views.xml      |  8 ++---
 .../views/point_of_sale_dashboard.xml         |  8 ++---
 .../project/views/project_project_views.xml   |  8 ++---
 addons/repair/views/stock_picking_views.xml   |  8 ++---
 addons/sales_team/views/crm_team_views.xml    | 12 +++----
 .../stock/views/stock_picking_type_views.xml  |  8 ++---
 .../src/views/kanban/kanban_dashboard.scss    |  1 -
 12 files changed, 61 insertions(+), 62 deletions(-)

diff --git a/addons/account/views/account_journal_dashboard_view.xml b/addons/account/views/account_journal_dashboard_view.xml
index 80b80c15f16..96111a366f9 100644
--- a/addons/account/views/account_journal_dashboard_view.xml
+++ b/addons/account/views/account_journal_dashboard_view.xml
@@ -66,9 +66,9 @@
                             <!-- For bank and cash -->
                             <div t-if="journal_type == 'bank' || journal_type == 'cash'" class="row">
                                 <div class="col-4 o_kanban_card_manage_section o_kanban_manage_view">
-                                    <div id="card_action_view_menus" class="o_kanban_card_manage_title">
+                                    <h5 id="card_action_view_menus" class="o_kanban_card_manage_title">
                                         <span role="separator">View</span>
-                                    </div>
+                                    </h5>
                                     <div id="action_card_statements">
                                         <a t-if="journal_type == 'bank'" role="menuitem" type="object" name="open_action_with_context" context="{'action_name': 'action_bank_statement_tree', 'search_default_journal': True}">Statements</a>
                                         <a t-if="journal_type == 'cash'" role="menuitem" type="object" name="open_action_with_context" context="{'action_name': 'action_view_bank_statement_tree', 'search_default_journal': True}">Cash Registers</a>
@@ -88,9 +88,9 @@
                                 </div>
 
                                 <div class="col-4 o_kanban_card_manage_section o_kanban_manage_new" groups="account.group_account_user">
-                                    <div class="o_kanban_card_manage_title">
+                                    <h5 class="o_kanban_card_manage_title">
                                         <span role="separator">New</span>
-                                    </div>
+                                    </h5>
                                     <div name="bank_customer_payment">
                                         <a role="menuitem" type="object" name="create_customer_payment">Cust. Payment</a>
                                     </div>
@@ -103,9 +103,9 @@
                                 </div>
 
                                 <div class="col-4 o_kanban_card_manage_section o_kanban_manage_reconciliation">
-                                    <div class="o_kanban_card_manage_title">
+                                    <h5 class="o_kanban_card_manage_title">
                                         <span role="separator">Reconciliation</span>
-                                    </div>
+                                    </h5>
                                     <div>
                                         <a role="menuitem" type="object" name="open_action_with_context" context="{'action_name': 'action_account_reconcile_model', 'use_domain': ['|', ('match_journal_ids', '=', False), ('match_journal_ids', 'in', [id])]}" groups="account.group_account_manager">Reconciliation Models</a>
                                     </div>
@@ -115,9 +115,9 @@
                             <!-- For purchase and sale -->
                             <div t-if="journal_type == 'purchase' || journal_type == 'sale'" class="row">
                                 <div class="col-4 o_kanban_card_manage_section o_kanban_manage_view">
-                                    <div class="o_kanban_card_manage_title">
+                                    <h5 class="o_kanban_card_manage_title">
                                         <span>View</span>
-                                    </div>
+                                    </h5>
                                     <div>
                                         <a t-if="journal_type == 'sale'" type="object" name="open_action" context="{'action_name': 'action_move_out_invoice_type'}">Invoices</a>
                                         <a t-if="journal_type == 'purchase'" type="object" name="open_action" context="{'action_name': 'action_move_in_invoice_type'}">Bills</a>
@@ -132,9 +132,9 @@
                                 </div>
 
                                 <div class="col-4 o_kanban_card_manage_section o_kanban_manage_new" groups="account.group_account_invoice">
-                                    <div class="o_kanban_card_manage_title">
+                                    <h5 class="o_kanban_card_manage_title">
                                         <span>New</span>
-                                    </div>
+                                    </h5>
                                     <div>
                                         <a type="object" name="action_create_new">
                                             <span t-if="journal_type == 'sale'">Invoice</span>
@@ -153,9 +153,9 @@
                                 </div>
 
                                 <div class="col-4 o_kanban_card_manage_section o_kanban_manage_reports">
-                                    <div class="o_kanban_card_manage_title">
+                                    <h5 class="o_kanban_card_manage_title">
                                         <span>Reporting</span>
-                                    </div>
+                                    </h5>
                                     <div>
                                         <a t-if="journal_type == 'sale'" type="action" name="%(action_account_invoice_report_all)d" groups="account.group_account_readonly">Invoices Analysis</a>
                                         <a t-if="journal_type == 'purchase'" type="action" name="%(action_account_invoice_report_all_supp)d" groups="account.group_account_readonly">Bills Analysis</a>
@@ -166,9 +166,9 @@
                             <!-- For general and situation -->
                             <div t-if="journal_type == 'general' || journal_type == 'situation'" class="row">
                                 <div class="col-4 o_kanban_card_manage_section o_kanban_manage_view">
-                                    <div class="o_kanban_card_manage_title">
+                                    <h5 class="o_kanban_card_manage_title">
                                         <span>View</span>
-                                    </div>
+                                    </h5>
                                     <div>
                                         <a type="object" name="open_action" context="{'action_name': 'action_move_journal_line'}">Journal Entries</a>
                                     </div>
@@ -181,18 +181,18 @@
                                 </div>
 
                                 <div class="col-4 o_kanban_card_manage_section o_kanban_manage_new" groups="account.group_account_user">
-                                    <div class="o_kanban_card_manage_title">
+                                    <h5 class="o_kanban_card_manage_title">
                                         <span>New</span>
-                                    </div>
+                                    </h5>
                                     <div>
                                         <a type="object" name="action_create_new">Journal Entry</a>
                                     </div>
                                 </div>
 
                                 <div class="col-4 o_kanban_card_manage_section o_kanban_manage_operations">
-                                    <div class="o_kanban_card_manage_title">
+                                    <h5 class="o_kanban_card_manage_title">
                                         <span>Operations</span>
-                                    </div>
+                                    </h5>
                                     <div>
                                         <a type="object" name="open_action_with_context" context="{'action_name': 'action_validate_account_move', 'search_default_journal': True}"  groups="account.group_account_user">Post All Entries</a>
                                     </div>
diff --git a/addons/crm/views/crm_team_views.xml b/addons/crm/views/crm_team_views.xml
index 6e9c42f5d1c..08620447bfd 100644
--- a/addons/crm/views/crm_team_views.xml
+++ b/addons/crm/views/crm_team_views.xml
@@ -298,7 +298,7 @@
                         </div>
                     </xpath>
 
-                    <xpath expr="//div[hasclass('o_kanban_manage_view')]/div[hasclass('o_kanban_card_manage_title')]" position="after">
+                    <xpath expr="//div[hasclass('o_kanban_manage_view')]/h5[hasclass('o_kanban_card_manage_title')]" position="after">
                         <div t-if="record.use_leads.raw_value" groups="crm.group_use_lead">
                             <a name="%(crm_case_form_view_salesteams_lead)d" type="action">
                                 Leads
@@ -311,7 +311,7 @@
                         </div>
                     </xpath>
 
-                    <xpath expr="//div[hasclass('o_kanban_manage_new')]/div[hasclass('o_kanban_card_manage_title')]" position="after">
+                    <xpath expr="//div[hasclass('o_kanban_manage_new')]/h5[hasclass('o_kanban_card_manage_title')]" position="after">
                         <div t-if="record.use_leads.raw_value" groups="crm.group_use_lead">
                             <a name="%(crm_lead_action_open_lead_form)d" type="action">
                                 Leads
@@ -324,7 +324,7 @@
                         </div>
                     </xpath>
 
-                    <xpath expr="//div[hasclass('o_kanban_manage_reports')]/div[hasclass('o_kanban_card_manage_title')]" position="after">
+                    <xpath expr="//div[hasclass('o_kanban_manage_reports')]/h5[hasclass('o_kanban_card_manage_title')]" position="after">
                         <div t-if="record.use_leads.raw_value" groups="crm.group_use_lead">
                             <a name="%(action_report_crm_lead_salesteam)d" type="action">
                                 Leads
diff --git a/addons/hr_recruitment/views/hr_job_views.xml b/addons/hr_recruitment/views/hr_job_views.xml
index 7afccab14b2..992446ef098 100644
--- a/addons/hr_recruitment/views/hr_job_views.xml
+++ b/addons/hr_recruitment/views/hr_job_views.xml
@@ -30,9 +30,9 @@
                         <div class="container">
                             <div class="row">
                                 <div class="col-6 o_kanban_card_manage_section">
-                                    <div role="menuitem" class="o_kanban_card_manage_title">
+                                    <h5 role="menuitem" class="o_kanban_card_manage_title">
                                         <span>View</span>
-                                    </div>
+                                    </h5>
                                     <div role="menuitem" name="menu_view_applications">
                                         <a name="%(action_hr_job_applications)d" type="action">Applications</a>
                                     </div>
@@ -44,17 +44,17 @@
                                     </div>
                                 </div>
                                 <div class="col-6 o_kanban_card_manage_section">
-                                    <div role="menuitem" class="o_kanban_card_manage_title">
+                                    <h5 role="menuitem" class="o_kanban_card_manage_title">
                                         <span>New</span>
-                                    </div>
+                                    </h5>
                                     <div role="menuitem" name="menu_new_applications">
                                         <a name="%(hr_recruitment.action_hr_applicant_new)d" type="action">Application</a>
                                     </div>
                                 </div>
                                 <div class="col-6 o_kanban_card_manage_section">
-                                    <div role="menuitem" class="o_kanban_card_manage_title">
+                                    <h5 role="menuitem" class="o_kanban_card_manage_title">
                                         <span>Reporting</span>
-                                    </div>
+                                    </h5>
                                     <div role="menuitem" name="o_kanban_job_reporting">
                                         <a name="%(hr_recruitment.action_hr_recruitment_report_filtered_job)d" type="action">Analysis</a>
                                     </div>
diff --git a/addons/maintenance/views/maintenance_views.xml b/addons/maintenance/views/maintenance_views.xml
index 8b4136c139f..d3996be845a 100644
--- a/addons/maintenance/views/maintenance_views.xml
+++ b/addons/maintenance/views/maintenance_views.xml
@@ -888,9 +888,9 @@
                         <div class="container">
                             <div class="row">
                                 <div class="col-6 o_kanban_card_manage_section o_kanban_manage_view">
-                                    <div role="menuitem" class="o_kanban_card_manage_title">
+                                    <h5 role="menuitem" class="o_kanban_card_manage_title">
                                         <span>Requests</span>
-                                    </div>
+                                    </h5>
                                     <div role="menuitem">
                                         <a name="%(hr_equipment_todo_request_action_from_dashboard)d" type="action">
                                             All
@@ -913,9 +913,9 @@
                                     </div>
                                 </div>
                                 <div class="col-6 o_kanban_card_manage_section o_kanban_manage_new">
-                                    <div role="menuitem" class="o_kanban_card_manage_title">
+                                    <h5 role="menuitem" class="o_kanban_card_manage_title">
                                         <span>Reporting</span>
-                                    </div>
+                                    </h5>
                                     <div role="menuitem">
                                         <a name="%(maintenance_request_action_reports)d" type="action" context="{'search_default_maintenance_team_id': id}">
                                         Maintenance Requests
diff --git a/addons/mrp/views/mrp_workcenter_views.xml b/addons/mrp/views/mrp_workcenter_views.xml
index 014d13f44a5..b6d8bc6221b 100644
--- a/addons/mrp/views/mrp_workcenter_views.xml
+++ b/addons/mrp/views/mrp_workcenter_views.xml
@@ -160,17 +160,17 @@
                             <div class="container">
                                 <div class="row">
                                     <div class="col-6 o_kanban_card_manage_section o_kanban_manage_view">
-                                        <div role="menuitem" class="o_kanban_card_manage_title">
+                                        <h5 role="menuitem" class="o_kanban_card_manage_title">
                                             <span>Actions</span>
-                                        </div>
+                                        </h5>
                                         <div role="menuitem" name="plan_order">
                                             <a name="action_work_order" type="object">Plan Orders</a>
                                         </div>
                                     </div>
                                     <div class="col-6 o_kanban_card_manage_section o_kanban_manage_new">
-                                        <div role="menuitem" class="o_kanban_card_manage_title">
+                                        <h5 role="menuitem" class="o_kanban_card_manage_title">
                                             <span>Reporting</span>
-                                        </div>
+                                        </h5>
                                         <div role="menuitem">
                                             <a name="%(mrp_workcenter_productivity_report_oee)d" type="action">OEE</a>
                                         </div>
diff --git a/addons/mrp/views/stock_picking_views.xml b/addons/mrp/views/stock_picking_views.xml
index 3985a8fe982..fe999c0b733 100644
--- a/addons/mrp/views/stock_picking_views.xml
+++ b/addons/mrp/views/stock_picking_views.xml
@@ -15,9 +15,9 @@
                 <div class="container" t-if="record.code.raw_value == 'mrp_operation'">
                     <div class="row">
                         <div class="col-6 o_kanban_card_manage_section o_kanban_manage_view" name="picking_left_manage_pane">
-                            <div role="menuitem" class="o_kanban_card_manage_title">
+                            <h5 role="menuitem" class="o_kanban_card_manage_title">
                                 <span>Orders</span>
-                            </div>
+                            </h5>
                             <div role="menuitem">
                                 <a name="%(mrp_production_action_picking_deshboard)d" type="action">All</a>
                             </div>
@@ -29,9 +29,9 @@
                             </div>
                         </div>
                         <div class="col-6 o_kanban_card_manage_section o_kanban_manage_new">
-                            <div role="menuitem" class="o_kanban_card_manage_title">
+                            <h5 role="menuitem" class="o_kanban_card_manage_title">
                                 <span>New</span>
-                            </div>
+                            </h5>
                             <div role="menuitem">
                                 <a name="%(action_mrp_production_form)d" context="{'default_picking_type_id': id}" type="action">Manufacturing Order</a>
                             </div>
diff --git a/addons/point_of_sale/views/point_of_sale_dashboard.xml b/addons/point_of_sale/views/point_of_sale_dashboard.xml
index f8610a641d2..d70d8165c05 100644
--- a/addons/point_of_sale/views/point_of_sale_dashboard.xml
+++ b/addons/point_of_sale/views/point_of_sale_dashboard.xml
@@ -72,9 +72,9 @@
                         <div class="container dropdown-pos-config">
                             <div class="row">
                                 <div class="col-6 o_kanban_card_manage_section o_kanban_manage_view w-100">
-                                    <div role="menuitem" class="o_kanban_card_manage_title">
+                                    <h5 role="menuitem" class="o_kanban_card_manage_title">
                                         <span>View</span>
-                                    </div>
+                                    </h5>
                                     <div role="menuitem">
                                         <a name="%(action_pos_order_filtered)d" type="action">Orders</a>
                                     </div>
@@ -83,9 +83,9 @@
                                     </div>
                                 </div>
                                 <div class="col-6 o_kanban_card_manage_section o_kanban_manage_new">
-                                    <div role="menuitem" class="o_kanban_card_manage_title">
+                                    <h5 role="menuitem" class="o_kanban_card_manage_title">
                                         <span>Reporting</span>
-                                    </div>
+                                    </h5>
                                     <div role="menuitem">
                                         <a name="%(action_report_pos_order_all_filtered)d" type="action">Orders</a>
                                     </div>
diff --git a/addons/project/views/project_project_views.xml b/addons/project/views/project_project_views.xml
index 3f03523be51..81aed92a234 100644
--- a/addons/project/views/project_project_views.xml
+++ b/addons/project/views/project_project_views.xml
@@ -412,9 +412,9 @@
                             <div class="container">
                                 <div class="row">
                                     <div class="col-6 o_kanban_card_manage_section o_kanban_manage_view">
-                                        <div role="menuitem" class="o_kanban_card_manage_title">
+                                        <h5 role="menuitem" class="o_kanban_card_manage_title">
                                             <span>View</span>
-                                        </div>
+                                        </h5>
                                         <div role="menuitem">
                                             <a name="action_view_tasks" type="object">Tasks</a>
                                         </div>
@@ -423,9 +423,9 @@
                                         </div>
                                     </div>
                                     <div class="col-6 o_kanban_card_manage_section o_kanban_manage_reporting">
-                                        <div role="menuitem" class="o_kanban_card_manage_title" groups="project.group_project_user">
+                                        <h5 role="menuitem" class="o_kanban_card_manage_title" groups="project.group_project_user">
                                             <span>Reporting</span>
-                                        </div>
+                                        </h5>
                                         <div role="menuitem" groups="project.group_project_user" class="o_kanban_task_analysis">
                                             <a name="action_view_tasks_analysis" type="object">Tasks Analysis</a>
                                         </div>
diff --git a/addons/repair/views/stock_picking_views.xml b/addons/repair/views/stock_picking_views.xml
index b5f7cf33c27..5256ac104c6 100644
--- a/addons/repair/views/stock_picking_views.xml
+++ b/addons/repair/views/stock_picking_views.xml
@@ -53,9 +53,9 @@
                 <div class="container" t-if="record.code.raw_value == 'repair_operation'">
                         <div class="row">
                             <div class="col-6 o_kanban_card_manage_section o_kanban_manage_view" name="picking_left_manage_pane">
-                                <div role="menuitem" class="o_kanban_card_manage_title">
+                                <h5 role="menuitem" class="o_kanban_card_manage_title">
                                     <span>Orders</span>
-                                </div>
+                                </h5>
                                 <div role="menuitem">
                                     <a name="get_repair_stock_picking_action_picking_type" type="object">All</a>
                                 </div>
@@ -64,9 +64,9 @@
                                 </div>
                             </div>
                             <div class="col-6 o_kanban_card_manage_section o_kanban_manage_new">
-                                <div role="menuitem" class="o_kanban_card_manage_title">
+                                <h5 role="menuitem" class="o_kanban_card_manage_title">
                                     <a name="%(action_repair_order_form)d" type="action" context="{'default_picking_type_id': id}">New</a>
-                                </div>
+                                </h5>
                             </div>
                         </div>
 
diff --git a/addons/sales_team/views/crm_team_views.xml b/addons/sales_team/views/crm_team_views.xml
index 993e93995f1..d29099d2eea 100644
--- a/addons/sales_team/views/crm_team_views.xml
+++ b/addons/sales_team/views/crm_team_views.xml
@@ -155,19 +155,19 @@
                         <div class="container">
                             <div class="row">
                                 <div class="col-4 o_kanban_card_manage_section o_kanban_manage_view">
-                                    <div role="menuitem" class="o_kanban_card_manage_title">
+                                    <h5 role="menuitem" class=" o_kanban_card_manage_title">
                                         <span>View</span>
-                                    </div>
+                                    </h5>
                                 </div>
                                 <div class="col-4 o_kanban_card_manage_section o_kanban_manage_new">
-                                    <div role="menuitem" class="o_kanban_card_manage_title">
+                                    <h5 role="menuitem" class="o_kanban_card_manage_title">
                                         <span>New</span>
-                                    </div>
+                                    </h5>
                                 </div>
                                 <div class="col-4 o_kanban_card_manage_section o_kanban_manage_reports">
-                                    <div role="menuitem" class="o_kanban_card_manage_title">
+                                    <h5 role="menuitem" class="o_kanban_card_manage_title">
                                         <span>Reporting</span>
-                                    </div>
+                                    </h5>
                                     <div name="o_team_kanban_report_separator"></div>
                                 </div>
                             </div>
diff --git a/addons/stock/views/stock_picking_type_views.xml b/addons/stock/views/stock_picking_type_views.xml
index d57f04d15dc..df7376489ab 100644
--- a/addons/stock/views/stock_picking_type_views.xml
+++ b/addons/stock/views/stock_picking_type_views.xml
@@ -190,10 +190,10 @@
                         <div class="container" t-if="record.show_picking_type.raw_value">
                             <div class="row">
                                 <div class="col-6 o_kanban_card_manage_section o_kanban_manage_view">
-                                    <div role="menuitem" class="o_kanban_card_manage_title">
+                                    <h5 role="menuitem" class="o_kanban_card_manage_title">
                                         <span t-if="record.code.raw_value == 'internal'">Transfers</span>
                                         <span t-else="">View</span>
-                                    </div>
+                                    </h5>
                                     <div role="menuitem">
                                         <a name="get_stock_picking_action_picking_type" type="object">All</a>
                                     </div>
@@ -208,9 +208,9 @@
                                     </div>
                                 </div>
                                 <div class="col-6 o_kanban_card_manage_section o_kanban_manage_new">
-                                    <div role="menuitem" class="o_kanban_card_manage_title">
+                                    <h5 role="menuitem" class="o_kanban_card_manage_title">
                                         <a name="%(action_picking_form)d" type="action">New</a>
-                                    </div>
+                                    </h5>
                                 </div>
                             </div>
 
diff --git a/addons/web/static/src/views/kanban/kanban_dashboard.scss b/addons/web/static/src/views/kanban/kanban_dashboard.scss
index 3810f1808f4..9788c55ee5c 100644
--- a/addons/web/static/src/views/kanban/kanban_dashboard.scss
+++ b/addons/web/static/src/views/kanban/kanban_dashboard.scss
@@ -153,7 +153,6 @@
                 max-width: none;
 
                 > .o_kanban_card_manage_title {
-                    @extend .h5;
                     margin: (($font-size-base * $line-height-base) / 2) 0;
                 }
                 > div:not(.o_kanban_card_manage_title) {