From a086761848db7a2d022e9d58d5ab51ebba3d946e Mon Sep 17 00:00:00 2001
From: lul-odoo <lul@odoo.com>
Date: Fri, 19 Oct 2018 08:12:54 +0000
Subject: [PATCH] [IMP] hr_*: Search on department and on children departments

Purpose
=======

Currently when searching on a department (on the employee view for example)
we only retrieve employees from the specific department. It should return
all the employees from the department and also from its children
departments, like for partners or companies.

Specification
=============

Adapt all the search view where a department field is used by
specifying a 'child_of' operator.
---
 addons/hr/views/hr_views.xml                           | 4 ++--
 addons/hr_attendance/views/hr_attendance_view.xml      | 2 +-
 addons/hr_contract/views/hr_contract_views.xml         | 2 +-
 addons/hr_expense/views/hr_expense_views.xml           | 2 +-
 addons/hr_holidays/report/hr_leave_reports.xml         | 2 +-
 addons/hr_holidays/views/hr_leave_allocation_views.xml | 3 +--
 addons/hr_holidays/views/hr_leave_views.xml            | 2 +-
 addons/hr_recruitment/views/hr_recruitment_views.xml   | 4 ++--
 8 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/addons/hr/views/hr_views.xml b/addons/hr/views/hr_views.xml
index 74f7cb32bfc..d02240f639d 100644
--- a/addons/hr/views/hr_views.xml
+++ b/addons/hr/views/hr_views.xml
@@ -177,7 +177,7 @@
             <field name="arch" type="xml">
                 <search string="Employees">
                     <field name="name" string="Employees" filter_domain="['|',('work_email','ilike',self),('name','ilike',self)]"/>
-                    <field name="department_id"/>
+                    <field name="department_id" operator="child_of"/>
                     <field name="category_ids" groups="hr.group_hr_user"/>
                     <field name="job_id" />
                     <filter string="Archived" name="inactive" domain="[('active','=',False)]"/>
@@ -440,7 +440,7 @@
                     <field name="name" string="Job"/>
                     <filter domain="[('state','=','open')]" name="in_position" string="In Position"/>
                     <filter domain="[('state','=','recruit')]" string="In Recruitment" name="in_recruitment"/>
-                    <field name="department_id"/>
+                    <field name="department_id" operator="child_of"/>
                     <separator/>
                     <filter string="Unread Messages" name="message_needaction" domain="[('message_needaction','=',True)]"/>
                     <group expand="0" string="Group By">
diff --git a/addons/hr_attendance/views/hr_attendance_view.xml b/addons/hr_attendance/views/hr_attendance_view.xml
index 4c7b33c0980..a3b7ca51c42 100644
--- a/addons/hr_attendance/views/hr_attendance_view.xml
+++ b/addons/hr_attendance/views/hr_attendance_view.xml
@@ -67,7 +67,7 @@
         <field name="arch" type="xml">
             <search string="Hr Attendance Search">
                 <field name="employee_id"/>
-                <field name="department_id"/>
+                <field name="department_id" operator="child_of"/>
                 <filter string="My Attendances" name="myattendances" domain="[('employee_id.user_id.id', '=', uid)]" />
                 <separator/>
                 <filter name="check_in_filter" string="Check In Date" date="check_in"/>
diff --git a/addons/hr_contract/views/hr_contract_views.xml b/addons/hr_contract/views/hr_contract_views.xml
index 537988666f1..af8e47cebce 100644
--- a/addons/hr_contract/views/hr_contract_views.xml
+++ b/addons/hr_contract/views/hr_contract_views.xml
@@ -54,7 +54,7 @@
                     <field name="date_end"/>
                     <field name="resource_calendar_id"/>
                     <field name="employee_id"/>
-                    <field name="department_id"/>
+                    <field name="department_id" operator="child_of"/>
                     <field name="state"/>
                     <filter string="To Renew" name="to_renew" domain="[('state', '=', 'pending')]"/>
                     <separator />
diff --git a/addons/hr_expense/views/hr_expense_views.xml b/addons/hr_expense/views/hr_expense_views.xml
index 92734975333..65c88d077e1 100644
--- a/addons/hr_expense/views/hr_expense_views.xml
+++ b/addons/hr_expense/views/hr_expense_views.xml
@@ -578,7 +578,7 @@
                     <field name="state"/>
                     <separator />
                     <field name="employee_id"/>
-                    <field name="department_id" string="Department"/>
+                    <field name="department_id" operator="child_of" string="Department"/>
                     <field name="journal_id"/>
                     <filter string="My Reports" name="my_reports" domain="[('employee_id.user_id', '=', uid)]"/>
                     <filter string="My Team Reports" name="my_team_reports" domain="[('employee_id.parent_id.user_id', '=', uid)]" groups="hr_expense.group_hr_expense_manager" help="Expenses of Your Team Member"/>
diff --git a/addons/hr_holidays/report/hr_leave_reports.xml b/addons/hr_holidays/report/hr_leave_reports.xml
index d4471fa8a72..3e3a09ddf6f 100644
--- a/addons/hr_holidays/report/hr_leave_reports.xml
+++ b/addons/hr_holidays/report/hr_leave_reports.xml
@@ -25,7 +25,7 @@
                 <filter string="My Requests" name="my_leaves" domain="[('employee_id.user_id', '=', uid)]"/>
                 <separator/>
                 <field name="employee_id"/>
-                <field name="department_id"/>
+                <field name="department_id" operator="child_of"/>
                 <field name="holiday_status_id"/>
                 <group expand="0" string="Group By">
                     <filter name="group_name" string="Description" context="{'group_by':'name'}"/>
diff --git a/addons/hr_holidays/views/hr_leave_allocation_views.xml b/addons/hr_holidays/views/hr_leave_allocation_views.xml
index a9973828ab7..ded0dbea531 100644
--- a/addons/hr_holidays/views/hr_leave_allocation_views.xml
+++ b/addons/hr_holidays/views/hr_leave_allocation_views.xml
@@ -24,8 +24,7 @@
                 <separator/>
                 <filter string="My Allocations" name="my_leaves" domain="[('employee_id.user_id', '=', uid)]"/>
                 <separator/>
-                <field name="employee_id"/>
-                <field name="department_id"/>
+                <field name="department_id" operator="child_of"/>
                 <field name="holiday_status_id"/>
                 <separator/>
                 <filter string="Late Activities" name="activities_overdue"
diff --git a/addons/hr_holidays/views/hr_leave_views.xml b/addons/hr_holidays/views/hr_leave_views.xml
index 24d0d2b9369..ce4631c89db 100644
--- a/addons/hr_holidays/views/hr_leave_views.xml
+++ b/addons/hr_holidays/views/hr_leave_views.xml
@@ -20,7 +20,7 @@
         <field name="arch" type="xml">
             <search string="Search Leave">
                 <field name="employee_id"/>
-                <field name="department_id"/>
+                <field name="department_id" operator="child_of"/>
                 <field name="holiday_status_id"/>
                 <field name="name"/>
                 <filter domain="[('state','in',('confirm','validate1'))]" string="To Approve" name="approve"/>
diff --git a/addons/hr_recruitment/views/hr_recruitment_views.xml b/addons/hr_recruitment/views/hr_recruitment_views.xml
index 5fa6424e959..9b2142d3b1a 100644
--- a/addons/hr_recruitment/views/hr_recruitment_views.xml
+++ b/addons/hr_recruitment/views/hr_recruitment_views.xml
@@ -201,7 +201,7 @@
                 <filter string="Unread Messages" name="message_needaction" domain="[('message_needaction','=',True)]"/>
                 <filter string="Archived" name="inactive" domain="[('active','=',False)]"/>
                 <field name="job_id"/>
-                <field name="department_id"/>
+                <field name="department_id" operator="child_of"/>
                 <field name="user_id"/>
                 <field name="stage_id" domain="[]"/>
                 <separator/>
@@ -907,7 +907,7 @@
         <field name="arch" type="xml">
             <search string="Recruitment Analysis">
                 <field name="job_id"/>
-                <field name="department_id"/>
+                <field name="department_id" operator="child_of"/>
                 <field name="user_id"/>
                 <filter string="Creation Date" name="year" date="create_date" default_period="this_year"/>
                 <separator/>