From a02d273ebcf0ba92243afd338c75cb1546065afc Mon Sep 17 00:00:00 2001
From: Hiral Bhavsar <hbh@odoo.com>
Date: Wed, 19 Dec 2018 07:28:06 +0000
Subject: [PATCH] [IMP] base, mail: set CRUD on activity view as attributes

Just like other views (form, list, kanban, etc.) CRUD operations (create,
delete and edit) are now set as attributes on the activity node based on
the user access rights.

Task 1894990
---
 addons/mail/static/src/js/views/activity/activity_controller.js | 1 +
 odoo/addons/base/models/ir_ui_view.py                           | 2 +-
 odoo/addons/base/rng/activity_view.rng                          | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/addons/mail/static/src/js/views/activity/activity_controller.js b/addons/mail/static/src/js/views/activity/activity_controller.js
index ede639a80fd..653596f5127 100644
--- a/addons/mail/static/src/js/views/activity/activity_controller.js
+++ b/addons/mail/static/src/js/views/activity/activity_controller.js
@@ -44,6 +44,7 @@ var ActivityController = BasicController.extend({
             res_model: state.model,
             domain: this.model.originalDomain,
             title: _.str.sprintf(_t("Search: %s"), this.renderer.arch.attrs.string),
+            no_create: !this.activeActions.create,
             disable_multiple_selection: true,
             on_selected: function (record) {
                 var fakeRecord = self.renderer.getKanbanActivityData({}, record[0]);
diff --git a/odoo/addons/base/models/ir_ui_view.py b/odoo/addons/base/models/ir_ui_view.py
index d317d7b0f9d..ddae4f21642 100644
--- a/odoo/addons/base/models/ir_ui_view.py
+++ b/odoo/addons/base/models/ir_ui_view.py
@@ -1177,7 +1177,7 @@ actual arch.
                         not self._context.get("create", True) and is_base_model):
                     node.set("create", 'false')
 
-        if node.tag in ('kanban', 'tree', 'form', 'gantt'):
+        if node.tag in ('kanban', 'tree', 'form', 'gantt', 'activity'):
             for action, operation in (('create', 'create'), ('delete', 'unlink'), ('edit', 'write')):
                 if (not node.get(action) and
                         not Model.check_access_rights(operation, raise_exception=False) or
diff --git a/odoo/addons/base/rng/activity_view.rng b/odoo/addons/base/rng/activity_view.rng
index 8109bb0e444..4560d03565e 100644
--- a/odoo/addons/base/rng/activity_view.rng
+++ b/odoo/addons/base/rng/activity_view.rng
@@ -8,6 +8,7 @@
     <define name="activity">
         <element name="activity">
             <attribute name="string"/>
+            <optional><attribute name="create"/></optional>
             <interleave>
                 <zeroOrMore><ref name="field"/></zeroOrMore>
                 <optional>